[jira] [Created] (SOLR-14890) Refactor code to use annotations for cluster API

2020-09-23 Thread Noble Paul (Jira)
Noble Paul created SOLR-14890: - Summary: Refactor code to use annotations for cluster API Key: SOLR-14890 URL: https://issues.apache.org/jira/browse/SOLR-14890 Project: Solr Issue Type: Bug

[GitHub] [lucene-solr] arafalov commented on pull request #1863: SOLR-14701: GuessSchemaFields URP to replace AddSchemaFields URP in schemaless mode

2020-09-23 Thread GitBox
arafalov commented on pull request #1863: URL: https://github.com/apache/lucene-solr/pull/1863#issuecomment-697179182 Strong words there "worse than useless", especially considering that this - to me - seems a strong improvement on the current schemaless mode as it looks at more values and

[GitHub] [lucene-solr] s1monw commented on pull request #1909: LUCENE-9539: Remove caches from SortingCodecReader

2020-09-23 Thread GitBox
s1monw commented on pull request #1909: URL: https://github.com/apache/lucene-solr/pull/1909#issuecomment-697184182 > I think our current DV format pulls doc values for a single field several times when flushing/merging, e.g. first to figure out whether the field is single-valued and how m

[GitHub] [lucene-solr] arafalov commented on pull request #1863: SOLR-14701: GuessSchemaFields URP to replace AddSchemaFields URP in schemaless mode

2020-09-23 Thread GitBox
arafalov commented on pull request #1863: URL: https://github.com/apache/lucene-solr/pull/1863#issuecomment-697188648 Also, I am not even sure there is a pathway to return a non-error message from commit that bin/post will echo to the user as a positive statement. For queries, yes. But we

[GitHub] [lucene-solr] noblepaul commented on pull request #1863: SOLR-14701: GuessSchemaFields URP to replace AddSchemaFields URP in schemaless mode

2020-09-23 Thread GitBox
noblepaul commented on pull request #1863: URL: https://github.com/apache/lucene-solr/pull/1863#issuecomment-697194702 >Strong words there "worse than useless", especially considering that this - to me - seems a strong improvement on the current schemaless mode as it looks at more values a

[GitHub] [lucene-solr] noblepaul opened a new pull request #1911: SOLR-14890: Refactor code to use annotations for cluster API

2020-09-23 Thread GitBox
noblepaul opened a new pull request #1911: URL: https://github.com/apache/lucene-solr/pull/1911 # Description Please provide a short description of the changes you're making with this pull request. # Solution Please provide a short description of the approac

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1909: LUCENE-9539: Remove caches from SortingCodecReader

2020-09-23 Thread GitBox
jpountz commented on a change in pull request #1909: URL: https://github.com/apache/lucene-solr/pull/1909#discussion_r493279172 ## File path: lucene/core/src/java/org/apache/lucene/index/SortingCodecReader.java ## @@ -510,4 +457,52 @@ public LeafMetaData getMetaData() { re

[GitHub] [lucene-solr] noblepaul closed pull request #1599: SOLR-14586: replace the second function parameter in computeIfAbsent …

2020-09-23 Thread GitBox
noblepaul closed pull request #1599: URL: https://github.com/apache/lucene-solr/pull/1599 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Created] (SOLR-14891) Upgrade Jetty to 9.4.28+ to fix Startup Warning

2020-09-23 Thread Bernd Wahlen (Jira)
Bernd Wahlen created SOLR-14891: --- Summary: Upgrade Jetty to 9.4.28+ to fix Startup Warning Key: SOLR-14891 URL: https://issues.apache.org/jira/browse/SOLR-14891 Project: Solr Issue Type: Wish

[jira] [Closed] (SOLR-14357) solrj: using insecure namedCurves

2020-09-23 Thread Bernd Wahlen (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bernd Wahlen closed SOLR-14357. --- > solrj: using insecure namedCurves > - > > Key: SOLR-143

[jira] [Closed] (SOLR-13862) JDK 13+Shenandoah stability/recovery problems

2020-09-23 Thread Bernd Wahlen (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bernd Wahlen closed SOLR-13862. --- > JDK 13+Shenandoah stability/recovery problems > - > >

[jira] [Updated] (SOLR-14891) Upgrade Jetty to 9.4.28+ to fix Startup Warning

2020-09-23 Thread Bernd Wahlen (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bernd Wahlen updated SOLR-14891: Affects Version/s: 8.6.2 > Upgrade Jetty to 9.4.28+ to fix Startup Warning > --

[jira] [Commented] (LUCENE-9535) Investigate recent indexing slowdown for wikimedium documents

2020-09-23 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200698#comment-17200698 ] Adrien Grand commented on LUCENE-9535: -- I tried to reproduce the slowdown locally b

[GitHub] [lucene-solr] Hronom commented on a change in pull request #1864: SOLR-14850 ExactStatsCache NullPointerException when shards.tolerant=true

2020-09-23 Thread GitBox
Hronom commented on a change in pull request #1864: URL: https://github.com/apache/lucene-solr/pull/1864#discussion_r493408910 ## File path: solr/core/src/java/org/apache/solr/search/stats/ExactStatsCache.java ## @@ -94,6 +94,12 @@ protected ShardRequest doRetrieveStatsRequest

[GitHub] [lucene-solr] Hronom commented on a change in pull request #1864: SOLR-14850 ExactStatsCache NullPointerException when shards.tolerant=true

2020-09-23 Thread GitBox
Hronom commented on a change in pull request #1864: URL: https://github.com/apache/lucene-solr/pull/1864#discussion_r493408910 ## File path: solr/core/src/java/org/apache/solr/search/stats/ExactStatsCache.java ## @@ -94,6 +94,12 @@ protected ShardRequest doRetrieveStatsRequest

[jira] [Commented] (LUCENE-9535) Investigate recent indexing slowdown for wikimedium documents

2020-09-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200713#comment-17200713 ] ASF subversion and git services commented on LUCENE-9535: - Commi

[jira] [Commented] (LUCENE-9535) Investigate recent indexing slowdown for wikimedium documents

2020-09-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200714#comment-17200714 ] ASF subversion and git services commented on LUCENE-9535: - Commi

[GitHub] [lucene-solr] jpountz opened a new pull request #1912: LUCENE-9535: Try to do larger flushes.

2020-09-23 Thread GitBox
jpountz opened a new pull request #1912: URL: https://github.com/apache/lucene-solr/pull/1912 DWPTPool currently always returns the last DWPT that was added to the pool. By returning the largest DWPT instead, we could try to do larger flushes by finishing DWPTs that are close to being

[GitHub] [lucene-solr] jimczi commented on a change in pull request #1903: Fix bug in sort optimization

2020-09-23 Thread GitBox
jimczi commented on a change in pull request #1903: URL: https://github.com/apache/lucene-solr/pull/1903#discussion_r493439005 ## File path: lucene/core/src/test/org/apache/lucene/search/TestFieldSortOptimizationSkipping.java ## @@ -432,7 +439,48 @@ public void testDocSortOpti

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1909: LUCENE-9539: Remove caches from SortingCodecReader

2020-09-23 Thread GitBox
s1monw commented on a change in pull request #1909: URL: https://github.com/apache/lucene-solr/pull/1909#discussion_r493477140 ## File path: lucene/core/src/java/org/apache/lucene/index/SortingCodecReader.java ## @@ -510,4 +457,52 @@ public LeafMetaData getMetaData() { ret

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1909: LUCENE-9539: Remove caches from SortingCodecReader

2020-09-23 Thread GitBox
s1monw commented on a change in pull request #1909: URL: https://github.com/apache/lucene-solr/pull/1909#discussion_r493482012 ## File path: lucene/core/src/java/org/apache/lucene/index/SortingCodecReader.java ## @@ -510,4 +457,52 @@ public LeafMetaData getMetaData() { ret

[GitHub] [lucene-solr] noblepaul edited a comment on pull request #1863: SOLR-14701: GuessSchemaFields URP to replace AddSchemaFields URP in schemaless mode

2020-09-23 Thread GitBox
noblepaul edited a comment on pull request #1863: URL: https://github.com/apache/lucene-solr/pull/1863#issuecomment-697194702 >Strong words there "worse than useless", especially considering that this - to me - seems a strong improvement on the current schemaless mode as it looks at more v

[GitHub] [lucene-solr] noblepaul edited a comment on pull request #1863: SOLR-14701: GuessSchemaFields URP to replace AddSchemaFields URP in schemaless mode

2020-09-23 Thread GitBox
noblepaul edited a comment on pull request #1863: URL: https://github.com/apache/lucene-solr/pull/1863#issuecomment-697194702 >Strong words there "worse than useless", especially considering that this - to me - seems a strong improvement on the current schemaless mode as it looks at more v

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1909: LUCENE-9539: Remove caches from SortingCodecReader

2020-09-23 Thread GitBox
jpountz commented on a change in pull request #1909: URL: https://github.com/apache/lucene-solr/pull/1909#discussion_r493490751 ## File path: lucene/core/src/java/org/apache/lucene/index/SortingCodecReader.java ## @@ -510,4 +457,52 @@ public LeafMetaData getMetaData() { re

[jira] [Updated] (SOLR-14890) Refactor code to use annotations for configset API

2020-09-23 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-14890: -- Summary: Refactor code to use annotations for configset API (was: Refactor code to use annotations for

[GitHub] [lucene-solr] noblepaul merged pull request #1911: SOLR-14890: Refactor code to use annotations for configset API

2020-09-23 Thread GitBox
noblepaul merged pull request #1911: URL: https://github.com/apache/lucene-solr/pull/1911 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (SOLR-14890) Refactor code to use annotations for configset API

2020-09-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200779#comment-17200779 ] ASF subversion and git services commented on SOLR-14890: Commit f

[GitHub] [lucene-solr] cpoerschke opened a new pull request #1913: SOLR-11167: Avoid $SOLR_STOP_WAIT use during 'bin/solr start' if $SOLR_START_WAIT is supplied.

2020-09-23 Thread GitBox
cpoerschke opened a new pull request #1913: URL: https://github.com/apache/lucene-solr/pull/1913 https://issues.apache.org/jira/browse/SOLR-11167 This is an automated message from the Apache Git Service. To respond to the mes

[jira] [Commented] (SOLR-14890) Refactor code to use annotations for configset API

2020-09-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200784#comment-17200784 ] ASF subversion and git services commented on SOLR-14890: Commit f

[jira] [Commented] (SOLR-14890) Refactor code to use annotations for configset API

2020-09-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200783#comment-17200783 ] ASF subversion and git services commented on SOLR-14890: Commit f

[jira] [Commented] (SOLR-11167) bin/solr uses $SOLR_STOP_WAIT during start

2020-09-23 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200786#comment-17200786 ] Christine Poerschke commented on SOLR-11167: Oops, a three year old ticket, n

[jira] [Assigned] (SOLR-11167) bin/solr uses $SOLR_STOP_WAIT during start

2020-09-23 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke reassigned SOLR-11167: -- Assignee: Christine Poerschke > bin/solr uses $SOLR_STOP_WAIT during start > -

[jira] [Updated] (SOLR-11167) bin/solr uses $SOLR_STOP_WAIT during start

2020-09-23 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke updated SOLR-11167: --- Fix Version/s: 8.7 master (9.0) > bin/solr uses $SOLR_STOP_WAIT du

[jira] [Commented] (LUCENE-9539) Improve memory footprint of SortingCodecReader

2020-09-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200789#comment-17200789 ] ASF subversion and git services commented on LUCENE-9539: - Commi

[GitHub] [lucene-solr] s1monw merged pull request #1909: LUCENE-9539: Remove caches from SortingCodecReader

2020-09-23 Thread GitBox
s1monw merged pull request #1909: URL: https://github.com/apache/lucene-solr/pull/1909 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-9539) Improve memory footprint of SortingCodecReader

2020-09-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200795#comment-17200795 ] ASF subversion and git services commented on LUCENE-9539: - Commi

[jira] [Assigned] (SOLR-14503) Solr does not respect waitForZk (SOLR_WAIT_FOR_ZK) property

2020-09-23 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N reassigned SOLR-14503: --- Assignee: Munendra S N > Solr does not respect waitForZk (SOLR_WAIT_FOR_ZK) property > -

[jira] [Commented] (SOLR-14503) Solr does not respect waitForZk (SOLR_WAIT_FOR_ZK) property

2020-09-23 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200808#comment-17200808 ] Munendra S N commented on SOLR-14503: - I'm planning to commit current patch and handl

[jira] [Assigned] (SOLR-14333) Implement toString() in CollapsingPostFilter

2020-09-23 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N reassigned SOLR-14333: --- Assignee: Munendra S N > Implement toString() in CollapsingPostFilter >

[jira] [Commented] (SOLR-14503) Solr does not respect waitForZk (SOLR_WAIT_FOR_ZK) property

2020-09-23 Thread Colvin Cowie (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200811#comment-17200811 ] Colvin Cowie commented on SOLR-14503: - Hi [~munendrasn], thanks. Sorry I've not got a

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1903: Fix bug in sort optimization

2020-09-23 Thread GitBox
mayya-sharipova commented on a change in pull request #1903: URL: https://github.com/apache/lucene-solr/pull/1903#discussion_r493568956 ## File path: lucene/core/src/test/org/apache/lucene/search/TestFieldSortOptimizationSkipping.java ## @@ -432,7 +439,48 @@ public void testDo

[GitHub] [lucene-solr] mayya-sharipova merged pull request #1903: Fix bug in sort optimization

2020-09-23 Thread GitBox
mayya-sharipova merged pull request #1903: URL: https://github.com/apache/lucene-solr/pull/1903 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [lucene-solr] munendrasn commented on pull request #1900: SOLR-14036: Remove explicit distrib=false from /terms handler

2020-09-23 Thread GitBox
munendrasn commented on pull request #1900: URL: https://github.com/apache/lucene-solr/pull/1900#issuecomment-697360102 I have included the changes and upgrade entry. Instead of adding upgrade entry to `solr-upgrade-notes.adoc`, I have added to `major-changes-in-solr-9.adoc` as mentioned t

[GitHub] [lucene-solr] munendrasn opened a new pull request #1914: Move 9x upgrade notes out of changes.txt

2020-09-23 Thread GitBox
munendrasn opened a new pull request #1914: URL: https://github.com/apache/lucene-solr/pull/1914 Upgrade notes have been moved out of changes.txt. While working on PR #1900, I found there were few entries which were still present in changes.txt (most likely added at a later time) ---

[jira] [Commented] (SOLR-14787) Inequality support in Payload Check query parser

2020-09-23 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200828#comment-17200828 ] Gus Heck commented on SOLR-14787: - I have found something interesting WRT the failing cas

[GitHub] [lucene-solr] munendrasn commented on pull request #1914: Move 9x upgrade notes out of changes.txt

2020-09-23 Thread GitBox
munendrasn commented on pull request #1914: URL: https://github.com/apache/lucene-solr/pull/1914#issuecomment-697368032 @noblepaul @sigram Please review. I have moved the entries added by you guys, so would prefer your reviews --

[GitHub] [lucene-solr] mocobeta commented on pull request #1836: LUCENE-9317: Clean up split package in analyzers-common

2020-09-23 Thread GitBox
mocobeta commented on pull request #1836: URL: https://github.com/apache/lucene-solr/pull/1836#issuecomment-697375125 @uschindler seems busy. I don't want to maintain this branch for very long (the diff is so large), but I need at least one reviewer to proceed this. @dweiss would

[jira] [Created] (LUCENE-9541) BitSetConjunctionDISI can advance backwards from its components

2020-09-23 Thread Mayya Sharipova (Jira)
Mayya Sharipova created LUCENE-9541: --- Summary: BitSetConjunctionDISI can advance backwards from its components Key: LUCENE-9541 URL: https://issues.apache.org/jira/browse/LUCENE-9541 Project: Lucene

[jira] [Updated] (LUCENE-9541) BitSetConjunctionDISI can advance to docs before its components

2020-09-23 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova updated LUCENE-9541: Summary: BitSetConjunctionDISI can advance to docs before its components (was: BitSetConj

[jira] [Updated] (LUCENE-9541) BitSetConjunctionDISI can advance to docs before its components

2020-09-23 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova updated LUCENE-9541: Description: Not completely sure if this is a bug. BitSetConjuctionDISI advances based on

[jira] [Updated] (LUCENE-9541) BitSetConjunctionDISI can advance to docs before its components

2020-09-23 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova updated LUCENE-9541: Description: Not completely sure if this is a bug. BitSetConjuctionDISI advances based on

[jira] [Updated] (LUCENE-9541) BitSetConjunctionDISI doesn't advance based on its components

2020-09-23 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova updated LUCENE-9541: Summary: BitSetConjunctionDISI doesn't advance based on its components (was: BitSetConjun

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1903: Fix bug in sort optimization

2020-09-23 Thread GitBox
mayya-sharipova commented on a change in pull request #1903: URL: https://github.com/apache/lucene-solr/pull/1903#discussion_r493610854 ## File path: lucene/core/src/test/org/apache/lucene/search/TestFieldSortOptimizationSkipping.java ## @@ -432,7 +439,48 @@ public void testDo

[GitHub] [lucene-solr] arafalov commented on pull request #1863: SOLR-14701: GuessSchemaFields URP to replace AddSchemaFields URP in schemaless mode

2020-09-23 Thread GitBox
arafalov commented on pull request #1863: URL: https://github.com/apache/lucene-solr/pull/1863#issuecomment-697406760 Ok, I am glad we are on the same page that the current (let's call it _Add_) solution is rather bad despite all the great work put into it. Let's now get onto the same page

[jira] [Commented] (SOLR-8281) Add RollupMergeStream to Streaming API

2020-09-23 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200848#comment-17200848 ] Gus Heck commented on SOLR-8281: This seems related to something I wanted to do for a clie

[GitHub] [lucene-solr] HoustonPutman commented on pull request #1863: SOLR-14701: GuessSchemaFields URP to replace AddSchemaFields URP in schemaless mode

2020-09-23 Thread GitBox
HoustonPutman commented on pull request #1863: URL: https://github.com/apache/lucene-solr/pull/1863#issuecomment-697420014 Purely responding to the URP response part, it’s definitely not possible for URP to send non-error responses. I do think its something we should implement though, sinc

[GitHub] [lucene-solr] mayya-sharipova opened a new pull request #1915: Fix bug in sort optimization (#1903)

2020-09-23 Thread GitBox
mayya-sharipova opened a new pull request #1915: URL: https://github.com/apache/lucene-solr/pull/1915 Fix bug how iterator with skipping functionality advances and produces docs Relates to #1725 Backport for #1903 ---

[GitHub] [lucene-solr] mayya-sharipova merged pull request #1915: Fix bug in sort optimization (#1903)

2020-09-23 Thread GitBox
mayya-sharipova merged pull request #1915: URL: https://github.com/apache/lucene-solr/pull/1915 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [lucene-solr] dalbani opened a new pull request #1916: Fix minor typo

2020-09-23 Thread GitBox
dalbani opened a new pull request #1916: URL: https://github.com/apache/lucene-solr/pull/1916 Ignoring the default issue template given that this PR is about a tiny fix for a typo. Right? This is an automated message from th

[GitHub] [lucene-solr] Hronom commented on a change in pull request #1864: SOLR-14850 ExactStatsCache NullPointerException when shards.tolerant=true

2020-09-23 Thread GitBox
Hronom commented on a change in pull request #1864: URL: https://github.com/apache/lucene-solr/pull/1864#discussion_r493662797 ## File path: solr/core/src/java/org/apache/solr/search/stats/ExactStatsCache.java ## @@ -94,6 +94,12 @@ protected ShardRequest doRetrieveStatsRequest

[GitHub] [lucene-solr] Hronom commented on a change in pull request #1864: SOLR-14850 ExactStatsCache NullPointerException when shards.tolerant=true

2020-09-23 Thread GitBox
Hronom commented on a change in pull request #1864: URL: https://github.com/apache/lucene-solr/pull/1864#discussion_r493662797 ## File path: solr/core/src/java/org/apache/solr/search/stats/ExactStatsCache.java ## @@ -94,6 +94,12 @@ protected ShardRequest doRetrieveStatsRequest

[GitHub] [lucene-solr] Hronom commented on a change in pull request #1864: SOLR-14850 ExactStatsCache NullPointerException when shards.tolerant=true

2020-09-23 Thread GitBox
Hronom commented on a change in pull request #1864: URL: https://github.com/apache/lucene-solr/pull/1864#discussion_r493662797 ## File path: solr/core/src/java/org/apache/solr/search/stats/ExactStatsCache.java ## @@ -94,6 +94,12 @@ protected ShardRequest doRetrieveStatsRequest

[GitHub] [lucene-solr] Hronom commented on a change in pull request #1864: SOLR-14850 ExactStatsCache NullPointerException when shards.tolerant=true

2020-09-23 Thread GitBox
Hronom commented on a change in pull request #1864: URL: https://github.com/apache/lucene-solr/pull/1864#discussion_r493662797 ## File path: solr/core/src/java/org/apache/solr/search/stats/ExactStatsCache.java ## @@ -94,6 +94,12 @@ protected ShardRequest doRetrieveStatsRequest

[GitHub] [lucene-solr] Hronom commented on a change in pull request #1864: SOLR-14850 ExactStatsCache NullPointerException when shards.tolerant=true

2020-09-23 Thread GitBox
Hronom commented on a change in pull request #1864: URL: https://github.com/apache/lucene-solr/pull/1864#discussion_r493662797 ## File path: solr/core/src/java/org/apache/solr/search/stats/ExactStatsCache.java ## @@ -94,6 +94,12 @@ protected ShardRequest doRetrieveStatsRequest

[GitHub] [lucene-solr] madrob commented on pull request #1916: Fix minor typo

2020-09-23 Thread GitBox
madrob commented on pull request #1916: URL: https://github.com/apache/lucene-solr/pull/1916#issuecomment-697511015 Thank you for finding and correcting this! This is an automated message from the Apache Git Service. To respo

[GitHub] [lucene-solr] madrob merged pull request #1916: Fix minor typo

2020-09-23 Thread GitBox
madrob merged pull request #1916: URL: https://github.com/apache/lucene-solr/pull/1916 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (SOLR-8281) Add RollupMergeStream to Streaming API

2020-09-23 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200886#comment-17200886 ] Joel Bernstein commented on SOLR-8281: -- [~gus], feel free to send me an email to disc

[GitHub] [lucene-solr] jpountz opened a new pull request #1917: LUCENE-9535: Make ByteBuffersDataOutput#ramBytesUsed run in constant-time.

2020-09-23 Thread GitBox
jpountz opened a new pull request #1917: URL: https://github.com/apache/lucene-solr/pull/1917 This is called transitively from `DocumentsWriterFlushControl#doAfterDocument` which is synchronized and appears to be a point of contention.

[jira] [Commented] (LUCENE-9535) Investigate recent indexing slowdown for wikimedium documents

2020-09-23 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200946#comment-17200946 ] Adrien Grand commented on LUCENE-9535: -- I might have found something. When profilin

[GitHub] [lucene-solr] jpountz merged pull request #1917: LUCENE-9535: Make ByteBuffersDataOutput#ramBytesUsed run in constant-time.

2020-09-23 Thread GitBox
jpountz merged pull request #1917: URL: https://github.com/apache/lucene-solr/pull/1917 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-9535) Investigate recent indexing slowdown for wikimedium documents

2020-09-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201008#comment-17201008 ] ASF subversion and git services commented on LUCENE-9535: - Commi

[jira] [Commented] (LUCENE-9535) Investigate recent indexing slowdown for wikimedium documents

2020-09-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201011#comment-17201011 ] ASF subversion and git services commented on LUCENE-9535: - Commi

[jira] [Commented] (LUCENE-9535) Investigate recent indexing slowdown for wikimedium documents

2020-09-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201010#comment-17201010 ] ASF subversion and git services commented on LUCENE-9535: - Commi

[jira] [Commented] (LUCENE-9535) Investigate recent indexing slowdown for wikimedium documents

2020-09-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201013#comment-17201013 ] ASF subversion and git services commented on LUCENE-9535: - Commi

[jira] [Commented] (LUCENE-9535) Investigate recent indexing slowdown for wikimedium documents

2020-09-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201012#comment-17201012 ] ASF subversion and git services commented on LUCENE-9535: - Commi

[GitHub] [lucene-solr] arafalov commented on pull request #1863: SOLR-14701: GuessSchemaFields URP to replace AddSchemaFields URP in schemaless mode

2020-09-23 Thread GitBox
arafalov commented on pull request #1863: URL: https://github.com/apache/lucene-solr/pull/1863#issuecomment-697846565 > Purely responding to the URP response part, it’s definitely not possible for URP to send non-error responses. I do think its something we should implement though, since i

[GitHub] [lucene-solr] s1monw opened a new pull request #1918: LUCENE-9535: Commit DWPT bytes used before locking indexing

2020-09-23 Thread GitBox
s1monw opened a new pull request #1918: URL: https://github.com/apache/lucene-solr/pull/1918 Currently we calcualte the ramBytesUsed by the DWPT under the flushControl lock. We can do this caculation safely outside of the lock without any downside. The FlushControl lock should be used

[jira] [Created] (SOLR-14892) shards.info with shards.tolerant can yield an empty key

2020-09-23 Thread David Smiley (Jira)
David Smiley created SOLR-14892: --- Summary: shards.info with shards.tolerant can yield an empty key Key: SOLR-14892 URL: https://issues.apache.org/jira/browse/SOLR-14892 Project: Solr Issue Type

[jira] [Updated] (SOLR-14892) shards.info with shards.tolerant can yield an empty key

2020-09-23 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-14892: Attachment: solr14892.png > shards.info with shards.tolerant can yield an empty key > -

[jira] [Created] (SOLR-14893) Allow UpdateRequestProcessors to add non-error messages to the response

2020-09-23 Thread Houston Putman (Jira)
Houston Putman created SOLR-14893: - Summary: Allow UpdateRequestProcessors to add non-error messages to the response Key: SOLR-14893 URL: https://issues.apache.org/jira/browse/SOLR-14893 Project: Solr

[jira] [Commented] (SOLR-14892) shards.info with shards.tolerant can yield an empty key

2020-09-23 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201038#comment-17201038 ] David Smiley commented on SOLR-14892: - I chased this down to org.apache.solr.handler

[GitHub] [lucene-solr] dweiss commented on pull request #1836: LUCENE-9317: Clean up split package in analyzers-common

2020-09-23 Thread GitBox
dweiss commented on pull request #1836: URL: https://github.com/apache/lucene-solr/pull/1836#issuecomment-697932731 Hi Tomoko. The patch looks good to me (precommit doesn't pass though). I would commit it in once you get precommit to work - this issue has been out there for a while, nobody

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1905: LUCENE-9488 Release with Gradle Part 2

2020-09-23 Thread GitBox
dweiss commented on a change in pull request #1905: URL: https://github.com/apache/lucene-solr/pull/1905#discussion_r493853135 ## File path: lucene/build.gradle ## @@ -15,8 +15,56 @@ * limitations under the License. */ +// Should we do this as :lucene:packaging similar to

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1900: SOLR-14036: Remove explicit distrib=false from /terms handler

2020-09-23 Thread GitBox
dsmiley commented on a change in pull request #1900: URL: https://github.com/apache/lucene-solr/pull/1900#discussion_r493862362 ## File path: solr/solr-ref-guide/src/major-changes-in-solr-9.adoc ## @@ -128,6 +128,8 @@ _(raw; not yet edited)_ * SOLR-14510: The `writeStartDocume

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

2020-09-23 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201067#comment-17201067 ] Ishan Chattopadhyaya commented on SOLR-14354: - This doesn't have associated p

[GitHub] [lucene-solr] madrob commented on a change in pull request #1905: LUCENE-9488 Release with Gradle Part 2

2020-09-23 Thread GitBox
madrob commented on a change in pull request #1905: URL: https://github.com/apache/lucene-solr/pull/1905#discussion_r493884949 ## File path: lucene/build.gradle ## @@ -15,8 +15,56 @@ * limitations under the License. */ +// Should we do this as :lucene:packaging similar to

[jira] [Commented] (LUCENE-9537) Add Indri Search Engine Functionality to Lucene

2020-09-23 Thread Cameron VandenBerg (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201089#comment-17201089 ] Cameron VandenBerg commented on LUCENE-9537: Hi Adrien, Unfortunately, the

[jira] [Commented] (SOLR-13682) command line option to export data to a file

2020-09-23 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201092#comment-17201092 ] David Smiley commented on SOLR-13682: - The ref-guide addition to solr-control-script-

[GitHub] [lucene-solr] uschindler commented on pull request #1836: LUCENE-9317: Clean up split package in analyzers-common

2020-09-23 Thread GitBox
uschindler commented on pull request #1836: URL: https://github.com/apache/lucene-solr/pull/1836#issuecomment-697990504 > Create fake factory base classes in o.a.l.a.util for backward compatibility (?) We do this only in Lucene 9, so more important to add all changes to MIGRATE.md

[GitHub] [lucene-solr] goankur commented on a change in pull request #1893: LUCENE-9444 Utility class to get facet labels from taxonomy for a fac…

2020-09-23 Thread GitBox
goankur commented on a change in pull request #1893: URL: https://github.com/apache/lucene-solr/pull/1893#discussion_r493919329 ## File path: lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyLabels.java ## @@ -0,0 +1,192 @@ +/* + * Licensed to the Apache Soft

[jira] [Updated] (SOLR-14889) improve templated variable escaping in ref-guide _config.yml

2020-09-23 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-14889: -- Attachment: SOLR-14889.patch Status: Open (was: Open) I thought this would be

[jira] [Commented] (SOLR-14889) improve templated variable escaping in ref-guide _config.yml

2020-09-23 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201157#comment-17201157 ] Uwe Schindler commented on SOLR-14889: -- That's very easy to explain: The expansion i

[jira] [Comment Edited] (SOLR-14889) improve templated variable escaping in ref-guide _config.yml

2020-09-23 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201157#comment-17201157 ] Uwe Schindler edited comment on SOLR-14889 at 9/23/20, 11:13 PM: --

[jira] [Updated] (SOLR-14889) improve templated variable escaping in ref-guide _config.yml

2020-09-23 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated SOLR-14889: - Attachment: SOLR-14889.patch > improve templated variable escaping in ref-guide _config.yml > ---

[jira] [Commented] (SOLR-14889) improve templated variable escaping in ref-guide _config.yml

2020-09-23 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201162#comment-17201162 ] Uwe Schindler commented on SOLR-14889: -- Here is my fix: [^SOLR-14889.patch] You n

[jira] [Comment Edited] (SOLR-14889) improve templated variable escaping in ref-guide _config.yml

2020-09-23 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201162#comment-17201162 ] Uwe Schindler edited comment on SOLR-14889 at 9/23/20, 11:27 PM: --

[jira] [Commented] (SOLR-14889) improve templated variable escaping in ref-guide _config.yml

2020-09-23 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201164#comment-17201164 ] Uwe Schindler commented on SOLR-14889: -- I also changed the logger.warn to logger.lif

[jira] [Updated] (SOLR-14889) improve templated variable escaping in ref-guide _config.yml

2020-09-23 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated SOLR-14889: - Attachment: SOLR-14889.patch > improve templated variable escaping in ref-guide _config.yml > ---

[jira] [Commented] (SOLR-14889) improve templated variable escaping in ref-guide _config.yml

2020-09-23 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201177#comment-17201177 ] Uwe Schindler commented on SOLR-14889: -- Small update: [^SOLR-14889.patch] "replac

[jira] [Commented] (SOLR-14354) HttpShardHandler send requests in async

2020-09-23 Thread Cao Manh Dat (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201179#comment-17201179 ] Cao Manh Dat commented on SOLR-14354: - Thank Mark for your nice words.  [~ichattopad

  1   2   >