[ 
https://issues.apache.org/jira/browse/SOLR-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200786#comment-17200786
 ] 

Christine Poerschke commented on SOLR-11167:
--------------------------------------------

Oops, a three year old ticket, not quite sure what happened here, apologies 
[~omar_abdelnabi]. Thanks for attaching a patch!

The patch after all this time unfortunately doesn't apply to the current master 
branch anymore. Hence I've replaced it with 
[https://github.com/apache/lucene-solr/pull/1913] instead, with two small 
differences:
 * {{solr.in.cmd}} changes left out of scope i.e. since it does not yet use 
$SOLR_STOP_WAIT currently it would be clearer to separately add 
$SOLR_START_WAIT and $SOLR_STOP_WAIT support for {{solr.cmd}}
 * instead of {{SOLR_START_WAIT=180}} initialisation (if no SOLR_START_WAIT was 
supplied) using {{SOLR_START_WAIT=$SOLR_STOP_WAIT}} will help ensure backwards 
compatibility for users that currently customise SOLR_STOP_WAIT e.g. anyone is 
currently setting {{SOLR_STOP_WAIT=42}} then they will continue to see 42s used 
for both stop and start even if they don't explicitly configure 
{{SOLR_START_WAIT=42}}

> bin/solr uses $SOLR_STOP_WAIT during start
> ------------------------------------------
>
>                 Key: SOLR-11167
>                 URL: https://issues.apache.org/jira/browse/SOLR-11167
>             Project: Solr
>          Issue Type: Improvement
>          Components: scripts and tools
>            Reporter: Christine Poerschke
>            Priority: Minor
>         Attachments: SOLR-11167.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> bin/solr using $SOLR_STOP_WAIT during start is unexpected, I think it would 
> be clearer to have a separate $SOLR_START_WAIT variable.
> related minor thing: SOLR_STOP_WAIT is mentioned in solr.in.sh but not in 
> solr.in.cmd equivalent.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to