[jira] [Commented] (SOLR-13681) make Lucene's index sorting directly configurable in Solr

[ https://issues.apache.org/jira/browse/SOLR-13681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189372#comment-17189372 ] Christine Poerschke commented on SOLR-13681: ticket cross-referencing: SOLR-1

[jira] [Commented] (SOLR-14820) Create replica is broken

[ https://issues.apache.org/jira/browse/SOLR-14820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189564#comment-17189564 ] Christine Poerschke commented on SOLR-14820: Thanks [~thomas.woeckinger] for

[GitHub] [lucene-solr] TomMD commented on a change in pull request #1818: SOLR-14819 Trivial fix to inefficient iterator pattern

TomMD commented on a change in pull request #1818: URL: https://github.com/apache/lucene-solr/pull/1818#discussion_r482245426 ## File path: solr/solrj/src/java/org/apache/solr/common/util/JsonSchemaValidator.java ## @@ -48,13 +48,15 @@ public JsonSchemaValidator(String jsonStr

[jira] [Commented] (LUCENE-9317) Resolve package name conflicts for StandardAnalyzer to allow Java module system support

[ https://issues.apache.org/jira/browse/LUCENE-9317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189575#comment-17189575 ] Uwe Schindler commented on LUCENE-9317: --- Hi, I am a bit busy with Gradle... give m

[jira] [Commented] (LUCENE-9215) replace checkJavaDocs.py with doclet

[ https://issues.apache.org/jira/browse/LUCENE-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189588#comment-17189588 ] ASF subversion and git services commented on LUCENE-9215: - Commi

[jira] [Commented] (SOLR-14783) Remove DIH from 9.0

[ https://issues.apache.org/jira/browse/SOLR-14783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189587#comment-17189587 ] ASF subversion and git services commented on SOLR-14783: Commit 2

[GitHub] [lucene-solr] sigram commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

sigram commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482181180 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/Node.java ## @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache Software Foundation (AS

[jira] [Commented] (LUCENE-9444) Need an API to easily fetch facet labels for a field in a document

[ https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189618#comment-17189618 ] Ankur commented on LUCENE-9444: --- Here is a patch that adds a new utility class - `Taxonomy

[jira] [Comment Edited] (LUCENE-9444) Need an API to easily fetch facet labels for a field in a document

[ https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189618#comment-17189618 ] Ankur edited comment on LUCENE-9444 at 9/2/20, 6:27 PM: Here is

[jira] [Comment Edited] (LUCENE-9444) Need an API to easily fetch facet labels for a field in a document

[ https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189618#comment-17189618 ] Ankur edited comment on LUCENE-9444 at 9/2/20, 6:28 PM: Here is

[jira] [Comment Edited] (LUCENE-9444) Need an API to easily fetch facet labels for a field in a document

[ https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189618#comment-17189618 ] Ankur edited comment on LUCENE-9444 at 9/2/20, 6:33 PM: Here is

[jira] [Comment Edited] (LUCENE-9444) Need an API to easily fetch facet labels for a field in a document

[ https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189618#comment-17189618 ] Ankur edited comment on LUCENE-9444 at 9/2/20, 6:35 PM: Here is

[GitHub] [lucene-solr] vthacker commented on pull request #1816: LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation

vthacker commented on pull request #1816: URL: https://github.com/apache/lucene-solr/pull/1816#issuecomment-685924654 Looks like this is duplicate of LUCENE-9411? This is an automated message from the Apache Git Service. To

[jira] [Resolved] (SOLR-14793) Clean up tests that log access permission violations.

[ https://issues.apache.org/jira/browse/SOLR-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-14793. --- Resolution: Invalid Somehow I thought there were only a handful of these, in which fixing the

[jira] [Created] (SOLR-14824) Simplify set of Ref Guide build parameters

Cassandra Targett created SOLR-14824: Summary: Simplify set of Ref Guide build parameters Key: SOLR-14824 URL: https://issues.apache.org/jira/browse/SOLR-14824 Project: Solr Issue Type: I

[jira] [Resolved] (LUCENE-9495) Ref Guide gradle buildSite ignores version parameter

[ https://issues.apache.org/jira/browse/LUCENE-9495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cassandra Targett resolved LUCENE-9495. --- Resolution: Information Provided Closing this as the info I needed was provided and

[GitHub] [lucene-solr] dweiss commented on pull request #1816: LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation

dweiss commented on pull request #1816: URL: https://github.com/apache/lucene-solr/pull/1816#issuecomment-685957523 I don't think so. That issue only added dependencies, it has nothing to do with running static analysis using that tool.

[jira] [Created] (LUCENE-9501) IndexSortSortedNumericDocValuesRangeQuery violates iterator invariant.

Julie Tibshirani created LUCENE-9501: Summary: IndexSortSortedNumericDocValuesRangeQuery violates iterator invariant. Key: LUCENE-9501 URL: https://issues.apache.org/jira/browse/LUCENE-9501 Projec

[GitHub] [lucene-solr] uschindler commented on pull request #1816: LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation

uschindler commented on pull request #1816: URL: https://github.com/apache/lucene-solr/pull/1816#issuecomment-685972773 Why is there this strange dependency? Listing it under plugins should be enough. Especially, build tools should not be listed in versions.props and instead just ad

[jira] [Updated] (LUCENE-9501) IndexSortSortedNumericDocValuesRangeQuery violates iterator invariant.

[ https://issues.apache.org/jira/browse/LUCENE-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julie Tibshirani updated LUCENE-9501: - Description: In LUCENE-7714 we added a new query to sandbox called IndexSortSortedNumer

[GitHub] [lucene-solr] jtibshirani edited a comment on pull request #1817: Improve how Asserting* classes handle singleton doc values.

jtibshirani edited a comment on pull request #1817: URL: https://github.com/apache/lucene-solr/pull/1817#issuecomment-685192326 I noticed this when debugging a bad bug in `IndexSortSortedNumericDocValuesRangeQuery` that wasn't caught by tests (LUCENE-9501). As a follow-up I plan to make at

[jira] [Commented] (LUCENE-9501) IndexSortSortedNumericDocValuesRangeQuery violates iterator invariant.

[ https://issues.apache.org/jira/browse/LUCENE-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189693#comment-17189693 ] Julie Tibshirani commented on LUCENE-9501: -- Here's the first change around Asse

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482422332 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/AddReplicasPlacementRequest.java ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apac

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482424919 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/Cluster.java ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [lucene-solr] jtibshirani commented on pull request #1817: Improve how Asserting* classes handle singleton doc values.

jtibshirani commented on pull request #1817: URL: https://github.com/apache/lucene-solr/pull/1817#issuecomment-685981921 Thanks for the review. Let me know if I should add a changelog entry or issue number (I wasn't sure what to do for smaller test fixes like this). --

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482428206 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/PlacementPluginConfig.java ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Sof

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482436534 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/PropertyValue.java ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software F

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482438858 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/Replica.java ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1789: LUCENE-9484: Allow sorting an index after the fact

jpountz commented on a change in pull request #1789: URL: https://github.com/apache/lucene-solr/pull/1789#discussion_r482418961 ## File path: lucene/core/src/java/org/apache/lucene/index/NumericDocValuesWriter.java ## @@ -165,4 +166,62 @@ public long longValue() { retur

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1789: LUCENE-9484: Allow sorting an index after the fact

jpountz commented on a change in pull request #1789: URL: https://github.com/apache/lucene-solr/pull/1789#discussion_r482419163 ## File path: lucene/core/src/java/org/apache/lucene/index/NumericDocValuesWriter.java ## @@ -165,4 +166,62 @@ public long longValue() { retur

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1789: LUCENE-9484: Allow sorting an index after the fact

jpountz commented on a change in pull request #1789: URL: https://github.com/apache/lucene-solr/pull/1789#discussion_r482434175 ## File path: lucene/core/src/java/org/apache/lucene/index/BinaryDocValuesWriter.java ## @@ -202,4 +203,63 @@ public BytesRef binaryValue() {

[GitHub] [lucene-solr] jpountz commented on pull request #1817: Improve how Asserting* classes handle singleton doc values.

jpountz commented on pull request #1817: URL: https://github.com/apache/lucene-solr/pull/1817#issuecomment-685989419 Good question. The test framework is used by our users so I think it makes sense to mention this change in the changelog. --

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482447666 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/Replica.java ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [lucene-solr] quinzeromain opened a new pull request #1822: Update french_stop.txt

quinzeromain opened a new pull request #1822: URL: https://github.com/apache/lucene-solr/pull/1822 Adding the term 'ça' corresponding to the shortened form of 'that' Adding the term 'où' corresponding to "where" because 'ou' corresponds to "or" Adding the term 'elles' corresponding to

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482463350 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/PropertyKeyFactory.java ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482463350 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/PropertyKeyFactory.java ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482476548 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/SolrCollection.java ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software F

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482477360 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/PlacementPluginFactoryFacade.java ## @@ -0,0 +1,75 @@ +/* + * Licensed to th

[GitHub] [lucene-solr] rmuir commented on pull request #1822: Update french_stop.txt

rmuir commented on pull request #1822: URL: https://github.com/apache/lucene-solr/pull/1822#issuecomment-686005054 Hi: this list is automatically generated from `snowball-website` by `gradle regenerate`. Would you mind submitting this PR to the upstream https://github.com/snowballstem/snow

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482478563 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/PluginInteractionsImpl.java ## @@ -0,0 +1,190 @@ +/* Review comment:

[jira] [Commented] (SOLR-14383) Fix indexing-nested-documents.adoc XML/JSON examples to be accurate, consistent, and clear

[ https://issues.apache.org/jira/browse/SOLR-14383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189715#comment-17189715 ] ASF subversion and git services commented on SOLR-14383: Commit a

[jira] [Commented] (SOLR-14383) Fix indexing-nested-documents.adoc XML/JSON examples to be accurate, consistent, and clear

[ https://issues.apache.org/jira/browse/SOLR-14383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189713#comment-17189713 ] ASF subversion and git services commented on SOLR-14383: Commit a

[jira] [Commented] (SOLR-14383) Fix indexing-nested-documents.adoc XML/JSON examples to be accurate, consistent, and clear

[ https://issues.apache.org/jira/browse/SOLR-14383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189714#comment-17189714 ] ASF subversion and git services commented on SOLR-14383: Commit a

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482485955 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/plugins/SamplePluginMinimizeCores.java ## @@ -0,0 +1,132 @@ +/* + * Licensed to t

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482487876 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/PropertyValue.java ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software F

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189723#comment-17189723 ] Robert Muir commented on LUCENE-9500: - https://github.com/openjdk/jdk/blob/1643bc3de

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189726#comment-17189726 ] Robert Muir commented on LUCENE-9500: - [~uschindler] this is a good one to report to

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189738#comment-17189738 ] Robert Muir commented on LUCENE-9500: - I think as a workaround we should arraycopy p

[jira] [Commented] (SOLR-14383) Fix indexing-nested-documents.adoc XML/JSON examples to be accurate, consistent, and clear

[ https://issues.apache.org/jira/browse/SOLR-14383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189740#comment-17189740 ] ASF subversion and git services commented on SOLR-14383: Commit 6

[jira] [Commented] (SOLR-14383) Fix indexing-nested-documents.adoc XML/JSON examples to be accurate, consistent, and clear

[ https://issues.apache.org/jira/browse/SOLR-14383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189739#comment-17189739 ] ASF subversion and git services commented on SOLR-14383: Commit 6

[jira] [Commented] (SOLR-14383) Fix indexing-nested-documents.adoc XML/JSON examples to be accurate, consistent, and clear

[ https://issues.apache.org/jira/browse/SOLR-14383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189742#comment-17189742 ] ASF subversion and git services commented on SOLR-14383: Commit 6

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189741#comment-17189741 ] Uwe Schindler commented on LUCENE-9500: --- Hi, will report this one tomorrow mornin

[jira] [Comment Edited] (LUCENE-9500) Did we hit a DEFLATE bug?

[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189741#comment-17189741 ] Uwe Schindler edited comment on LUCENE-9500 at 9/2/20, 10:16 PM: -

[jira] [Updated] (SOLR-14383) Fix indexing-nested-documents.adoc XML/JSON examples to be accurate, consistent, and clear

[ https://issues.apache.org/jira/browse/SOLR-14383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-14383: -- Fix Version/s: 8.7 master (9.0) Resolution: Fixed S

[GitHub] [lucene-solr] murblanc commented on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

murblanc commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686129516 @sigram @noblepaul I have removed the `PropertyValue` concept. Now once `PropertyKeys` are fetched, the value is accessed directly on the key (no more returned map). This s

[jira] [Commented] (SOLR-14645) Make FileListEntityProcessor streaming to prevent OOM

[ https://issues.apache.org/jira/browse/SOLR-14645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189774#comment-17189774 ] Ishan Chattopadhyaya commented on SOLR-14645: - Thanks [~mbolis], this was mer

[GitHub] [lucene-solr] tflobbe opened a new pull request #1823: SOLR-14510: Remove deprecations added with BMW support

tflobbe opened a new pull request #1823: URL: https://github.com/apache/lucene-solr/pull/1823 With BMW support, we added a new method to Text response writers to include in the response if the numFound is exact or not. This PR is to remove the previously existing and deprecated methods and

[GitHub] [lucene-solr] vthacker commented on pull request #1816: LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation

vthacker commented on pull request #1816: URL: https://github.com/apache/lucene-solr/pull/1816#issuecomment-686220105 > Why is there this strange dependency? Listing it under plugins should be enough. Ah okay! Just getting starter with gradle so I'll be making some mistakes like tha

[GitHub] [lucene-solr] vthacker commented on pull request #1816: LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation

vthacker commented on pull request #1816: URL: https://github.com/apache/lucene-solr/pull/1816#issuecomment-686220411 Here is the complete list of warnings/errors that this tool gives us for lucene-core ``` ~/apache-work/lucene-solr (solr_core_errorprone) $ gradlew -p lucene/core/

[GitHub] [lucene-solr] vthacker commented on pull request #1816: LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation

vthacker commented on pull request #1816: URL: https://github.com/apache/lucene-solr/pull/1816#issuecomment-68663 This is the set of warnings/errors for `solr/core` ``` ~/apache-work/lucene-solr (solr_core_errorprone) $ gradlew -p solr/core/ compileJava > Task :solr:so

[jira] [Created] (SOLR-14825) Wrap up async issues and tests.

Mark Robert Miller created SOLR-14825: - Summary: Wrap up async issues and tests. Key: SOLR-14825 URL: https://issues.apache.org/jira/browse/SOLR-14825 Project: Solr Issue Type: Sub-task

[GitHub] [lucene-solr] TomMD commented on a change in pull request #1818: SOLR-14819 Trivial fix to inefficient iterator pattern

TomMD commented on a change in pull request #1818: URL: https://github.com/apache/lucene-solr/pull/1818#discussion_r482683688 ## File path: solr/solrj/src/java/org/apache/solr/common/util/JsonSchemaValidator.java ## @@ -48,13 +48,15 @@ public JsonSchemaValidator(String jsonStr

[jira] [Commented] (SOLR-14819) SOLR has linear log operations that could trivially be linear

[ https://issues.apache.org/jira/browse/SOLR-14819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189822#comment-17189822 ] Thomas DuBuisson commented on SOLR-14819: - [~broustant] yes there were other issu

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189847#comment-17189847 ] Dawid Weiss commented on LUCENE-9500: - bq. parameter off seems unused Oh, great ca

[GitHub] [lucene-solr] sigram commented on pull request #1816: LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation

sigram commented on pull request #1816: URL: https://github.com/apache/lucene-solr/pull/1816#issuecomment-686274891 While some warnings are disputable, most of these point to genuine errors or deficiencies - this looks very useful! -

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1789: LUCENE-9484: Allow sorting an index after the fact

s1monw commented on a change in pull request #1789: URL: https://github.com/apache/lucene-solr/pull/1789#discussion_r482740267 ## File path: lucene/core/src/java/org/apache/lucene/index/BinaryDocValuesWriter.java ## @@ -202,4 +203,63 @@ public BytesRef binaryValue() { r

[GitHub] [lucene-solr] dweiss commented on pull request #1816: LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation

dweiss commented on pull request #1816: URL: https://github.com/apache/lucene-solr/pull/1816#issuecomment-686292245 bq. While some warnings are disputable, most of these point to genuine errors or deficiencies - this looks very useful! Right. This is always my problem with static ana

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1816: LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation

dweiss commented on a change in pull request #1816: URL: https://github.com/apache/lucene-solr/pull/1816#discussion_r482745406 ## File path: gradle/validation/error-prone.gradle ## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

<    1   2