TomMD commented on a change in pull request #1818:
URL: https://github.com/apache/lucene-solr/pull/1818#discussion_r482245426
##########
File path:
solr/solrj/src/java/org/apache/solr/common/util/JsonSchemaValidator.java
##########
@@ -48,13 +48,15 @@ public JsonSchemaValidator(String jsonString) {
public JsonSchemaValidator(Map jsonSchema) {
this.validators = new LinkedList<>();
- for (Object fname : jsonSchema.keySet()) {
+ for (Object entry : jsonSchema.entrySet()) {
Review comment:
I've got to admit I'm a bit confused on this since `Map.Entry<>` is not
what one gets from `entrySet` of a `Map`:
```
> Task :solr:solrj:compileJava
/code/solr/solrj/src/java/org/apache/solr/common/util/JsonSchemaValidator.java:51:
error: incompatible types: Object ca
nnot be converted to Entry<?,?>
for (Map.Entry<?,?> entry : jsonSchema.entrySet()) {
```
Are you asking for us to change the function from:
```
public JsonSchemaValidator(Map jsonSchema) {
```
to
```
public JsonSchemaValidator(Map<?,?> jsonSchema) {
```
And propagate that API change to the callees, or did I miss the obvious
thing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
