[GitHub] [lucene-solr] s1monw commented on a change in pull request #1623: LUCENE-8962: Merge segments on getReader

2020-08-18 Thread GitBox
s1monw commented on a change in pull request #1623: URL: https://github.com/apache/lucene-solr/pull/1623#discussion_r471955980 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -607,6 +633,57 @@ DirectoryReader getReader(boolean applyAllDeletes,

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1623: LUCENE-8962: Merge segments on getReader

2020-08-18 Thread GitBox
s1monw commented on a change in pull request #1623: URL: https://github.com/apache/lucene-solr/pull/1623#discussion_r471957713 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -3335,49 +3416,60 @@ public void mergeFinished(boolean committed, boo

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1623: LUCENE-8962: Merge segments on getReader

2020-08-18 Thread GitBox
s1monw commented on a change in pull request #1623: URL: https://github.com/apache/lucene-solr/pull/1623#discussion_r471958847 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -545,18 +546,54 @@ DirectoryReader getReader(boolean applyAllDeletes,

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1623: LUCENE-8962: Merge segments on getReader

2020-08-18 Thread GitBox
s1monw commented on a change in pull request #1623: URL: https://github.com/apache/lucene-solr/pull/1623#discussion_r471960276 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -630,6 +694,64 @@ DirectoryReader getReader(boolean applyAllDeletes,

[GitHub] [lucene-solr] noblepaul opened a new pull request #1760: SOLR-14750: TestBulkSchemaConcurrent passes but schema plugins fail

2020-08-18 Thread GitBox
noblepaul opened a new pull request #1760: URL: https://github.com/apache/lucene-solr/pull/1760 I've isolated the changes that caused schema `TestBulkSchemaConcurrent` tests to fail This bug was introduced by [SOLR-14151](https://issues.apache.org/jira/browse/SOLR-14680) . So

[jira] [Reopened] (SOLR-14151) Make schema components load from packages

2020-08-18 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul reopened SOLR-14151: --- > Make schema components load from packages > - > >

[GitHub] [lucene-solr] dweiss merged pull request #1757: LUCENE-9465: 'beast' task from within gradle

2020-08-18 Thread GitBox
dweiss merged pull request #1757: URL: https://github.com/apache/lucene-solr/pull/1757 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (LUCENE-9465) Add functionality to do test re-runs (suite duplication, so-called 'beasting')

2020-08-18 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9465. - Fix Version/s: master (9.0) Resolution: Fixed > Add functionality to do test re-runs (sui

[jira] [Commented] (LUCENE-9465) Add functionality to do test re-runs (suite duplication, so-called 'beasting')

2020-08-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179422#comment-17179422 ] ASF subversion and git services commented on LUCENE-9465: - Commi

[jira] [Commented] (LUCENE-9465) Add functionality to do test re-runs (suite duplication, so-called 'beasting')

2020-08-18 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179423#comment-17179423 ] Dawid Weiss commented on LUCENE-9465: - I allowed myself to add it in since there's b

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1623: LUCENE-8962: Merge segments on getReader

2020-08-18 Thread GitBox
s1monw commented on a change in pull request #1623: URL: https://github.com/apache/lucene-solr/pull/1623#discussion_r471991665 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -607,6 +633,57 @@ DirectoryReader getReader(boolean applyAllDeletes,

[jira] [Created] (SOLR-14756) Sync of replicas are failing for two collection among 3

2020-08-18 Thread neha kumari (Jira)
neha kumari created SOLR-14756: -- Summary: Sync of replicas are failing for two collection among 3 Key: SOLR-14756 URL: https://issues.apache.org/jira/browse/SOLR-14756 Project: Solr Issue Type:

[GitHub] [lucene-solr] sigram commented on a change in pull request #1758: SOLR-14749: Provide a clean API for cluster-level event processing, Initial draft.

2020-08-18 Thread GitBox
sigram commented on a change in pull request #1758: URL: https://github.com/apache/lucene-solr/pull/1758#discussion_r472053144 ## File path: solr/core/src/java/org/apache/solr/cloud/events/NodeDownEvent.java ## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [lucene-solr] sigram commented on a change in pull request #1758: SOLR-14749: Provide a clean API for cluster-level event processing, Initial draft.

2020-08-18 Thread GitBox
sigram commented on a change in pull request #1758: URL: https://github.com/apache/lucene-solr/pull/1758#discussion_r472058053 ## File path: solr/core/src/java/org/apache/solr/cloud/events/ScheduledEvent.java ## @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [lucene-solr] markharwood commented on pull request #1708: LUCENE-9445 Add support for case insensitive regex searches in QueryParser

2020-08-18 Thread GitBox
markharwood commented on pull request #1708: URL: https://github.com/apache/lucene-solr/pull/1708#issuecomment-675386274 >I wonder if the parsing should be more strict and only matches if there is a separator or ends after the i ? @jimczi What is the behaviour for a non-match? Sho

[GitHub] [lucene-solr] sigram commented on a change in pull request #1737: SOLR-14615: Implement CPU Utilization Based Circuit Breaker

2020-08-18 Thread GitBox
sigram commented on a change in pull request #1737: URL: https://github.com/apache/lucene-solr/pull/1737#discussion_r472060120 ## File path: solr/core/src/java/org/apache/solr/core/SolrConfig.java ## @@ -229,9 +229,13 @@ private SolrConfig(SolrResourceLoader loader, String name

[GitHub] [lucene-solr] chatman commented on pull request #1744: SOLR-14731: Add SingleThreaded Annotation to Class

2020-08-18 Thread GitBox
chatman commented on pull request #1744: URL: https://github.com/apache/lucene-solr/pull/1744#issuecomment-675403326 Looks good. I'll merge this soon. Thanks @MarcusSorealheis. This is an automated message from the Apache Git

[jira] [Commented] (SOLR-14731) Make use of @SolrSingleThreaded Implementation

2020-08-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179543#comment-17179543 ] ASF subversion and git services commented on SOLR-14731: Commit 7

[jira] [Commented] (SOLR-14731) Make use of @SolrSingleThreaded Implementation

2020-08-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179544#comment-17179544 ] ASF subversion and git services commented on SOLR-14731: Commit d

[jira] [Updated] (SOLR-14731) Make use of @SolrSingleThreaded Implementation

2020-08-18 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya updated SOLR-14731: Fix Version/s: 8.7 > Make use of @SolrSingleThreaded Implementation >

[jira] [Resolved] (SOLR-14731) Make use of @SolrSingleThreaded Implementation

2020-08-18 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya resolved SOLR-14731. - Resolution: Fixed Thanks [~marcussorealheis]. As [~mdrob] said, Rome wasn't built

[jira] [Resolved] (SOLR-14753) More Consistent Thread Safety Annotations.

2020-08-18 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya resolved SOLR-14753. - Fix Version/s: 8.7 Resolution: Fixed I committed this as part of SOLR-1473

[GitHub] [lucene-solr] chatman commented on pull request #1755: SOLR-14753: Improve thread annotation name

2020-08-18 Thread GitBox
chatman commented on pull request #1755: URL: https://github.com/apache/lucene-solr/pull/1755#issuecomment-675411238 Thanks for the PR, Marcus. I committed this change as part of SOLR-14731. Can you please close both the PRs (as usual, I forgot to do it via commit message and my github cre

[GitHub] [lucene-solr] jimczi commented on pull request #1708: LUCENE-9445 Add support for case insensitive regex searches in QueryParser

2020-08-18 Thread GitBox
jimczi commented on pull request #1708: URL: https://github.com/apache/lucene-solr/pull/1708#issuecomment-675416033 > Should /regex/iterm throw an error or be interpreted as /regex/ and iterm? I'd prefer that we throw an error if any of the character attached to a regexp is not recog

[GitHub] [lucene-solr] markharwood commented on pull request #1708: LUCENE-9445 Add support for case insensitive regex searches in QueryParser

2020-08-18 Thread GitBox
markharwood commented on pull request #1708: URL: https://github.com/apache/lucene-solr/pull/1708#issuecomment-675420267 OK. @romseygeek suggested the BWC flag is called "allow_modifiers" and, if false, legacy behaviour is used ie there would be no errors for characters after trailing `/`

[GitHub] [lucene-solr] atris commented on a change in pull request #1737: SOLR-14615: Implement CPU Utilization Based Circuit Breaker

2020-08-18 Thread GitBox
atris commented on a change in pull request #1737: URL: https://github.com/apache/lucene-solr/pull/1737#discussion_r472104145 ## File path: solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java ## @@ -76,6 +79,10 @@ public boolean isTripped() {

[GitHub] [lucene-solr] mikemccand commented on pull request #1623: LUCENE-8962: Merge segments on getReader

2020-08-18 Thread GitBox
mikemccand commented on pull request #1623: URL: https://github.com/apache/lucene-solr/pull/1623#issuecomment-675458466 Beasting ran all night (1031 iterations) and uncovered this failure, which reproduces with this PR but not on mainline: ``` [mkdir] Created dir: /l/simon/luc

[GitHub] [lucene-solr] mikemccand commented on pull request #1623: LUCENE-8962: Merge segments on getReader

2020-08-18 Thread GitBox
mikemccand commented on pull request #1623: URL: https://github.com/apache/lucene-solr/pull/1623#issuecomment-675459732 Another failure that reproduces only on the PR: ``` [junit4:pickseed] Seed property 'tests.seed' already defined: CADC6D7945159855 [junit4] says jolly goo

[GitHub] [lucene-solr] mikemccand commented on pull request #1623: LUCENE-8962: Merge segments on getReader

2020-08-18 Thread GitBox
mikemccand commented on pull request #1623: URL: https://github.com/apache/lucene-solr/pull/1623#issuecomment-67545 Those were the only two failures found after 1033 test iterations! This is an automated message from the

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1623: LUCENE-8962: Merge segments on getReader

2020-08-18 Thread GitBox
mikemccand commented on a change in pull request #1623: URL: https://github.com/apache/lucene-solr/pull/1623#discussion_r472154682 ## File path: lucene/core/src/java/org/apache/lucene/index/ReaderPool.java ## @@ -404,7 +404,7 @@ private PendingDeletes newPendingDeletes(SegmentR

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1623: LUCENE-8962: Merge segments on getReader

2020-08-18 Thread GitBox
mikemccand commented on a change in pull request #1623: URL: https://github.com/apache/lucene-solr/pull/1623#discussion_r472162610 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -607,6 +633,57 @@ DirectoryReader getReader(boolean applyAllDelet

[jira] [Resolved] (LUCENE-9468) "./gradlew -p lucene test" leaks lucene/core/build/tmp/test/jar_extract_XXXX files

2020-08-18 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-9468. Resolution: Not A Bug > "./gradlew -p lucene test" leaks lucene/core/build/tmp/tes

[jira] [Commented] (LUCENE-9468) "./gradlew -p lucene test" leaks lucene/core/build/tmp/test/jar_extract_XXXX files

2020-08-18 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179598#comment-17179598 ] Michael McCandless commented on LUCENE-9468: OK, I did not realize this is a

[jira] [Commented] (LUCENE-9468) "./gradlew -p lucene test" leaks lucene/core/build/tmp/test/jar_extract_XXXX files

2020-08-18 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179624#comment-17179624 ] Dawid Weiss commented on LUCENE-9468: - This 'tmp' folder under build holds all sorts

[jira] [Commented] (LUCENE-9468) "./gradlew -p lucene test" leaks lucene/core/build/tmp/test/jar_extract_XXXX files

2020-08-18 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179627#comment-17179627 ] Dawid Weiss commented on LUCENE-9468: - This is the issue: https://github.com/gradle/

[jira] [Updated] (SOLR-14695) Support loading of unsigned jars

2020-08-18 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-14695: -- Description: Solr distribution can keep a set of sha512 hashes of already trusted jars. This helps loa

[jira] [Commented] (SOLR-14662) Elevation with distributed search causes NPE

2020-08-18 Thread Thomas Schmiereck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179636#comment-17179636 ] Thomas Schmiereck commented on SOLR-14662: -- [~erickerickson] Thanks for the hint

[jira] [Commented] (SOLR-14636) Provide a reference implementation for SolrCloud that is stable and fast.

2020-08-18 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179638#comment-17179638 ] Mark Robert Miller commented on SOLR-14636: --- And you know, Robert and I never w

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1758: SOLR-14749: Provide a clean API for cluster-level event processing, Initial draft.

2020-08-18 Thread GitBox
murblanc commented on a change in pull request #1758: URL: https://github.com/apache/lucene-solr/pull/1758#discussion_r472239057 ## File path: solr/core/src/java/org/apache/solr/cloud/events/ScheduledEvent.java ## @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache Software Foundat

[jira] [Commented] (LUCENE-9468) "./gradlew -p lucene test" leaks lucene/core/build/tmp/test/jar_extract_XXXX files

2020-08-18 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179659#comment-17179659 ] Michael McCandless commented on LUCENE-9468: Thanks [~dweiss] ... I had ~10K

[jira] [Commented] (SOLR-14636) Provide a reference implementation for SolrCloud that is stable and fast.

2020-08-18 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179665#comment-17179665 ] Mark Robert Miller commented on SOLR-14636: --- A smart guy with similar experienc

[jira] [Commented] (LUCENE-9468) "./gradlew -p lucene test" leaks lucene/core/build/tmp/test/jar_extract_XXXX files

2020-08-18 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179676#comment-17179676 ] Dawid Weiss commented on LUCENE-9468: - LUCENE-9465 is already implemented, Mike. I

[GitHub] [lucene-solr] chatman commented on a change in pull request #1758: SOLR-14749: Provide a clean API for cluster-level event processing, Initial draft.

2020-08-18 Thread GitBox
chatman commented on a change in pull request #1758: URL: https://github.com/apache/lucene-solr/pull/1758#discussion_r472263584 ## File path: solr/core/src/java/org/apache/solr/cluster/events/ClusterSingleton.java ## @@ -0,0 +1,14 @@ +package org.apache.solr.cluster.events; +

[GitHub] [lucene-solr] chatman commented on a change in pull request #1758: SOLR-14749: Provide a clean API for cluster-level event processing, Initial draft.

2020-08-18 Thread GitBox
chatman commented on a change in pull request #1758: URL: https://github.com/apache/lucene-solr/pull/1758#discussion_r472269946 ## File path: solr/core/src/java/org/apache/solr/cloud/events/ScheduledEvent.java ## @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [lucene-solr] chatman commented on a change in pull request #1758: SOLR-14749: Provide a clean API for cluster-level event processing, Initial draft.

2020-08-18 Thread GitBox
chatman commented on a change in pull request #1758: URL: https://github.com/apache/lucene-solr/pull/1758#discussion_r472270151 ## File path: solr/core/src/java/org/apache/solr/cluster/events/ScheduledEvent.java ## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software Founda

[jira] [Commented] (SOLR-14021) Deprecate HDFS support from 8x

2020-08-18 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179693#comment-17179693 ] Ishan Chattopadhyaya commented on SOLR-14021: - The migration of HDFS into a p

[jira] [Commented] (SOLR-14660) Migrating HDFS into a package

2020-08-18 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179694#comment-17179694 ] Ishan Chattopadhyaya commented on SOLR-14660: - [~warper], let us know once yo

[jira] [Commented] (SOLR-14413) allow timeAllowed and cursorMark parameters

2020-08-18 Thread Bram Van Dam (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179702#comment-17179702 ] Bram Van Dam commented on SOLR-14413: - [~epugh] I created a little test case to demon

[jira] [Comment Edited] (SOLR-14413) allow timeAllowed and cursorMark parameters

2020-08-18 Thread Bram Van Dam (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179702#comment-17179702 ] Bram Van Dam edited comment on SOLR-14413 at 8/18/20, 3:31 PM:

[jira] [Updated] (SOLR-14413) allow timeAllowed and cursorMark parameters

2020-08-18 Thread Bram Van Dam (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bram Van Dam updated SOLR-14413: Attachment: SOLR-14413-bram.patch > allow timeAllowed and cursorMark parameters > -

[GitHub] [lucene-solr] s1monw commented on pull request #1623: LUCENE-8962: Merge segments on getReader

2020-08-18 Thread GitBox
s1monw commented on pull request #1623: URL: https://github.com/apache/lucene-solr/pull/1623#issuecomment-675571884 @mikemccand I pushed a fix for the failures. I will add a dedicated test to make sure it's covered too This

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1623: LUCENE-8962: Merge segments on getReader

2020-08-18 Thread GitBox
s1monw commented on a change in pull request #1623: URL: https://github.com/apache/lucene-solr/pull/1623#discussion_r472314458 ## File path: lucene/core/src/java/org/apache/lucene/index/ReaderPool.java ## @@ -404,7 +404,7 @@ private PendingDeletes newPendingDeletes(SegmentReade

[jira] [Commented] (LUCENE-9468) "./gradlew -p lucene test" leaks lucene/core/build/tmp/test/jar_extract_XXXX files

2020-08-18 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179723#comment-17179723 ] Michael McCandless commented on LUCENE-9468: {quote}I don't work (or advocat

[jira] [Commented] (LUCENE-9027) SIMD-based decoding of postings lists

2020-08-18 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179726#comment-17179726 ] Michael McCandless commented on LUCENE-9027: {quote}_Shouldn't the other pos

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1623: LUCENE-8962: Merge segments on getReader

2020-08-18 Thread GitBox
dnhatn commented on a change in pull request #1623: URL: https://github.com/apache/lucene-solr/pull/1623#discussion_r472332671 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -3179,9 +3317,9 @@ private long prepareCommitInternal() throws IOExce

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1623: LUCENE-8962: Merge segments on getReader

2020-08-18 Thread GitBox
s1monw commented on a change in pull request #1623: URL: https://github.com/apache/lucene-solr/pull/1623#discussion_r472336456 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -3179,9 +3317,9 @@ private long prepareCommitInternal() throws IOExce

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1623: LUCENE-8962: Merge segments on getReader

2020-08-18 Thread GitBox
s1monw commented on a change in pull request #1623: URL: https://github.com/apache/lucene-solr/pull/1623#discussion_r472337839 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -545,18 +546,54 @@ DirectoryReader getReader(boolean applyAllDeletes,

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1758: SOLR-14749: Provide a clean API for cluster-level event processing, Initial draft.

2020-08-18 Thread GitBox
murblanc commented on a change in pull request #1758: URL: https://github.com/apache/lucene-solr/pull/1758#discussion_r472343024 ## File path: solr/core/src/java/org/apache/solr/cluster/events/ClusterSingleton.java ## @@ -0,0 +1,14 @@ +package org.apache.solr.cluster.events; +

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1758: SOLR-14749: Provide a clean API for cluster-level event processing, Initial draft.

2020-08-18 Thread GitBox
murblanc commented on a change in pull request #1758: URL: https://github.com/apache/lucene-solr/pull/1758#discussion_r472343024 ## File path: solr/core/src/java/org/apache/solr/cluster/events/ClusterSingleton.java ## @@ -0,0 +1,14 @@ +package org.apache.solr.cluster.events; +

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1758: SOLR-14749: Provide a clean API for cluster-level event processing, Initial draft.

2020-08-18 Thread GitBox
murblanc commented on a change in pull request #1758: URL: https://github.com/apache/lucene-solr/pull/1758#discussion_r472346084 ## File path: solr/core/src/java/org/apache/solr/cluster/events/ScheduledEvent.java ## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1758: SOLR-14749: Provide a clean API for cluster-level event processing, Initial draft.

2020-08-18 Thread GitBox
murblanc commented on a change in pull request #1758: URL: https://github.com/apache/lucene-solr/pull/1758#discussion_r472343024 ## File path: solr/core/src/java/org/apache/solr/cluster/events/ClusterSingleton.java ## @@ -0,0 +1,14 @@ +package org.apache.solr.cluster.events; +

[jira] [Commented] (LUCENE-4312) Index format to store position length per position

2020-08-18 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179959#comment-17179959 ] Michael McCandless commented on LUCENE-4312: [~mgibney] I think we should tr

[GitHub] [lucene-solr] sigram commented on a change in pull request #1758: SOLR-14749: Provide a clean API for cluster-level event processing, Initial draft.

2020-08-18 Thread GitBox
sigram commented on a change in pull request #1758: URL: https://github.com/apache/lucene-solr/pull/1758#discussion_r472435099 ## File path: solr/core/src/java/org/apache/solr/cloud/events/ScheduledEvent.java ## @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [lucene-solr] sigram commented on a change in pull request #1758: SOLR-14749: Provide a clean API for cluster-level event processing, Initial draft.

2020-08-18 Thread GitBox
sigram commented on a change in pull request #1758: URL: https://github.com/apache/lucene-solr/pull/1758#discussion_r472436918 ## File path: solr/core/src/java/org/apache/solr/cluster/events/ScheduledEvent.java ## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software Foundat

[jira] [Updated] (SOLR-14413) allow timeAllowed and cursorMark parameters

2020-08-18 Thread John Gallagher (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Gallagher updated SOLR-14413: -- Attachment: image-2020-08-18-16-56-41-736.png > allow timeAllowed and cursorMark parameters > -

[jira] [Updated] (SOLR-14413) allow timeAllowed and cursorMark parameters

2020-08-18 Thread John Gallagher (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Gallagher updated SOLR-14413: -- Attachment: image-2020-08-18-16-56-03-425.png > allow timeAllowed and cursorMark parameters > -

[jira] [Updated] (SOLR-14413) allow timeAllowed and cursorMark parameters

2020-08-18 Thread John Gallagher (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Gallagher updated SOLR-14413: -- Attachment: image-2020-08-18-16-56-03-355.png > allow timeAllowed and cursorMark parameters > -

[jira] [Updated] (SOLR-14413) allow timeAllowed and cursorMark parameters

2020-08-18 Thread John Gallagher (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Gallagher updated SOLR-14413: -- Attachment: (was: image-2020-08-18-16-56-03-355.png) > allow timeAllowed and cursorMark par

[jira] [Updated] (SOLR-14413) allow timeAllowed and cursorMark parameters

2020-08-18 Thread John Gallagher (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Gallagher updated SOLR-14413: -- Attachment: (was: image-2020-08-18-16-56-03-425.png) > allow timeAllowed and cursorMark par

[jira] [Updated] (SOLR-14413) allow timeAllowed and cursorMark parameters

2020-08-18 Thread John Gallagher (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Gallagher updated SOLR-14413: -- Attachment: image-2020-08-18-16-56-59-178.png > allow timeAllowed and cursorMark parameters > -

[jira] [Updated] (SOLR-14413) allow timeAllowed and cursorMark parameters

2020-08-18 Thread John Gallagher (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Gallagher updated SOLR-14413: -- Attachment: SOLR-14413-jg-update1.patch > allow timeAllowed and cursorMark parameters > ---

[jira] [Commented] (LUCENE-8776) Start offset going backwards has a legitimate purpose

2020-08-18 Thread Roman (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180098#comment-17180098 ] Roman commented on LUCENE-8776: --- Michael, I appreciate your thinking about the issue - it'

[jira] [Commented] (SOLR-14413) allow timeAllowed and cursorMark parameters

2020-08-18 Thread John Gallagher (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180102#comment-17180102 ] John Gallagher commented on SOLR-14413: --- Hi folks, sorry I stepped away from this f

[GitHub] [lucene-solr] noblepaul merged pull request #1760: SOLR-14750: TestBulkSchemaConcurrent passes but schema plugins fail

2020-08-18 Thread GitBox
noblepaul merged pull request #1760: URL: https://github.com/apache/lucene-solr/pull/1760 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (SOLR-14750) Harden TestBulkSchemaConcurrent

2020-08-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180190#comment-17180190 ] ASF subversion and git services commented on SOLR-14750: Commit 8

[jira] [Commented] (SOLR-14750) Harden TestBulkSchemaConcurrent

2020-08-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180191#comment-17180191 ] ASF subversion and git services commented on SOLR-14750: Commit 0

[jira] [Updated] (SOLR-14660) Migrating HDFS into a package

2020-08-18 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-14660: -- Labels: packagemanager (was: ) > Migrating HDFS into a package > - > >

[jira] [Updated] (SOLR-14660) Migrating HDFS into a package

2020-08-18 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-14660: -- Labels: package packagemanager (was: packagemanager) > Migrating HDFS into a package > ---

[jira] [Commented] (LUCENE-8776) Start offset going backwards has a legitimate purpose

2020-08-18 Thread Roman (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180202#comment-17180202 ] Roman commented on LUCENE-8776: --- [~mgibney] now it's my turn to apologize, all the time I