sigram commented on a change in pull request #1758: URL: https://github.com/apache/lucene-solr/pull/1758#discussion_r472058053
########## File path: solr/core/src/java/org/apache/solr/cloud/events/ScheduledEvent.java ########## @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.cloud.events; + +/** + * + */ +public interface ScheduledEvent extends ClusterEvent { + String getScheduleName(); + Object getScheduleParam(String key); Review comment: Thinking more about it, we should use a strongly-typed Schedule. Scheduled event is something that Solr generates on a predefined schedule ;) It's basically a general-purpose scheduler that is available via this API. There's a need for some periodic maintenance tasks, and currently it was implemented as a part of the autoscaling triggers (ScheduledTrigger, which in turn invoked eg. inactive shard cleanup and collection repair tasks). I'm open to other suggestions - we could make it a separate API, but modelling it as a cluster event has benefits too (uniform way to register for and to process events, and it avoids adding yet another API). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
