mocobeta opened a new pull request #1695:
URL: https://github.com/apache/lucene-solr/pull/1695
This includes two changes in documentation task.
1. Fix Javadoc offline link base url to make snapshot build pass
`checkBrokenLinks`.
2. Explicitly disable cross-project link for `:solr:
[
https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165191#comment-17165191
]
Tomoko Uchida commented on LUCENE-9321:
---
I've opened a PR
([https://github.com/ap
[
https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165191#comment-17165191
]
Tomoko Uchida edited comment on LUCENE-9321 at 7/26/20, 9:19 AM:
-
[
https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165199#comment-17165199
]
Tomoko Uchida commented on LUCENE-9433:
---
[LUCENE-9441] is a bit sticky. The javado
[
https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165202#comment-17165202
]
Erick Erickson commented on LUCENE-9433:
[~tomoko] Sure. I anticipate a few days
murblanc commented on pull request #1694:
URL: https://github.com/apache/lucene-solr/pull/1694#issuecomment-663994405
Can we start simple by defining the external interface without the required
changes to internal classes first? Will make a smaller PR easier to discuss.
--
murblanc commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-663997462
I agree about the naming, will change, will try to make these interfaces
seem more like a generic thing for SolrCloud rather than something that’s
Autoscaling specific.
[
https://issues.apache.org/jira/browse/SOLR-7400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson resolved SOLR-7400.
--
Resolution: Invalid
This is both very old and almost certainly a configuration issue, dataDirs a
murblanc commented on pull request #1694:
URL: https://github.com/apache/lucene-solr/pull/1694#issuecomment-663999287
I also feel this PR has a lot of overlap with the one I started to define an
API for Autoscaling plugins (https://github.com/apache/lucene-solr/pull/1684).
Unless we
[
https://issues.apache.org/jira/browse/SOLR-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165245#comment-17165245
]
Erick Erickson commented on SOLR-12847:
---
If we put support back in for maxShardsPer
Hronom commented on a change in pull request #1419:
URL: https://github.com/apache/lucene-solr/pull/1419#discussion_r460552820
##
File path:
lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/vectors/FloatVectorFieldSource.java
##
@@ -0,0 +1,213 @@
+/*
+ *
gus-asf commented on pull request #1694:
URL: https://github.com/apache/lucene-solr/pull/1694#issuecomment-664018065
These interfaces look like a good way to begin. Thoughts: This is an
excellent point at which to consider and then stick to a preferred set of
terminology. My favorites are:
[
https://issues.apache.org/jira/browse/SOLR-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165300#comment-17165300
]
Mark Robert Miller commented on SOLR-14636:
---
The promised land approaches. The
gus-asf edited a comment on pull request #1694:
URL: https://github.com/apache/lucene-solr/pull/1694#issuecomment-664018065
These interfaces look like a good way to begin. Thoughts: This is an
excellent point at which to consider and then stick to a preferred set of
terminology. My favorit
gus-asf edited a comment on pull request #1694:
URL: https://github.com/apache/lucene-solr/pull/1694#issuecomment-664018065
These interfaces look like a good way to begin. Thoughts: This is an
excellent point at which to consider and then stick to a preferred set of
terminology. My favorit
gus-asf commented on a change in pull request #1694:
URL: https://github.com/apache/lucene-solr/pull/1694#discussion_r460560248
##
File path: solr/solrj/src/java/org/apache/solr/common/cloud/sdk/SolrCluster.java
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Founda
gus-asf edited a comment on pull request #1694:
URL: https://github.com/apache/lucene-solr/pull/1694#issuecomment-664018065
These interfaces look like a good way to begin. Thoughts: This is an
excellent point at which to consider and then stick to a preferred set of
terminology. My favorit
gus-asf edited a comment on pull request #1694:
URL: https://github.com/apache/lucene-solr/pull/1694#issuecomment-664018065
These interfaces look like a good way to begin. Thoughts: This is an
excellent point at which to consider and then stick to a preferred set of
terminology. My favorit
[
https://issues.apache.org/jira/browse/SOLR-13169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gus Heck reassigned SOLR-13169:
---
Assignee: Gus Heck
> Move Replica Docs need improvement (V1 and V2 introspect)
> ---
chatman commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-664041481
> I can participate in that other PR (already did) but it duplicates
seriously the effort I’ve started here. Maybe we carry the two approaches in
parallel and then we’ll be
chatman commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-664042985
Regarding the work orders, can we decouple them from the collection API
commands that are used? I see CreateReplicaWorkOrder and
NewCollectionWorkOrder. AFAICT, the former n
murblanc commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-664046112
There’s no direct mapping between work orders and collection API. I consider
work orders the basic building blocs from which collection API actions can be
built. Creating a
murblanc edited a comment on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-664046112
There’s no direct mapping between work orders and collection API. I consider
work orders the basic building blocs from which collection API actions can be
built. Cre
chatman commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-664046970
> There’s no direct mapping between work orders and collection API. I
consider work orders the basic building blocs from which collection API actions
can be built. Creating
chatman commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-664047131
What does "gumi" mean?
This is an automated message from the Apache Git Service.
To respond to the message,
murblanc commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-664048647
The work orders are the actions decided by the plugin to satisfy a request
or requests sent by a Collection API command implementation.
The chain is: Collection API -> co
murblanc commented on pull request #1694:
URL: https://github.com/apache/lucene-solr/pull/1694#issuecomment-66404
Snitches have a target (at least node or replica, but one could imagine
Cluster, collection or shard if such snitches do not already exist).
Would be helpful for all thes
murblanc edited a comment on pull request #1694:
URL: https://github.com/apache/lucene-solr/pull/1694#issuecomment-66404
Snitches have a target (at least node or replica, but one could imagine
Cluster, collection or shard if such snitches do not already exist).
Would be helpful for a
chatman commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-664051353
> Gumi means “elastic” in Hebrew. I’ll change that package name to... what?
I see that @noblepaul has used the name "o.a.s.cloud.sdk" in the other PR
for SolrCloud specifi
chatman edited a comment on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-664051353
> Gumi means “elastic” in Hebrew. I’ll change that package name to... what?
I see that @noblepaul has used the name "o.a.s.cloud.sdk" in the other PR
for SolrCl
chatman edited a comment on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-664051353
> Gumi means “elastic” in Hebrew. I’ll change that package name to... what?
I see that @noblepaul has used the name "o.a.s.common.cloud.sdk" in the
other PR for
chatman commented on pull request #1694:
URL: https://github.com/apache/lucene-solr/pull/1694#issuecomment-664052755
As I suggested in the other PR on autoscaling, I feel we should change the
package name:
https://github.com/apache/lucene-solr/pull/1684#issuecomment-664051353
Also
[
https://issues.apache.org/jira/browse/SOLR-11868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165364#comment-17165364
]
ASF subversion and git services commented on SOLR-11868:
Commit 6
[
https://issues.apache.org/jira/browse/SOLR-11868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson resolved SOLR-11868.
---
Fix Version/s: 8.7
Resolution: Fixed
> Deprecate CloudSolrClient.setIdField, use infor
[
https://issues.apache.org/jira/browse/SOLR-11868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165365#comment-17165365
]
ASF subversion and git services commented on SOLR-11868:
Commit f
gus-asf commented on pull request #1694:
URL: https://github.com/apache/lucene-solr/pull/1694#issuecomment-664078634
While marking things internal and external is good, a stronger possibility
to code more defensively and make "new plugins" get instantiated/injected with
implementations of
gus-asf edited a comment on pull request #1694:
URL: https://github.com/apache/lucene-solr/pull/1694#issuecomment-664078634
While marking things internal and external is good, a stronger possibility
is to code more defensively and make "new plugins" get instantiated/injected
with implement
[
https://issues.apache.org/jira/browse/SOLR-11868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165394#comment-17165394
]
David Smiley commented on SOLR-11868:
-
Maybe also file an issue to make "id" the only
noblepaul commented on a change in pull request #1694:
URL: https://github.com/apache/lucene-solr/pull/1694#discussion_r460622100
##
File path:
solr/solrj/src/java/org/apache/solr/common/util/LinkedSimpleHashMap.java
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software
noblepaul commented on a change in pull request #1694:
URL: https://github.com/apache/lucene-solr/pull/1694#discussion_r460622520
##
File path: solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java
##
@@ -38,7 +43,7 @@
* {@link ZkStateReader#getClusterState()}.
chatman commented on a change in pull request #1694:
URL: https://github.com/apache/lucene-solr/pull/1694#discussion_r460623863
##
File path: solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java
##
@@ -38,7 +43,7 @@
* {@link ZkStateReader#getClusterState()}.
*
noblepaul commented on a change in pull request #1694:
URL: https://github.com/apache/lucene-solr/pull/1694#discussion_r460624050
##
File path: solr/solrj/src/java/org/apache/solr/common/cloud/sdk/SolrNode.java
##
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundat
noblepaul commented on pull request #1694:
URL: https://github.com/apache/lucene-solr/pull/1694#issuecomment-664094746
>I also feel this PR has a lot of overlap with the one I started to define
an API for Autoscaling plugins #1684
Yes, totally.That ticket is trying to do something m
noblepaul commented on pull request #1694:
URL: https://github.com/apache/lucene-solr/pull/1694#issuecomment-664095650
>These interfaces look like a good way to begin. Thoughts: This is an
excellent point at which to consider and then stick to a preferred set of
terminology. My favorites a
noblepaul commented on a change in pull request #1694:
URL: https://github.com/apache/lucene-solr/pull/1694#discussion_r460626596
##
File path: solr/solrj/src/java/org/apache/solr/common/cloud/sdk/SolrCluster.java
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foun
noblepaul commented on a change in pull request #1694:
URL: https://github.com/apache/lucene-solr/pull/1694#discussion_r460627654
##
File path: solr/solrj/src/java/org/apache/solr/common/cloud/sdk/SolrCluster.java
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foun
noblepaul commented on a change in pull request #1694:
URL: https://github.com/apache/lucene-solr/pull/1694#discussion_r460627824
##
File path:
solr/solrj/src/java/org/apache/solr/common/cloud/sdk/SolrCollection.java
##
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software
noblepaul commented on pull request #1694:
URL: https://github.com/apache/lucene-solr/pull/1694#issuecomment-664094145
> Can we start simple by defining the external interface without the
required changes to internal classes first? Will make a smaller PR easier to
discuss.
Feel free
Marcus Eagan created SOLR-14681:
---
Summary: Delete Jar with Command
Key: SOLR-14681
URL: https://issues.apache.org/jira/browse/SOLR-14681
Project: Solr
Issue Type: Improvement
Security Lev
[
https://issues.apache.org/jira/browse/SOLR-14681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165410#comment-17165410
]
Marcus Eagan commented on SOLR-14681:
-
[SOLR-14604 |https://issues.apache.org/jira/br
[
https://issues.apache.org/jira/browse/SOLR-14681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165427#comment-17165427
]
Vantagepointx commented on SOLR-14681:
--
Hi, Very informative post and really appreci
gus-asf commented on pull request #1694:
URL: https://github.com/apache/lucene-solr/pull/1694#issuecomment-664125851
> > These interfaces look like a good way to begin. Thoughts: This is an
excellent point at which to consider and then stick to a preferred set of
terminology. My favorites
noblepaul edited a comment on pull request #1694:
URL: https://github.com/apache/lucene-solr/pull/1694#issuecomment-664095650
>These interfaces look like a good way to begin. Thoughts: This is an
excellent point at which to consider and then stick to a preferred set of
terminology. My favo
atris commented on a change in pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r460677980
##
File path: solr/core/src/java/org/apache/solr/servlet/RequestRateLimiter.java
##
@@ -0,0 +1,199 @@
+/*
+ * Licensed to the Apache Software Foundation
atris commented on a change in pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r460678533
##
File path: solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java
##
@@ -331,6 +338,10 @@ public void close() {
metricManager
noblepaul commented on a change in pull request #1694:
URL: https://github.com/apache/lucene-solr/pull/1694#discussion_r460627654
##
File path: solr/solrj/src/java/org/apache/solr/common/cloud/sdk/SolrCluster.java
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foun
56 matches
Mail list logo
