s1monw edited a comment on pull request #1552:
URL: https://github.com/apache/lucene-solr/pull/1552#issuecomment-643486962
@mikemccand thanks for replying to all these comments. I do understand that
this change has an impact and I agree we should add this functionality. I just
disagree wit
s1monw commented on a change in pull request #1552:
URL: https://github.com/apache/lucene-solr/pull/1552#discussion_r439647024
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##
@@ -3228,15 +3268,38 @@ private long prepareCommitInternal() throws IOEx
s1monw commented on pull request #1552:
URL: https://github.com/apache/lucene-solr/pull/1552#issuecomment-643599140
> > @mikemccand thanks for replying to all these comments. I do understand
that this change has an impact and I agree we should add this functionality. I
just disagree with t
janhoy commented on a change in pull request #1572:
URL: https://github.com/apache/lucene-solr/pull/1572#discussion_r439730789
##
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##
@@ -1259,6 +1277,20 @@ public SolrCore create(String coreName, Path
instan
s1monw opened a new pull request #1576:
URL: https://github.com/apache/lucene-solr/pull/1576
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
Please provide a short description of the approach t
s1monw commented on pull request #1576:
URL: https://github.com/apache/lucene-solr/pull/1576#issuecomment-643609384
see #1552 for reference
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134776#comment-17134776
]
Erick Erickson commented on SOLR-12823:
---
Well, if you'd ever like to apply that kno
[
https://issues.apache.org/jira/browse/SOLR-14567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated SOLR-14567:
--
Summary: Fix or suppress up remaining warnings in solrj (was: Clean up
remaining warnings in s
Erick Erickson created SOLR-14567:
-
Summary: Clean up remaining warnings in solrj
Key: SOLR-14567
URL: https://issues.apache.org/jira/browse/SOLR-14567
Project: Solr
Issue Type: Sub-task
johtani opened a new pull request #1577:
URL: https://github.com/apache/lucene-solr/pull/1577
# Description
Check and omit token that has all punctuation characters when discard
punctuation flag is true.
Currently, JapaneseTokenizer discards token that has punctuation at first
ch
[
https://issues.apache.org/jira/browse/LUCENE-9390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134827#comment-17134827
]
Jun Ohtani commented on LUCENE-9390:
I've made a pull request.
https://github.com/
[
https://issues.apache.org/jira/browse/SOLR-14564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134829#comment-17134829
]
ASF subversion and git services commented on SOLR-14564:
Commit a
[
https://issues.apache.org/jira/browse/SOLR-14564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134830#comment-17134830
]
ASF subversion and git services commented on SOLR-14564:
Commit 6
[
https://issues.apache.org/jira/browse/SOLR-14564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson resolved SOLR-14564.
---
Fix Version/s: 8.6
Resolution: Fixed
They said it couldn't be done! On to the last two
[
https://issues.apache.org/jira/browse/SOLR-14417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gus Heck reopened SOLR-14417:
-
> Gradle build sometimes fails RE BlockPoolSlice
> --
>
>
[
https://issues.apache.org/jira/browse/SOLR-14417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134845#comment-17134845
]
Gus Heck commented on SOLR-14417:
-
I just hit this when running a test via Intellij (whic
[
https://issues.apache.org/jira/browse/SOLR-14567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated SOLR-14567:
--
Summary: Fix or suppress remaining warnings in solrj (was: Fix or suppress
up remaining warnin
Gus Heck created SOLR-14568:
---
Summary: org.apache.solr.cloud.MoveReplicaCmd#moveHdfsReplica uses
hard coded timeout
Key: SOLR-14568
URL: https://issues.apache.org/jira/browse/SOLR-14568
Project: Solr
msokolov commented on pull request #1351:
URL: https://github.com/apache/lucene-solr/pull/1351#issuecomment-643654018
This is so close! just needs precommit fix I think?
This is an automated message from the Apache Git Servic
mikemccand commented on a change in pull request #1573:
URL: https://github.com/apache/lucene-solr/pull/1573#discussion_r439751347
##
File path:
lucene/core/src/java/org/apache/lucene/index/FreqProxTermsWriterPerField.java
##
@@ -207,8 +202,6 @@ public void newPostingsArray()
[
https://issues.apache.org/jira/browse/SOLR-13169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134936#comment-17134936
]
ASF subversion and git services commented on SOLR-13169:
Commit b
[
https://issues.apache.org/jira/browse/SOLR-13169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gus Heck updated SOLR-13169:
Attachment: SOLR-13169.patch
> Move Replica Docs need improvement (V1 and V2 introspect)
>
[
https://issues.apache.org/jira/browse/SOLR-13169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134939#comment-17134939
]
Gus Heck commented on SOLR-13169:
-
Corrections from another read through, and documentati
[
https://issues.apache.org/jira/browse/SOLR-13169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134945#comment-17134945
]
ASF subversion and git services commented on SOLR-13169:
Commit 3
janhoy commented on a change in pull request #1572:
URL: https://github.com/apache/lucene-solr/pull/1572#discussion_r439772139
##
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##
@@ -1259,6 +1277,20 @@ public SolrCore create(String coreName, Path
instan
janhoy commented on a change in pull request #1572:
URL: https://github.com/apache/lucene-solr/pull/1572#discussion_r439772292
##
File path: solr/core/src/java/org/apache/solr/core/SolrPaths.java
##
@@ -128,4 +130,33 @@ private static void logOnceInfo(String key, String msg) {
dsmiley commented on pull request #1574:
URL: https://github.com/apache/lucene-solr/pull/1574#issuecomment-643716917
+1 clever and useful
This is an automated message from the Apache Git Service.
To respond to the message, pl
27 matches
Mail list logo
