Gus Heck created SOLR-14568:
-------------------------------

             Summary: org.apache.solr.cloud.MoveReplicaCmd#moveHdfsReplica uses 
hard coded timeout
                 Key: SOLR-14568
                 URL: https://issues.apache.org/jira/browse/SOLR-14568
             Project: Solr
          Issue Type: Improvement
      Security Level: Public (Default Security Level. Issues are Public)
          Components: SolrCloud
    Affects Versions: master (9.0)
            Reporter: Gus Heck


org.apache.solr.cloud.MoveReplicaCmd#moveHdfsReplica gained a hardcoded timeout 
in SOLR-11045 but there is no clear reason discussed in that ticket and no 
comment in the code to indicate why it is ignoring the value of the timeout 
parameter already passed into that method. 

This should be clarified in code and documented ([~caomanhdat]?) or the timeout 
parameter should be supported. It sure seems like we should support the api 
parameter but from the pattern of commits this looks potentially intentional 
and has survived several revisions, so I hesitate to  just change it without 
input/confirmation.  If this can be clarified soon, I'll document the result it 
in SOLR-131699, otherwise I'll just document the state as it is, and the docs 
can be updated if there are changes resulting from this ticket.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to