[
https://issues.apache.org/jira/browse/LUCENE-9397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133028#comment-17133028
]
Bruno Roustant commented on LUCENE-9397:
Currently we use the encoder interface
[
https://issues.apache.org/jira/browse/SOLR-14557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Khludnev updated SOLR-14557:
Summary: eDisMax parser switch + braces regression (was: eDisMax
(regression))
> eDisMax
sigram opened a new pull request #1568:
URL: https://github.com/apache/lucene-solr/pull/1568
Details in Jira.
Initial changes here implement the "double buffering" approach to increase
the throughput - an additional thread is created to fill in a buffer while the
main thread writes
[
https://issues.apache.org/jira/browse/SOLR-14541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133111#comment-17133111
]
Ilan Ginzburg commented on SOLR-14541:
--
The stack trace you posted [~erickerickson]
[
https://issues.apache.org/jira/browse/SOLR-14442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Khludnev resolved SOLR-14442.
-
Fix Version/s: 8.6
Resolution: Fixed
> bin/solr to attempt jstack before killing h
[
https://issues.apache.org/jira/browse/SOLR-14541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133187#comment-17133187
]
Erick Erickson commented on SOLR-14541:
---
[~murblanc] Thanks. As you can tell, I bar
jpountz opened a new pull request #1569:
URL: https://github.com/apache/lucene-solr/pull/1569
Opening a reader and then calling checkIntegrity must throw a
`CorruptIndexException` or an `IndexFormatToo(Old|New)Exception`.
Th
[
https://issues.apache.org/jira/browse/LUCENE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133199#comment-17133199
]
Adrien Grand commented on LUCENE-9356:
--
Thanks to LUCENE-7822 and LUCENE-9359, Luce
Erick Erickson created SOLR-14559:
-
Summary: Fix or suppress warnings in
solr/core/src/java/org/apache/solr/util, response, cloud, security, schema, api
Key: SOLR-14559
URL: https://issues.apache.org/jira/browse/S
msokolov commented on a change in pull request #1569:
URL: https://github.com/apache/lucene-solr/pull/1569#discussion_r438751988
##
File path:
lucene/core/src/test/org/apache/lucene/index/TestAllFilesDetectBitFlips.java
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to the Apache Softw
jpountz commented on a change in pull request #1569:
URL: https://github.com/apache/lucene-solr/pull/1569#discussion_r438754619
##
File path:
lucene/core/src/test/org/apache/lucene/index/TestAllFilesDetectBitFlips.java
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to the Apache Softwa
jpountz commented on pull request #1569:
URL: https://github.com/apache/lucene-solr/pull/1569#issuecomment-642621848
> So we now check checksums on every file when opening
We only verify checksums of meta file when opening (those that we read
entirely anyway). Checksums only get veri
gerlowskija opened a new pull request #1570:
URL: https://github.com/apache/lucene-solr/pull/1570
# Description
Previously, SolrLogPostTool ignored all log-lines that didn't fall into a
narrow handful of known "types". This change adds a new "other" type, to hold
all previously-ign
mikemccand commented on a change in pull request #1569:
URL: https://github.com/apache/lucene-solr/pull/1569#discussion_r438774512
##
File path:
lucene/core/src/test/org/apache/lucene/index/TestAllFilesDetectBitFlips.java
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to the Apache Sof
[
https://issues.apache.org/jira/browse/SOLR-14557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133288#comment-17133288
]
David Smiley commented on SOLR-14557:
-
The issue description is a bit unclear to me i
jpountz commented on a change in pull request #1569:
URL: https://github.com/apache/lucene-solr/pull/1569#discussion_r438831834
##
File path:
lucene/core/src/test/org/apache/lucene/index/TestAllFilesDetectBitFlips.java
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to the Apache Softwa
[
https://issues.apache.org/jira/browse/SOLR-14557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133301#comment-17133301
]
Mikhail Khludnev commented on SOLR-14557:
-
Thanks for response , [~dsmiley].
# it
[
https://issues.apache.org/jira/browse/SOLR-14557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133301#comment-17133301
]
Mikhail Khludnev edited comment on SOLR-14557 at 6/11/20, 2:38 PM:
[
https://issues.apache.org/jira/browse/SOLR-14557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133301#comment-17133301
]
Mikhail Khludnev edited comment on SOLR-14557 at 6/11/20, 2:38 PM:
madrob merged pull request #1565:
URL: https://github.com/apache/lucene-solr/pull/1565
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133360#comment-17133360
]
ASF subversion and git services commented on SOLR-12823:
Commit b
jpountz merged pull request #1569:
URL: https://github.com/apache/lucene-solr/pull/1569
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/LUCENE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133366#comment-17133366
]
ASF subversion and git services commented on LUCENE-9356:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133367#comment-17133367
]
ASF subversion and git services commented on LUCENE-9356:
-
Commi
jpountz commented on pull request #1557:
URL: https://github.com/apache/lucene-solr/pull/1557#issuecomment-642781876
@rmuir I combined them in an overloaded `retrieveChecksum(IndexInput, long)`
variant, what do you think?
Th
[
https://issues.apache.org/jira/browse/LUCENE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-9356.
--
Fix Version/s: 8.6
Resolution: Fixed
> Add tests for corruptions caused by byte flips
>
[
https://issues.apache.org/jira/browse/LUCENE-9397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133372#comment-17133372
]
ASF subversion and git services commented on LUCENE-9397:
-
Commi
bruno-roustant closed pull request #1564:
URL: https://github.com/apache/lucene-solr/pull/1564
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
[
https://issues.apache.org/jira/browse/LUCENE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133374#comment-17133374
]
ASF subversion and git services commented on LUCENE-9356:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133376#comment-17133376
]
ASF subversion and git services commented on LUCENE-9356:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133403#comment-17133403
]
Adrien Grand commented on LUCENE-9356:
--
I had beasted many iterations but the Elast
danmuzi commented on pull request #1560:
URL: https://github.com/apache/lucene-solr/pull/1560#issuecomment-642827027
Hi Patrick,
Thanks for your contribution đź‘Ť
I found the JIRA-issue number of this PR is wrong.
It should be changed from [LUCENE-8574] to [LUCENE-9391].
https://is
madrob commented on a change in pull request #1561:
URL: https://github.com/apache/lucene-solr/pull/1561#discussion_r438907365
##
File path: solr/core/src/java/org/apache/solr/cloud/OverseerMessageHandler.java
##
@@ -50,7 +50,7 @@
/**Try to provide an exclusive lock for this
zhaih commented on pull request #1560:
URL: https://github.com/apache/lucene-solr/pull/1560#issuecomment-642830815
> Hi Patrick,
> Thanks for your contribution đź‘Ť
> I found the JIRA-issue number of this PR is wrong.
> It should be changed from [LUCENE-8574] to [LUCENE-9391].
> htt
zhaih commented on pull request #1560:
URL: https://github.com/apache/lucene-solr/pull/1560#issuecomment-642835331
Do I need to squash the commits? Seems commits in Lucene are all squashed?
Or it will be done automatically when merging somehow?
murblanc commented on a change in pull request #1561:
URL: https://github.com/apache/lucene-solr/pull/1561#discussion_r438965089
##
File path: solr/core/src/java/org/apache/solr/cloud/OverseerTaskProcessor.java
##
@@ -253,20 +277,22 @@ public void run() {
continue;
murblanc commented on a change in pull request #1561:
URL: https://github.com/apache/lucene-solr/pull/1561#discussion_r438966974
##
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/OverseerCollectionMessageHandler.java
##
@@ -867,26 +866,25 @@ public String
murblanc commented on a change in pull request #1561:
URL: https://github.com/apache/lucene-solr/pull/1561#discussion_r438967387
##
File path:
solr/solrj/src/java/org/apache/solr/common/params/CollectionParams.java
##
@@ -42,31 +42,30 @@
enum LockLevel {
-CLUSTER(0)
[
https://issues.apache.org/jira/browse/LUCENE-9397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133535#comment-17133535
]
ASF subversion and git services commented on LUCENE-9397:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Roustant resolved LUCENE-9397.
Fix Version/s: 8.6
Resolution: Fixed
Thanks [~dsmiley]Â for the review.
> UniformSp
murblanc commented on a change in pull request #1561:
URL: https://github.com/apache/lucene-solr/pull/1561#discussion_r438970686
##
File path: solr/core/src/java/org/apache/solr/cloud/OverseerTaskProcessor.java
##
@@ -95,16 +95,25 @@
private volatile Stats stats;
- // S
danmuzi commented on pull request #1560:
URL: https://github.com/apache/lucene-solr/pull/1560#issuecomment-642844611
Please do the **"Squash and merge"** below.
Your sub commits will be combined automatically.
This is an a
murblanc commented on a change in pull request #1561:
URL: https://github.com/apache/lucene-solr/pull/1561#discussion_r438974719
##
File path: solr/core/src/java/org/apache/solr/cloud/OverseerTaskProcessor.java
##
@@ -95,16 +95,25 @@
private volatile Stats stats;
- // S
murblanc commented on a change in pull request #1561:
URL: https://github.com/apache/lucene-solr/pull/1561#discussion_r438976552
##
File path: solr/core/src/java/org/apache/solr/cloud/OverseerTaskProcessor.java
##
@@ -95,16 +95,25 @@
private volatile Stats stats;
- // S
tflobbe commented on pull request #1567:
URL: https://github.com/apache/lucene-solr/pull/1567#issuecomment-642845936
Ah! good Catch, I missed that completely. I'll fix.
This is an automated message from the Apache Git Service
madrob commented on a change in pull request #1563:
URL: https://github.com/apache/lucene-solr/pull/1563#discussion_r438975730
##
File path: lucene/core/src/test/org/apache/lucene/analysis/TestCharArraySet.java
##
@@ -61,15 +61,17 @@ public void testNonZeroOffset() {
public
mikemccand commented on a change in pull request #1543:
URL: https://github.com/apache/lucene-solr/pull/1543#discussion_r438928868
##
File path: lucene/CHANGES.txt
##
@@ -218,6 +218,10 @@ Optimizations
* LUCENE-9087: Build always trees with full leaves and lower the default va
madrob commented on a change in pull request #1563:
URL: https://github.com/apache/lucene-solr/pull/1563#discussion_r438975730
##
File path: lucene/core/src/test/org/apache/lucene/analysis/TestCharArraySet.java
##
@@ -61,15 +61,17 @@ public void testNonZeroOffset() {
public
mikemccand commented on a change in pull request #1543:
URL: https://github.com/apache/lucene-solr/pull/1543#discussion_r438928868
##
File path: lucene/CHANGES.txt
##
@@ -218,6 +218,10 @@ Optimizations
* LUCENE-9087: Build always trees with full leaves and lower the default va
[
https://issues.apache.org/jira/browse/SOLR-14558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski reassigned SOLR-14558:
--
Assignee: Jason Gerlowski
> SolrLogPostTool should record all lines
>
Alessandro Benedetti created SOLR-14560:
---
Summary: Learning To Rank Interleaving
Key: SOLR-14560
URL: https://issues.apache.org/jira/browse/SOLR-14560
Project: Solr
Issue Type: New Feat
alessandrobenedetti opened a new pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571
# Description
Interleaving is an approach to Online Search Quality evaluation that can be
very useful for Learning To Rank models:
https://sease.io/2020/05/online-testing
[
https://issues.apache.org/jira/browse/SOLR-14560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133592#comment-17133592
]
Alessandro Benedetti commented on SOLR-14560:
-
The draft is attached :
[htt
madrob commented on a change in pull request #1561:
URL: https://github.com/apache/lucene-solr/pull/1561#discussion_r439007539
##
File path: solr/core/src/java/org/apache/solr/cloud/OverseerTaskProcessor.java
##
@@ -95,16 +95,25 @@
private volatile Stats stats;
- // Set
madrob commented on a change in pull request #1561:
URL: https://github.com/apache/lucene-solr/pull/1561#discussion_r439007892
##
File path:
solr/solrj/src/java/org/apache/solr/common/params/CollectionParams.java
##
@@ -42,31 +42,30 @@
enum LockLevel {
-CLUSTER(0),
[
https://issues.apache.org/jira/browse/SOLR-14557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133600#comment-17133600
]
David Smiley commented on SOLR-14557:
-
Thanks for clarifying. Then it seems there is
murblanc commented on a change in pull request #1561:
URL: https://github.com/apache/lucene-solr/pull/1561#discussion_r439009885
##
File path: solr/core/src/java/org/apache/solr/cloud/OverseerTaskProcessor.java
##
@@ -95,16 +95,25 @@
private volatile Stats stats;
- // S
madrob commented on a change in pull request #1561:
URL: https://github.com/apache/lucene-solr/pull/1561#discussion_r439010217
##
File path: solr/core/src/java/org/apache/solr/cloud/OverseerTaskProcessor.java
##
@@ -253,20 +277,22 @@ public void run() {
continue;
Jan Høydahl created SOLR-14561:
--
Summary: Validate parameters to CoreAdminAPI
Key: SOLR-14561
URL: https://issues.apache.org/jira/browse/SOLR-14561
Project: Solr
Issue Type: Improvement
Se
madrob merged pull request #1556:
URL: https://github.com/apache/lucene-solr/pull/1556
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/SOLR-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133615#comment-17133615
]
ASF subversion and git services commented on SOLR-8392:
---
Commit fb98
[
https://issues.apache.org/jira/browse/SOLR-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob resolved SOLR-8392.
-
Fix Version/s: (was: 7.0)
master (9.0)
Resolution: Fixed
> SolrParam.get(Str
[
https://issues.apache.org/jira/browse/SOLR-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133616#comment-17133616
]
Mike Drob commented on SOLR-8392:
-
Hopefully that fixes this, but if it doesn't then we sh
msokolov commented on pull request #1563:
URL: https://github.com/apache/lucene-solr/pull/1563#issuecomment-642886971
Thanks for the comments, @madrob, I posted a new PR addressing them. I'm not
sure how I missed all that unused code in RandomizedShapeTestCase - it's pretty
bare now!
---
gandhi-viral commented on pull request #1543:
URL: https://github.com/apache/lucene-solr/pull/1543#issuecomment-642889243
Red-line QPS (throughput) based on our internal benchmarking is still
unfortunately suffering (-49%) with the latest PR.
We were able to isolate one particular fi
jpountz commented on a change in pull request #1543:
URL: https://github.com/apache/lucene-solr/pull/1543#discussion_r439048284
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java
##
@@ -404,32 +406,51 @@ private void flushData()
ErickErickson commented on pull request #1563:
URL: https://github.com/apache/lucene-solr/pull/1563#issuecomment-642915566
speaking from experience, when dealing with this many changes in a big
wodge, it’s _very easy_ to have some things slip through ;)
> On Jun 11, 2020, at 3:34 PM,
janhoy commented on a change in pull request #1546:
URL: https://github.com/apache/lucene-solr/pull/1546#discussion_r439060787
##
File path: solr/core/src/java/org/apache/solr/core/CoreDescriptor.java
##
@@ -182,7 +182,7 @@ public CoreDescriptor(String coreName, CoreDescriptor
gandhi-viral commented on pull request #1543:
URL: https://github.com/apache/lucene-solr/pull/1543#issuecomment-642931662
> @gandhi-viral That would work for me but I'd like to make sure we're
talking about the same thing:
>
> * Lucene86DocValuesConsumer gets a ctor argument to confi
dsmiley commented on a change in pull request #1546:
URL: https://github.com/apache/lucene-solr/pull/1546#discussion_r439083930
##
File path: solr/core/src/java/org/apache/solr/core/CoreDescriptor.java
##
@@ -182,7 +182,7 @@ public CoreDescriptor(String coreName, CoreDescriptor
[
https://issues.apache.org/jira/browse/SOLR-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133721#comment-17133721
]
David Smiley commented on SOLR-8392:
Thanks Mike! I like the assertions.
I noticed a
[
https://issues.apache.org/jira/browse/SOLR-14559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133731#comment-17133731
]
ASF subversion and git services commented on SOLR-14559:
Commit f
[
https://issues.apache.org/jira/browse/SOLR-14559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133732#comment-17133732
]
ASF subversion and git services commented on SOLR-14559:
Commit 0
[
https://issues.apache.org/jira/browse/SOLR-14559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson resolved SOLR-14559.
---
Fix Version/s: 8.6
Resolution: Fixed
> Fix or suppress warnings in solr/core/src/java/
janhoy opened a new pull request #1572:
URL: https://github.com/apache/lucene-solr/pull/1572
See https://issues.apache.org/jira/browse/SOLR-14561
The `instanceDir` and `dataDir` params must now be relative to either
`SOLR_HOME`, `SOLR_DATA_HOME` or `coreRootDir`.
Added new sol
[
https://issues.apache.org/jira/browse/SOLR-14561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl reassigned SOLR-14561:
--
Assignee: Jan Høydahl
> Validate parameters to CoreAdminAPI
>
[
https://issues.apache.org/jira/browse/SOLR-14561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-14561:
---
Description: CoreAdminAPI does not validate parameter input. We should
limit what users can specify f
[
https://issues.apache.org/jira/browse/SOLR-14561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133782#comment-17133782
]
Jan Høydahl commented on SOLR-14561:
First PR ready, see [https://github.com/apache/l
janhoy commented on pull request #1572:
URL: https://github.com/apache/lucene-solr/pull/1572#issuecomment-642990676
I think the only thing I'm lacking is a real integration test. I validated
manually that core creation fails in `/tmp`, and that setting
`-Dsolr.allowPaths=/tmp` allows it:
[
https://issues.apache.org/jira/browse/SOLR-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133801#comment-17133801
]
Chris M. Hostetter commented on SOLR-13132:
---
Hey Michael, I still haven't had a
dweiss merged pull request #1560:
URL: https://github.com/apache/lucene-solr/pull/1560
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/LUCENE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133940#comment-17133940
]
ASF subversion and git services commented on LUCENE-8574:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133939#comment-17133939
]
ASF subversion and git services commented on LUCENE-9391:
-
Commi
83 matches
Mail list logo
