gandhi-viral commented on pull request #1543: URL: https://github.com/apache/lucene-solr/pull/1543#issuecomment-642931662
> @gandhi-viral That would work for me but I'd like to make sure we're talking about the same thing: > > * Lucene86DocValuesConsumer gets a ctor argument to configure the threshold. > * Lucene86DocValuesFormat keeps 32 as a default value. > * You would create your own DocValuesFormat that would reuse Lucene86DocValuesProducer and create a Lucene86DocValuesConsumer with a high threshold for compression of binary values. > * You would enable this format by overriding getDocValueFormatForField in Lucene86Codec. > * This would mean that your indices would no longer have backward compatibility guarantees of the default codec (N-1) but maybe you don't care since you're re-building your indices from scratch on a regular basis? Yes, that's what I had in mind too. Currently, we are doing similar thing after `8.5.1` upgrade to keep using forked BDVs from `8.4`. You are right about backward compatibility guarantees not being an issue for our use-case since we do re-build our indices on each software deployment. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
