noblepaul commented on pull request #1542:
URL: https://github.com/apache/lucene-solr/pull/1542#issuecomment-641785613
@murblanc
I've fixed a few things pls review & I can merge this
This is an automated message from the
Ignacio Vera created LUCENE-9400:
Summary: Tessallator might fail when several holes share the same
vertex
Key: LUCENE-9400
URL: https://issues.apache.org/jira/browse/LUCENE-9400
Project: Lucene - Cor
dweiss commented on pull request #1560:
URL: https://github.com/apache/lucene-solr/pull/1560#issuecomment-641821902
Hi Patrick. Would you add a corresponding CHANGES entry (to both Solr and
Lucene, I guess) and attribution to your name? Otherwise LGTM.
iverase opened a new pull request #1562:
URL: https://github.com/apache/lucene-solr/pull/1562
Make sure we do not build illegal polygons when merging holes that share a
single vertex.
see https://issues.apache.org/jira/browse/LUCENE-9400
iverase commented on pull request #1562:
URL: https://github.com/apache/lucene-solr/pull/1562#issuecomment-641823144
@nknize Can you have a look?
This is an automated message from the Apache Git Service.
To respond to the mes
[
https://issues.apache.org/jira/browse/LUCENE-9353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130389#comment-17130389
]
Adrien Grand commented on LUCENE-9353:
--
I went a bit further on the PR and also mov
murblanc commented on a change in pull request #1542:
URL: https://github.com/apache/lucene-solr/pull/1542#discussion_r438038559
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/Policy.java
##
@@ -644,15 +643,13 @@ public Session cloneToNewSessi
[
https://issues.apache.org/jira/browse/LUCENE-9394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130513#comment-17130513
]
Michael Sokolov commented on LUCENE-9394:
-
I did a round of this, will post a PR
murblanc commented on pull request #1542:
URL: https://github.com/apache/lucene-solr/pull/1542#issuecomment-641927858
> @murblanc
> I've fixed a few things pls review & I can merge this
Added one comment. Looks good, thanks for picking this one up.
---
noblepaul commented on a change in pull request #1542:
URL: https://github.com/apache/lucene-solr/pull/1542#discussion_r438043059
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/Policy.java
##
@@ -644,15 +643,13 @@ public Session cloneToNewSess
noblepaul merged pull request #1542:
URL: https://github.com/apache/lucene-solr/pull/1542
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/SOLR-14347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130527#comment-17130527
]
ASF subversion and git services commented on SOLR-14347:
Commit d
[
https://issues.apache.org/jira/browse/SOLR-14347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130526#comment-17130526
]
ASF subversion and git services commented on SOLR-14347:
Commit d
msokolov opened a new pull request #1563:
URL: https://github.com/apache/lucene-solr/pull/1563
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
[
https://issues.apache.org/jira/browse/SOLR-14347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul resolved SOLR-14347.
---
Resolution: Fixed
> Autoscaling placement wrong when concurrent replica placements are calculated
> -
[
https://issues.apache.org/jira/browse/SOLR-14347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130573#comment-17130573
]
ASF subversion and git services commented on SOLR-14347:
Commit b
[
https://issues.apache.org/jira/browse/SOLR-14469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130595#comment-17130595
]
Erick Erickson commented on SOLR-14469:
---
{quote}I'm just unsure of the value of try
[
https://issues.apache.org/jira/browse/LUCENE-9394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130600#comment-17130600
]
Michael Sokolov commented on LUCENE-9394:
-
So, I tinkered with changing the raw
[
https://issues.apache.org/jira/browse/LUCENE-9394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130608#comment-17130608
]
Erick Erickson commented on LUCENE-9394:
Glad you’re looking at this.
If you t
[
https://issues.apache.org/jira/browse/LUCENE-9394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130618#comment-17130618
]
Erick Erickson commented on LUCENE-9394:
re: Changing ValueSource context to Map
[
https://issues.apache.org/jira/browse/LUCENE-9394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130627#comment-17130627
]
Michael Sokolov commented on LUCENE-9394:
-
> did you know you can add that annot
[
https://issues.apache.org/jira/browse/SOLR-14541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130677#comment-17130677
]
Gézapeti commented on SOLR-14541:
-
I'd +1 [~murblanc]'s suggestion. If we implement a has
[
https://issues.apache.org/jira/browse/SOLR-14541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gézapeti updated SOLR-14541:
Attachment: 0003-SOLR-14541-add-hashCode-or-remove-equals-for-some-cl.patch
0002-SOLR-14541-
[
https://issues.apache.org/jira/browse/SOLR-14469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130678#comment-17130678
]
Erick Erickson commented on SOLR-14469:
---
There's some discussion at: LUCENE-9394...
[
https://issues.apache.org/jira/browse/LUCENE-9394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130679#comment-17130679
]
Erick Erickson commented on LUCENE-9394:
Adding link to the deprecations JIRA.
[
https://issues.apache.org/jira/browse/LUCENE-9400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera updated LUCENE-9400:
-
Summary: Tessellator might fail when several holes share the same vertex
(was: Tessallator migh
[
https://issues.apache.org/jira/browse/SOLR-14541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130681#comment-17130681
]
Erick Erickson commented on SOLR-14541:
---
Yeah, that's a good idea for at least two
[
https://issues.apache.org/jira/browse/SOLR-14556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated SOLR-14556:
--
Summary: Fix or suppress warnings in solrj/cloud/autoscaling (was: Fix or
suppress warnings in
[
https://issues.apache.org/jira/browse/SOLR-14345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130702#comment-17130702
]
ASF subversion and git services commented on SOLR-14345:
Commit 5
[
https://issues.apache.org/jira/browse/SOLR-14550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130701#comment-17130701
]
ASF subversion and git services commented on SOLR-14550:
Commit 0
mikemccand commented on a change in pull request #1560:
URL: https://github.com/apache/lucene-solr/pull/1560#discussion_r438144513
##
File path: lucene/ivy-versions.properties
##
@@ -10,7 +10,7 @@ com.carrotsearch.randomizedtesting.version = 2.7.6
/com.carrotsearch.thirdpart
[
https://issues.apache.org/jira/browse/SOLR-14345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130716#comment-17130716
]
ASF subversion and git services commented on SOLR-14345:
Commit 6
[
https://issues.apache.org/jira/browse/SOLR-14550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130715#comment-17130715
]
ASF subversion and git services commented on SOLR-14550:
Commit a
bruno-roustant opened a new pull request #1564:
URL: https://github.com/apache/lucene-solr/pull/1564
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
[
https://issues.apache.org/jira/browse/SOLR-14550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Munendra S N updated SOLR-14550:
Fix Version/s: 8.6
Resolution: Fixed
Status: Resolved (was: Patch Available)
> A
[
https://issues.apache.org/jira/browse/SOLR-14345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Munendra S N updated SOLR-14345:
Fix Version/s: 8.6
Resolution: Fixed
Status: Resolved (was: Patch Available)
> E
[
https://issues.apache.org/jira/browse/LUCENE-9397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130720#comment-17130720
]
Bruno Roustant commented on LUCENE-9397:
PR added
> UniformSplit supports encod
mikemccand commented on pull request #1543:
URL: https://github.com/apache/lucene-solr/pull/1543#issuecomment-642055625
@jpountz I am still confused about the above benchmarks. If baseline was
master with `BINARY` compression reverted, contender is this PR (which adds
compression but is m
s1monw commented on a change in pull request #1552:
URL: https://github.com/apache/lucene-solr/pull/1552#discussion_r438153575
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##
@@ -4483,6 +4593,7 @@ public int length() {
// Merge would prod
[
https://issues.apache.org/jira/browse/SOLR-14409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cassandra Targett updated SOLR-14409:
-
Fix Version/s: 8.6
> Existing violations allow bypassing policy rules when adding new rep
[
https://issues.apache.org/jira/browse/SOLR-12382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cassandra Targett resolved SOLR-12382.
--
Resolution: Information Provided (was: Invalid)
Marking as resolved since comments see
[
https://issues.apache.org/jira/browse/LUCENE-9392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130818#comment-17130818
]
Michael McCandless commented on LUCENE-9392:
Thanks [~goankur], patch looks
[
https://issues.apache.org/jira/browse/SOLR-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130827#comment-17130827
]
Michael Gibney commented on SOLR-13132:
---
Just pushed a commit (5e021167fe0cf8ee212e
jpountz commented on pull request #1543:
URL: https://github.com/apache/lucene-solr/pull/1543#issuecomment-642106140
@mikemccand I think that there are two things that get combined:
- it's cheaper to do a single `IndexInput#readBytes` call with 32X bytes,
than 32 `IndexInput#readBytes`
Mikhail Khludnev created SOLR-14557:
---
Summary: eDisMax regression
Key: SOLR-14557
URL: https://issues.apache.org/jira/browse/SOLR-14557
Project: Solr
Issue Type: Bug
Security Level: P
[
https://issues.apache.org/jira/browse/SOLR-14557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Khludnev updated SOLR-14557:
Summary: eDisMax (regression) (was: eDisMax regression)
> eDisMax (regression)
> -
[
https://issues.apache.org/jira/browse/SOLR-14557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Khludnev updated SOLR-14557:
Description:
h2. Solr 4.5
{{/select?defType=edismax&q={!lucene}(foo)&debugQuery=true}}
[
https://issues.apache.org/jira/browse/SOLR-14557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Khludnev updated SOLR-14557:
Description:
h2. Solr 4.5
{{/select?defType=edismax&q=\{!lucene}(foo)&debugQuery=true}}
[
https://issues.apache.org/jira/browse/LUCENE-9392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130908#comment-17130908
]
ASF subversion and git services commented on LUCENE-9392:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-9392:
---
Fix Version/s: 8.6
Resolution: Fixed
Status: Resolved (was: Patch
[
https://issues.apache.org/jira/browse/LUCENE-9392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130910#comment-17130910
]
ASF subversion and git services commented on LUCENE-9392:
-
Commi
[
https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130920#comment-17130920
]
Ilan Ginzburg commented on SOLR-12823:
--
Failures of:
{code:java}
CloudHttp2SolrClien
[
https://issues.apache.org/jira/browse/LUCENE-9395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130930#comment-17130930
]
Tony Xu commented on LUCENE-9395:
-
Thanks Atri and David for taking the time to respond
[
https://issues.apache.org/jira/browse/LUCENE-9397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130940#comment-17130940
]
Adrien Grand commented on LUCENE-9397:
--
Out of curiosity, what kind of data are you
Thomas Hecker created LUCENE-9401:
-
Summary: ComplexPhraseQuery's toString method always omits field
name
Key: LUCENE-9401
URL: https://issues.apache.org/jira/browse/LUCENE-9401
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilan Ginzburg updated SOLR-12823:
-
Comment: was deleted
(was: Failures of:
{code:java}
CloudHttp2SolrClientTest.testWrongZkChrootTes
[
https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17131078#comment-17131078
]
Ilan Ginzburg commented on SOLR-12823:
--
Just deleted my previous comment: environmen
[
https://issues.apache.org/jira/browse/LUCENE-9401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Hecker updated LUCENE-9401:
--
Attachment: LUCENE-9401.patch
Lucene Fields: New,Patch Available (was: New)
[
https://issues.apache.org/jira/browse/LUCENE-9401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Hecker updated LUCENE-9401:
--
Status: Patch Available (was: Open)
> ComplexPhraseQuery's toString method always omits field
Jason Gerlowski created SOLR-14558:
--
Summary: SolrLogPostTool should record all lines
Key: SOLR-14558
URL: https://issues.apache.org/jira/browse/SOLR-14558
Project: Solr
Issue Type: Improvem
rmuir commented on pull request #1557:
URL: https://github.com/apache/lucene-solr/pull/1557#issuecomment-642242198
Should we keep the existing check also? It does more than just check length,
it validates this "footer" too (e.g. detecting invalid bits).
---
murblanc opened a new pull request #1565:
URL: https://github.com/apache/lucene-solr/pull/1565
# Description
Fix test failures in CloudHttp2SolrClientTest CloudSolrClientTest
TestCloudSolrClientConnections due to previous SOLR-12823 commit.
# Solution
ZkStateReader retu
Tomas Eduardo Fernandez Lobbe created LUCENE-9402:
-
Summary: Let MultiCollector Scorer handle minCompetitiveScore calls
Key: LUCENE-9402
URL: https://issues.apache.org/jira/browse/LUCENE-9402
[
https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132716#comment-17132716
]
Ilan Ginzburg commented on SOLR-12823:
--
PR [https://github.com/apache/lucene-solr/pu
tflobbe opened a new pull request #1566:
URL: https://github.com/apache/lucene-solr/pull/1566
This PR includes a commit in Lucene, for which I'm going to create a
separate PR.
This is an automated message from the Apache Git
murblanc commented on a change in pull request #1565:
URL: https://github.com/apache/lucene-solr/pull/1565#discussion_r438409534
##
File path: solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java
##
@@ -476,27 +476,32 @@ public synchronized void
createClusterSta
[
https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132721#comment-17132721
]
Erick Erickson commented on SOLR-12823:
---
AFAIK all of the tests are run by both bui
tflobbe opened a new pull request #1567:
URL: https://github.com/apache/lucene-solr/pull/1567
Here is an idea to make MultiCollector be able to handle
`minCompetitiveScore`. Looking at this comment in the code:
```
// Ignore calls to setMinCompetitiveScore so that if we wr
tflobbe commented on a change in pull request #1567:
URL: https://github.com/apache/lucene-solr/pull/1567#discussion_r438420301
##
File path: lucene/core/src/java/org/apache/lucene/search/MultiCollector.java
##
@@ -143,32 +143,43 @@ public LeafCollector getLeafCollector(LeafRea
tflobbe merged pull request #1559:
URL: https://github.com/apache/lucene-solr/pull/1559
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/SOLR-14552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132749#comment-17132749
]
ASF subversion and git services commented on SOLR-14552:
Commit 9
tflobbe commented on pull request #1567:
URL: https://github.com/apache/lucene-solr/pull/1567#issuecomment-642292175
https://github.com/apache/lucene-solr/pull/1566 contains the Solr related
changes
This is an automated mess
[
https://issues.apache.org/jira/browse/SOLR-14552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132757#comment-17132757
]
ASF subversion and git services commented on SOLR-14552:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-14455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132759#comment-17132759
]
ASF subversion and git services commented on SOLR-14455:
Commit 0
[
https://issues.apache.org/jira/browse/SOLR-14455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132760#comment-17132760
]
ASF subversion and git services commented on SOLR-14455:
Commit e
[
https://issues.apache.org/jira/browse/SOLR-14555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132762#comment-17132762
]
Erick Erickson commented on SOLR-14555:
---
Bah, I mis-typed the Jira again.
Commit
[
https://issues.apache.org/jira/browse/SOLR-14555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson resolved SOLR-14555.
---
Fix Version/s: 8.6
Resolution: Fixed
> Fix or suppress warnings in solr/test-framework
[
https://issues.apache.org/jira/browse/SOLR-14455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated SOLR-14455:
--
Comment: was deleted
(was: Commit e7c625430ed916fd7d0e7e8d1cdc329093d817b4 in lucene-solr's bra
[
https://issues.apache.org/jira/browse/SOLR-14455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated SOLR-14455:
--
Comment: was deleted
(was: Commit 07a203628ea46308612f4bb60686c313a6e4d75e in lucene-solr's bra
[
https://issues.apache.org/jira/browse/SOLR-14455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132763#comment-17132763
]
Erick Erickson commented on SOLR-14455:
---
I mis-typed the Jira number, ignore these
[
https://issues.apache.org/jira/browse/SOLR-14552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomas Eduardo Fernandez Lobbe resolved SOLR-14552.
--
Fix Version/s: 8.6
master (9.0)
Assi
[
https://issues.apache.org/jira/browse/SOLR-14554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomas Eduardo Fernandez Lobbe reassigned SOLR-14554:
Assignee: Tomas Eduardo Fernandez Lobbe
> BMW algorithm is
[
https://issues.apache.org/jira/browse/LUCENE-9401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132786#comment-17132786
]
Lucene/Solr QA commented on LUCENE-9401:
| (x) *{color:red}-1 overall{color}* |
[
https://issues.apache.org/jira/browse/SOLR-14541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132814#comment-17132814
]
Erick Erickson commented on SOLR-14541:
---
I'm working on the warnings in autoscaling
zhaih commented on pull request #1560:
URL: https://github.com/apache/lucene-solr/pull/1560#issuecomment-642435935
> Hi Patrick. Would you add a corresponding CHANGES entry (to both Solr and
Lucene, I guess) and attribution to your name? Otherwise LGTM.
Thanks for reminding me that!
zhaih commented on a change in pull request #1560:
URL: https://github.com/apache/lucene-solr/pull/1560#discussion_r438569802
##
File path: lucene/ivy-versions.properties
##
@@ -10,7 +10,7 @@ com.carrotsearch.randomizedtesting.version = 2.7.6
/com.carrotsearch.thirdparty/sim
jpountz commented on a change in pull request #1567:
URL: https://github.com/apache/lucene-solr/pull/1567#discussion_r438575844
##
File path: lucene/core/src/test/org/apache/lucene/search/MultiCollectorTest.java
##
@@ -163,4 +163,64 @@ public void testCacheScoresIfNecessary() t
87 matches
Mail list logo
