tflobbe opened a new pull request #1567: URL: https://github.com/apache/lucene-solr/pull/1567
Here is an idea to make MultiCollector be able to handle `minCompetitiveScore`. Looking at this comment in the code: ``` // Ignore calls to setMinCompetitiveScore so that if we wrap two // collectors and one of them wants to skip low-scoring hits, then // the other collector still sees all hits. We could try to reconcile // min scores and take the maximum min score across collectors, but // this is very unlikely to be helpful in practice. ``` This implementation tries to make it so that all collectors can see all the hits and only allow skipping if all collectors set a min competitive score. The value passed to the inner scorer is the minimum among all collectors (instead of the maximum as the comment suggests). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org