[jira] [Commented] (LUCENE-9286) FST construction explodes memory in BitTable

2020-04-08 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17077913#comment-17077913 ] Dawid Weiss commented on LUCENE-9286: - Thanks Bruno. I'll review and check with our

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-08 Thread GitBox
s1monw commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#discussion_r405325601 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriter.java ## @@ -322,35

[GitHub] [lucene-solr] s1monw commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-08 Thread GitBox
s1monw commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#issuecomment-610808420 > I'll look again -- in the meantime I beasted all Lucene (core + modules) tests and hit this failure. It does not reproduce, an

[jira] [Commented] (SOLR-14394) Many request handlers should be startup=lazy

2020-04-08 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17077933#comment-17077933 ] Andrzej Bialecki commented on SOLR-14394: - I think this is generally a good idea,

[GitHub] [lucene-solr] CaoManhDat commented on a change in pull request #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (W

2020-04-08 Thread GitBox
CaoManhDat commented on a change in pull request #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP) URL: https://github.com/apache/lucene-solr/pull/1395#discussion_r405356167 ## File path: solr/core/s

[GitHub] [lucene-solr] CaoManhDat commented on a change in pull request #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (W

2020-04-08 Thread GitBox
CaoManhDat commented on a change in pull request #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP) URL: https://github.com/apache/lucene-solr/pull/1395#discussion_r405355937 ## File path: solr/core/sr

[jira] [Created] (LUCENE-9309) IW#addIndices(CodecReader) might delete files concurrently to IW#rollback

2020-04-08 Thread Simon Willnauer (Jira)
Simon Willnauer created LUCENE-9309: --- Summary: IW#addIndices(CodecReader) might delete files concurrently to IW#rollback Key: LUCENE-9309 URL: https://issues.apache.org/jira/browse/LUCENE-9309 Proje

[GitHub] [lucene-solr] s1monw commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-08 Thread GitBox
s1monw commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#issuecomment-610867265 I opened [LUCENE-9309](https://issues.apache.org/jira/browse/LUCENE-9309) for this

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1416: LUCENE-9286: FST.Arc.BitTable is read directly from the FST bytes.

2020-04-08 Thread GitBox
dweiss commented on a change in pull request #1416: LUCENE-9286: FST.Arc.BitTable is read directly from the FST bytes. URL: https://github.com/apache/lucene-solr/pull/1416#discussion_r405405465 ## File path: lucene/core/src/java/org/apache/lucene/util/fst/BitTableUtil.java

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1416: LUCENE-9286: FST.Arc.BitTable is read directly from the FST bytes.

2020-04-08 Thread GitBox
dweiss commented on a change in pull request #1416: LUCENE-9286: FST.Arc.BitTable is read directly from the FST bytes. URL: https://github.com/apache/lucene-solr/pull/1416#discussion_r405422364 ## File path: lucene/core/src/java/org/apache/lucene/util/fst/FSTEnum.java ## @

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1416: LUCENE-9286: FST.Arc.BitTable is read directly from the FST bytes.

2020-04-08 Thread GitBox
dweiss commented on a change in pull request #1416: LUCENE-9286: FST.Arc.BitTable is read directly from the FST bytes. URL: https://github.com/apache/lucene-solr/pull/1416#discussion_r405421327 ## File path: lucene/core/src/java/org/apache/lucene/util/fst/FST.java ## @@ -1

[jira] [Updated] (LUCENE-9286) FST arc.copyOf clones BitTables and this can lead to excessive memory use

2020-04-08 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9286: Summary: FST arc.copyOf clones BitTables and this can lead to excessive memory use (was: FST cons

[jira] [Commented] (LUCENE-9266) ant nightly-smoke fails due to presence of build.gradle

2020-04-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078061#comment-17078061 ] ASF subversion and git services commented on LUCENE-9266: - Commi

[jira] [Commented] (LUCENE-9309) IW#addIndices(CodecReader) might delete files concurrently to IW#rollback

2020-04-08 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078070#comment-17078070 ] Uwe Schindler commented on LUCENE-9309: --- I do this quite often with codec reader.

[jira] [Commented] (LUCENE-9286) FST arc.copyOf clones BitTables and this can lead to excessive memory use

2020-04-08 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078075#comment-17078075 ] Dawid Weiss commented on LUCENE-9286: - I love the patch and the idea, Bruno. But the

[jira] [Comment Edited] (LUCENE-9286) FST arc.copyOf clones BitTables and this can lead to excessive memory use

2020-04-08 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078075#comment-17078075 ] Dawid Weiss edited comment on LUCENE-9286 at 4/8/20, 11:08 AM: ---

[jira] [Comment Edited] (SOLR-14394) Many request handlers should be startup=lazy

2020-04-08 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078080#comment-17078080 ] Noble Paul edited comment on SOLR-14394 at 4/8/20, 11:13 AM: -

[jira] [Commented] (SOLR-14394) Many request handlers should be startup=lazy

2020-04-08 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078080#comment-17078080 ] Noble Paul commented on SOLR-14394: --- I wonder if it's worth it to make them lazily regi

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique value

2020-04-08 Thread GitBox
bruno-roustant commented on a change in pull request #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP) URL: https://github.com/apache/lucene-solr/pull/1395#discussion_r405406935 ## File path: solr/co

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique value

2020-04-08 Thread GitBox
bruno-roustant commented on a change in pull request #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP) URL: https://github.com/apache/lucene-solr/pull/1395#discussion_r405478717 ## File path: solr/co

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique value

2020-04-08 Thread GitBox
bruno-roustant commented on a change in pull request #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP) URL: https://github.com/apache/lucene-solr/pull/1395#discussion_r405403028 ## File path: solr/cor

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique value

2020-04-08 Thread GitBox
bruno-roustant commented on a change in pull request #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP) URL: https://github.com/apache/lucene-solr/pull/1395#discussion_r405411173 ## File path: solr/co

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique value

2020-04-08 Thread GitBox
bruno-roustant commented on a change in pull request #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP) URL: https://github.com/apache/lucene-solr/pull/1395#discussion_r405478717 ## File path: solr/co

[GitHub] [lucene-solr] mikemccand commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-08 Thread GitBox
mikemccand commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#issuecomment-610930218 Hmm here's a more exotic test failure, also likely not caused by the changes here. The fun things you learn when beasting o

[GitHub] [lucene-solr] uschindler edited a comment on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-08 Thread GitBox
uschindler edited a comment on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#issuecomment-610937953 This could be related to Adrien's changes yesterday: https://issues.apache.org/jira/issue/LUCENE-9271 --

[GitHub] [lucene-solr] uschindler commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-08 Thread GitBox
uschindler commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#issuecomment-610937953 This could be related to Adrien's changes yesterday: https://issues.apache.org/jira/browse/issue/LUCENE-9271 --

[GitHub] [lucene-solr] uschindler edited a comment on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-08 Thread GitBox
uschindler edited a comment on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#issuecomment-610937953 This could be related to Adrien's changes yesterday: LUCENE-9271

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1416: LUCENE-9286: FST.Arc.BitTable is read directly from the FST bytes.

2020-04-08 Thread GitBox
bruno-roustant commented on a change in pull request #1416: LUCENE-9286: FST.Arc.BitTable is read directly from the FST bytes. URL: https://github.com/apache/lucene-solr/pull/1416#discussion_r405516244 ## File path: lucene/core/src/java/org/apache/lucene/util/fst/BitTableUtil.java

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1416: LUCENE-9286: FST.Arc.BitTable is read directly from the FST bytes.

2020-04-08 Thread GitBox
bruno-roustant commented on a change in pull request #1416: LUCENE-9286: FST.Arc.BitTable is read directly from the FST bytes. URL: https://github.com/apache/lucene-solr/pull/1416#discussion_r405518985 ## File path: lucene/core/src/java/org/apache/lucene/util/fst/FSTEnum.java #

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #1416: LUCENE-9286: FST.Arc.BitTable is read directly from the FST bytes.

2020-04-08 Thread GitBox
bruno-roustant commented on a change in pull request #1416: LUCENE-9286: FST.Arc.BitTable is read directly from the FST bytes. URL: https://github.com/apache/lucene-solr/pull/1416#discussion_r405530113 ## File path: lucene/core/src/java/org/apache/lucene/util/fst/FST.java #

[GitHub] [lucene-solr] dsmiley commented on issue #1412: Add MinimalSolrTest for scale testing

2020-04-08 Thread GitBox
dsmiley commented on issue #1412: Add MinimalSolrTest for scale testing URL: https://github.com/apache/lucene-solr/pull/1412#issuecomment-610972348 We *could* have hard timeouts if they are run by a specific CI machine, perhaps @sarowe real hardware? Before this gets committed, we ne

[GitHub] [lucene-solr] CaoManhDat commented on issue #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP)

2020-04-08 Thread GitBox
CaoManhDat commented on issue #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP) URL: https://github.com/apache/lucene-solr/pull/1395#issuecomment-610985910 > The javadoc in the constructor is good, but I'm co

[GitHub] [lucene-solr] CaoManhDat edited a comment on issue #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP)

2020-04-08 Thread GitBox
CaoManhDat edited a comment on issue #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP) URL: https://github.com/apache/lucene-solr/pull/1395#issuecomment-610985910 > The javadoc in the constructor is good, but

[GitHub] [lucene-solr] CaoManhDat edited a comment on issue #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP)

2020-04-08 Thread GitBox
CaoManhDat edited a comment on issue #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP) URL: https://github.com/apache/lucene-solr/pull/1395#issuecomment-610985910 > The javadoc in the constructor is good, but

[GitHub] [lucene-solr] CaoManhDat edited a comment on issue #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP)

2020-04-08 Thread GitBox
CaoManhDat edited a comment on issue #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP) URL: https://github.com/apache/lucene-solr/pull/1395#issuecomment-610985910 > The javadoc in the constructor is good, but

[GitHub] [lucene-solr] CaoManhDat edited a comment on issue #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP)

2020-04-08 Thread GitBox
CaoManhDat edited a comment on issue #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP) URL: https://github.com/apache/lucene-solr/pull/1395#issuecomment-610985910 > The javadoc in the constructor is good, but

[jira] [Commented] (SOLR-14210) Add replica state option for HealthCheckHandler

2020-04-08 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078326#comment-17078326 ] Jan Høydahl commented on SOLR-14210: bq. Why wouldn't you add the additional param th

[GitHub] [lucene-solr] CaoManhDat edited a comment on issue #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP)

2020-04-08 Thread GitBox
CaoManhDat edited a comment on issue #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP) URL: https://github.com/apache/lucene-solr/pull/1395#issuecomment-610985910 > The javadoc in the constructor is good, but

[GitHub] [lucene-solr] CaoManhDat edited a comment on issue #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP)

2020-04-08 Thread GitBox
CaoManhDat edited a comment on issue #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP) URL: https://github.com/apache/lucene-solr/pull/1395#issuecomment-610985910 > The javadoc in the constructor is good, but

[GitHub] [lucene-solr] CaoManhDat edited a comment on issue #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP)

2020-04-08 Thread GitBox
CaoManhDat edited a comment on issue #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP) URL: https://github.com/apache/lucene-solr/pull/1395#issuecomment-610985910 > The javadoc in the constructor is good, but

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects

2020-04-08 Thread GitBox
mocobeta commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects URL: https://github.com/apache/lucene-solr/pull/1388#discussion_r405603524 ## File path: gradle/render-javadoc.gradle ## @@ -15,93

[GitHub] [lucene-solr] bruno-roustant commented on issue #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP)

2020-04-08 Thread GitBox
bruno-roustant commented on issue #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP) URL: https://github.com/apache/lucene-solr/pull/1395#issuecomment-611020236 Yes I missed the power of 2. So I'll just let yo

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects

2020-04-08 Thread GitBox
mocobeta commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects URL: https://github.com/apache/lucene-solr/pull/1388#discussion_r405606070 ## File path: gradle/render-javadoc.gradle ## @@ -15,93

[GitHub] [lucene-solr] sigram opened a new pull request #1417: SOLR-12847: Auto-create a policy rule that corresponds to maxShardsPerNode

2020-04-08 Thread GitBox
sigram opened a new pull request #1417: SOLR-12847: Auto-create a policy rule that corresponds to maxShardsPerNode URL: https://github.com/apache/lucene-solr/pull/1417 # Description Please provide a short description of the changes you're making with this pull reques

[jira] [Commented] (LUCENE-9286) FST arc.copyOf clones BitTables and this can lead to excessive memory use

2020-04-08 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078431#comment-17078431 ] Bruno Roustant commented on LUCENE-9286: That's strange. In the PR I integrated

[jira] [Comment Edited] (LUCENE-9286) FST arc.copyOf clones BitTables and this can lead to excessive memory use

2020-04-08 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078431#comment-17078431 ] Bruno Roustant edited comment on LUCENE-9286 at 4/8/20, 4:10 PM: -

[GitHub] [lucene-solr] bringyou commented on issue #1389: LUCENE-9298: fix clearDeletedDocIds in BufferedUpdates

2020-04-08 Thread GitBox
bringyou commented on issue #1389: LUCENE-9298: fix clearDeletedDocIds in BufferedUpdates URL: https://github.com/apache/lucene-solr/pull/1389#issuecomment-611049924 > Change looks good to me. Would you mind adding a small test for this issue? Thanks @bringyou! sorry for the delay~

[jira] [Commented] (SOLR-13979) Expose separate metrics for distributed and non-distributed requests

2020-04-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078488#comment-17078488 ] David Smiley commented on SOLR-13979: - bq. These metrics are added to all handlers th

[jira] [Commented] (SOLR-13979) Expose separate metrics for distributed and non-distributed requests

2020-04-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078489#comment-17078489 ] David Smiley commented on SOLR-13979: - Also, distributed search long predated SolrClo

[jira] [Commented] (LUCENE-9286) FST arc.copyOf clones BitTables and this can lead to excessive memory use

2020-04-08 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078491#comment-17078491 ] Dawid Weiss commented on LUCENE-9286: - Let me double check and get back to you. Sorr

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1416: LUCENE-9286: FST.Arc.BitTable is read directly from the FST bytes.

2020-04-08 Thread GitBox
dweiss commented on a change in pull request #1416: LUCENE-9286: FST.Arc.BitTable is read directly from the FST bytes. URL: https://github.com/apache/lucene-solr/pull/1416#discussion_r405681455 ## File path: lucene/core/src/java/org/apache/lucene/util/fst/BitTableUtil.java

[jira] [Commented] (SOLR-14210) Add replica state option for HealthCheckHandler

2020-04-08 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078500#comment-17078500 ] Cassandra Targett commented on SOLR-14210: -- bq. The "Class & Javadocs" column of

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects

2020-04-08 Thread GitBox
dweiss commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects URL: https://github.com/apache/lucene-solr/pull/1388#discussion_r405684724 ## File path: gradle/render-javadoc.gradle ## @@ -15,93 +1

[jira] [Updated] (SOLR-13132) Improve JSON "terms" facet performance when sorted by relatedness

2020-04-08 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-13132: -- Attachment: SOLR-13132_testSweep.patch Status: Open (was: Open) bq. ... In fa

[jira] [Commented] (SOLR-14385) Add shard name and collection name to split histogram logs

2020-04-08 Thread Saatchi Bhalla (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078516#comment-17078516 ] Saatchi Bhalla commented on SOLR-14385: --- Hadn't realized that access to MDC variabl

[jira] [Updated] (LUCENE-9310) IntelliJ attempts to resolve provider property in jar manifest configuration and fails during project import

2020-04-08 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9310: Summary: IntelliJ attempts to resolve provider property in jar manifest configuration and fails du

[jira] [Created] (LUCENE-9310) IntelliJ attempts to resolve provider property in jar manifest configuration and fails

2020-04-08 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-9310: --- Summary: IntelliJ attempts to resolve provider property in jar manifest configuration and fails Key: LUCENE-9310 URL: https://issues.apache.org/jira/browse/LUCENE-9310

[jira] [Created] (SOLR-14396) TaggerRequestHandler Should Not Error on Empty Collection

2020-04-08 Thread Trey Grainger (Jira)
Trey Grainger created SOLR-14396: Summary: TaggerRequestHandler Should Not Error on Empty Collection Key: SOLR-14396 URL: https://issues.apache.org/jira/browse/SOLR-14396 Project: Solr Issue

[jira] [Commented] (LUCENE-9310) IntelliJ attempts to resolve provider property in jar manifest configuration and fails during project import

2020-04-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078527#comment-17078527 ] ASF subversion and git services commented on LUCENE-9310: - Commi

[jira] [Commented] (LUCENE-9286) FST arc.copyOf clones BitTables and this can lead to excessive memory use

2020-04-08 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078537#comment-17078537 ] Dawid Weiss commented on LUCENE-9286: - Now... this is a head scratcher. I get this o

[jira] [Commented] (LUCENE-9286) FST arc.copyOf clones BitTables and this can lead to excessive memory use

2020-04-08 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078564#comment-17078564 ] Dawid Weiss commented on LUCENE-9286: - My repro was a test... and I ran with enabled

[jira] [Resolved] (LUCENE-9310) IntelliJ attempts to resolve provider property in jar manifest configuration and fails during project import

2020-04-08 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9310. - Fix Version/s: master (9.0) Resolution: Fixed > IntelliJ attempts to resolve provider pro

[jira] [Created] (LUCENE-9311) IntelliJ import attempts to compile solr-ref-guide tools/ and fails

2020-04-08 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-9311: --- Summary: IntelliJ import attempts to compile solr-ref-guide tools/ and fails Key: LUCENE-9311 URL: https://issues.apache.org/jira/browse/LUCENE-9311 Project: Lucene - C

[jira] [Commented] (SOLR-13132) Improve JSON "terms" facet performance when sorted by relatedness

2020-04-08 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078567#comment-17078567 ] Michael Gibney commented on SOLR-13132: --- This is great, thanks! It's taking me a li

[jira] [Commented] (SOLR-14396) TaggerRequestHandler Should Not Error on Empty Collection

2020-04-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078602#comment-17078602 ] David Smiley commented on SOLR-14396: - Woah; I think it's bad this throws an exceptio

[jira] [Commented] (SOLR-14396) TaggerRequestHandler Should Not Error on Empty Collection

2020-04-08 Thread Trey Grainger (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078620#comment-17078620 ] Trey Grainger commented on SOLR-14396: -- Cool. I'll take a stab at changing the behav

[jira] [Commented] (LUCENE-9271) Make BufferedIndexInput work on a ByteBuffer

2020-04-08 Thread Simon Willnauer (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078627#comment-17078627 ] Simon Willnauer commented on LUCENE-9271: - We ran into a test failure [here|htt

[GitHub] [lucene-solr] s1monw commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-08 Thread GitBox
s1monw commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#issuecomment-611147359 @mikemccand did you run any benchmarks on this change yet? This

[jira] [Commented] (SOLR-11384) add support for distributed graph query

2020-04-08 Thread sambasivarao giddaluri (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078637#comment-17078637 ] sambasivarao giddaluri commented on SOLR-11384: --- [~kwatters]  is it possibl

[jira] [Comment Edited] (SOLR-11384) add support for distributed graph query

2020-04-08 Thread sambasivarao giddaluri (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078637#comment-17078637 ] sambasivarao giddaluri edited comment on SOLR-11384 at 4/8/20, 7:32 PM: ---

[GitHub] [lucene-solr] s1monw opened a new pull request #1418: LUCENE-9309: Wait for #addIndexes merges when aborting merges

2020-04-08 Thread GitBox
s1monw opened a new pull request #1418: LUCENE-9309: Wait for #addIndexes merges when aborting merges URL: https://github.com/apache/lucene-solr/pull/1418 The SegmentMerger usage in IW#addIndexes(CodecReader...) might make changes to the Directory while the IW tries to clean-up files on

[jira] [Commented] (LUCENE-9309) IW#addIndices(CodecReader) might delete files concurrently to IW#rollback

2020-04-08 Thread Simon Willnauer (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078675#comment-17078675 ] Simon Willnauer commented on LUCENE-9309: - [~mikemccand] can you take a look at

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1389: LUCENE-9298: fix clearDeletedDocIds in BufferedUpdates

2020-04-08 Thread GitBox
s1monw commented on a change in pull request #1389: LUCENE-9298: fix clearDeletedDocIds in BufferedUpdates URL: https://github.com/apache/lucene-solr/pull/1389#discussion_r405796843 ## File path: lucene/core/src/java/org/apache/lucene/index/BufferedUpdates.java ## @@ -176,

[GitHub] [lucene-solr] jpountz commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-08 Thread GitBox
jpountz commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#issuecomment-611180446 @mikemccand I think it's related to the change I merged yesterday indeed. I fix it shortly after merging, so if you merge maste

[jira] [Commented] (LUCENE-9271) Make BufferedIndexInput work on a ByteBuffer

2020-04-08 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078688#comment-17078688 ] Adrien Grand commented on LUCENE-9271: -- Sorry about that, it should have been fixed

[jira] [Commented] (LUCENE-9271) Make BufferedIndexInput work on a ByteBuffer

2020-04-08 Thread Simon Willnauer (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078690#comment-17078690 ] Simon Willnauer commented on LUCENE-9271: - thanks [~jpountz] > Make BufferedInd

[GitHub] [lucene-solr] s1monw commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-08 Thread GitBox
s1monw commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#issuecomment-611181862 @mikemccand I merged master into this branch This is an automat

[jira] [Commented] (SOLR-8773) Make blob store usage intuitive and robust

2020-04-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078701#comment-17078701 ] David Smiley commented on SOLR-8773: [~noble.paul] I suppose all this might be Won't-F

[jira] [Commented] (LUCENE-9286) FST arc.copyOf clones BitTables and this can lead to excessive memory use

2020-04-08 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078703#comment-17078703 ] Bruno Roustant commented on LUCENE-9286: Ah ! :) I see the faulty assertion. I'l

[jira] [Commented] (SOLR-12005) Solr should have the option of logging all jars loaded

2020-04-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078704#comment-17078704 ] David Smiley commented on SOLR-12005: - Instead of looking for logging as the tool for

[jira] [Commented] (LUCENE-9286) FST arc.copyOf clones BitTables and this can lead to excessive memory use

2020-04-08 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078707#comment-17078707 ] Bruno Roustant commented on LUCENE-9286: To complete the perf benchmark, I ran l

[jira] [Closed] (LUCENE-4048) Move getLines out of ResourceLoader and require Charset

2020-04-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley closed LUCENE-4048. > Move getLines out of ResourceLoader and require Charset > --

[jira] [Resolved] (LUCENE-4048) Move getLines out of ResourceLoader and require Charset

2020-04-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved LUCENE-4048. -- Fix Version/s: 4.0-BETA Resolution: Duplicate > Move getLines out of ResourceLoader and

[jira] [Created] (SOLR-14397) Vector Search in Solr

2020-04-08 Thread Trey Grainger (Jira)
Trey Grainger created SOLR-14397: Summary: Vector Search in Solr Key: SOLR-14397 URL: https://issues.apache.org/jira/browse/SOLR-14397 Project: Solr Issue Type: Improvement Security Lev

[GitHub] [lucene-solr] madrob commented on issue #1412: Add MinimalSolrTest for scale testing

2020-04-08 Thread GitBox
madrob commented on issue #1412: Add MinimalSolrTest for scale testing URL: https://github.com/apache/lucene-solr/pull/1412#issuecomment-611231598 Would this be better in test-framework as a stub? My goals here are to always have something that I can run against master without needing to re

[jira] [Commented] (LUCENE-9286) FST arc.copyOf clones BitTables and this can lead to excessive memory use

2020-04-08 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078792#comment-17078792 ] Dawid Weiss commented on LUCENE-9286: - +1! > FST arc.copyOf clones BitTables and th

[jira] [Commented] (SOLR-14370) Refactor bin/solr to allow external override of Jetty modules

2020-04-08 Thread Andy Throgmorton (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078806#comment-17078806 ] Andy Throgmorton commented on SOLR-14370: - Sure, I can explain more to solicit al

[GitHub] [lucene-solr] mocobeta merged pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects

2020-04-08 Thread GitBox
mocobeta merged pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects URL: https://github.com/apache/lucene-solr/pull/1388 This is an automated message from the Apache Gi

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-04-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078815#comment-17078815 ] ASF subversion and git services commented on LUCENE-9278: - Commi

[jira] [Commented] (SOLR-12890) Vector Search in Solr (Umbrella Issue)

2020-04-08 Thread Trey Grainger (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078818#comment-17078818 ] Trey Grainger commented on SOLR-12890: -- After reviewing and testing the code in the

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects

2020-04-08 Thread GitBox
mocobeta commented on a change in pull request #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects URL: https://github.com/apache/lucene-solr/pull/1388#discussion_r405878977 ## File path: gradle/render-javadoc.gradle ## @@ -15,93

[GitHub] [lucene-solr] plperron commented on issue #1330: LUCENE-9267 Replace getQueryBuildTime time unit from ms to ns

2020-04-08 Thread GitBox
plperron commented on issue #1330: LUCENE-9267 Replace getQueryBuildTime time unit from ms to ns URL: https://github.com/apache/lucene-solr/pull/1330#issuecomment-611254162 Should I rebase both commits into a single one in order to keep the cohesiveness ? -

[jira] [Updated] (LUCENE-9267) The documentation of getQueryBuildTime function reports a wrong time unit.

2020-04-08 Thread Pierre-Luc Perron (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre-Luc Perron updated LUCENE-9267: -- Attachment: LUCENE-9267.patch > The documentation of getQueryBuildTime function report

[jira] [Updated] (LUCENE-9267) The documentation of getQueryBuildTime function reports a wrong time unit.

2020-04-08 Thread Pierre-Luc Perron (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre-Luc Perron updated LUCENE-9267: -- Attachment: (was: LUCENE-9267.patch) > The documentation of getQueryBuildTime func

[GitHub] [lucene-solr] mayya-sharipova commented on issue #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-04-08 Thread GitBox
mayya-sharipova commented on issue #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#issuecomment-611260306 @romseygeek I have tried to address your outstanding feedback in 4448499f0f. Can you please continue the review w

[GitHub] [lucene-solr] CaoManhDat commented on issue #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP)

2020-04-08 Thread GitBox
CaoManhDat commented on issue #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP) URL: https://github.com/apache/lucene-solr/pull/1395#issuecomment-611274493 Thanks a lot for your hard work @bruno-roustant --

[GitHub] [lucene-solr] dsmiley commented on issue #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP)

2020-04-08 Thread GitBox
dsmiley commented on issue #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP) URL: https://github.com/apache/lucene-solr/pull/1395#issuecomment-611276129 Dat can you move out of the numeric package please ---

[GitHub] [lucene-solr] CaoManhDat commented on issue #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP)

2020-04-08 Thread GitBox
CaoManhDat commented on issue #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP) URL: https://github.com/apache/lucene-solr/pull/1395#issuecomment-611288608 @dsmiley Done!

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data

2020-04-08 Thread GitBox
noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r405920137 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ZkRead.java ## @@ -0,0 +1,117

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data

2020-04-08 Thread GitBox
noblepaul commented on a change in pull request #1327: SOLR-13942: /api/cluster/zk/* to fetch raw ZK data URL: https://github.com/apache/lucene-solr/pull/1327#discussion_r405920325 ## File path: solr/core/src/test/org/apache/solr/handler/admin/ZookeeperStatusHandlerTest.java #

  1   2   >