bruno-roustant commented on a change in pull request #1395: SOLR-14365: CollapsingQParser - Avoiding always allocate int[] and float[] with size equals to number of unique values (WIP) URL: https://github.com/apache/lucene-solr/pull/1395#discussion_r405406935
########## File path: solr/core/src/java/org/apache/solr/util/numeric/IntFloatDynamicMap.java ########## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.util.numeric; + +import java.util.Arrays; + +import com.carrotsearch.hppc.IntFloatHashMap; +import com.carrotsearch.hppc.cursors.FloatCursor; +import com.carrotsearch.hppc.procedures.IntFloatProcedure; +import org.apache.lucene.util.ArrayUtil; + +public class IntFloatDynamicMap implements DynamicMap { + private int maxSize; + private IntFloatHashMap hashMap; + private float[] keyValues; + private float emptyValue; + private int threshold; + + /** + * Create map with expected max value of key. + * Although the map will automatically do resizing to be able to hold key >= {@code expectedKeyMax}. + * But putting key much larger than {@code expectedKeyMax} is discourage since it can leads to use LOT OF memory. Review comment: We can be explicit and say: more than key x 4B, so for a max key 100M it may allocate more than 400 MB. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
