[GitHub] [lucene-solr] atris opened a new pull request #1303: LUCENE-9114: Improve ValueSourceScorer's Default Cost Implementation

2020-03-01 Thread GitBox
atris opened a new pull request #1303: LUCENE-9114: Improve ValueSourceScorer's Default Cost Implementation URL: https://github.com/apache/lucene-solr/pull/1303 This commit makes ValueSourceScorer's costing algorithm to also take the delegated FunctionValues's cost into consideration when

[jira] [Commented] (LUCENE-9114) Add FunctionValues.cost

2020-03-01 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17048492#comment-17048492 ] Atri Sharma commented on LUCENE-9114: - [~dsmiley] I have raised a PR for the same --

[jira] [Assigned] (LUCENE-9114) Add FunctionValues.cost

2020-03-01 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma reassigned LUCENE-9114: --- Assignee: Atri Sharma > Add FunctionValues.cost > --- > >

[GitHub] [lucene-solr] iverase commented on a change in pull request #1253: LUCENE-9150: Restore support for dynamic PlanetModel in spatial3d

2020-03-01 Thread GitBox
iverase commented on a change in pull request #1253: LUCENE-9150: Restore support for dynamic PlanetModel in spatial3d URL: https://github.com/apache/lucene-solr/pull/1253#discussion_r386092274 ## File path: lucene/spatial3d/src/java/org/apache/lucene/spatial3d/geom/PlanetModel.jav

[GitHub] [lucene-solr] irvingzhang edited a comment on issue #1295: Lucene-9004: bug fix for searching the nearest one neighbor in higher layers

2020-03-01 Thread GitBox
irvingzhang edited a comment on issue #1295: Lucene-9004: bug fix for searching the nearest one neighbor in higher layers URL: https://github.com/apache/lucene-solr/pull/1295#issuecomment-592287771 > I believe in practice that results. max size is always set to ef, so there shouldn't be an

[jira] [Commented] (SOLR-13411) CompositeIdRouter calculates wrong route hash if atomic update is used for route.field

2020-03-01 Thread Dr Oleg Savrasov (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17048541#comment-17048541 ] Dr Oleg Savrasov commented on SOLR-13411: - [~mkhl] , [~dsmiley] Thank you, guys.

[jira] [Comment Edited] (SOLR-14291) OldAnalyticsRequestConverter should support fields names with dots

2020-03-01 Thread Anatolii Siuniaev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17048251#comment-17048251 ] Anatolii Siuniaev edited comment on SOLR-14291 at 3/1/20 1:15 PM: -

[GitHub] [lucene-solr] msokolov commented on issue #1295: Lucene-9004: bug fix for searching the nearest one neighbor in higher layers

2020-03-01 Thread GitBox
msokolov commented on issue #1295: Lucene-9004: bug fix for searching the nearest one neighbor in higher layers URL: https://github.com/apache/lucene-solr/pull/1295#issuecomment-593096201 Ah, I see you're right @irvingzhang . I think we could also save something by eliminating the priority

[GitHub] [lucene-solr] msokolov merged pull request #1295: Lucene-9004: bug fix for searching the nearest one neighbor in higher layers

2020-03-01 Thread GitBox
msokolov merged pull request #1295: Lucene-9004: bug fix for searching the nearest one neighbor in higher layers URL: https://github.com/apache/lucene-solr/pull/1295 This is an automated message from the Apache Git Service.

[jira] [Updated] (SOLR-14291) OldAnalyticsRequestConverter should support fields names with dots

2020-03-01 Thread Anatolii Siuniaev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anatolii Siuniaev updated SOLR-14291: - Description: If you send a query with range facets using old olap-style syntax DMV(see pd

[GitHub] [lucene-solr] msokolov commented on a change in pull request #1296: LUCENE-9253: Support custom dictionaries in KoreanTokenizer

2020-03-01 Thread GitBox
msokolov commented on a change in pull request #1296: LUCENE-9253: Support custom dictionaries in KoreanTokenizer URL: https://github.com/apache/lucene-solr/pull/1296#discussion_r386107769 ## File path: lucene/analysis/nori/src/java/org/apache/lucene/analysis/ko/KoreanTokenizer.jav

[GitHub] [lucene-solr] msokolov commented on a change in pull request #1296: LUCENE-9253: Support custom dictionaries in KoreanTokenizer

2020-03-01 Thread GitBox
msokolov commented on a change in pull request #1296: LUCENE-9253: Support custom dictionaries in KoreanTokenizer URL: https://github.com/apache/lucene-solr/pull/1296#discussion_r386108024 ## File path: lucene/analysis/nori/src/java/org/apache/lucene/analysis/ko/dict/BinaryDictiona

[GitHub] [lucene-solr] msokolov commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-03-01 Thread GitBox
msokolov commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r386109193 ## File path: lucene/core/src/java/org/apache/lucene/search/SliceExecutionControlPlan

[GitHub] [lucene-solr] msokolov commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-03-01 Thread GitBox
msokolov commented on a change in pull request #1294: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r386109250 ## File path: lucene/core/src/java/org/apache/lucene/search/SliceExecutionControlPlan

[GitHub] [lucene-solr] dsmiley commented on issue #1303: LUCENE-9114: Improve ValueSourceScorer's Default Cost Implementation

2020-03-01 Thread GitBox
dsmiley commented on issue #1303: LUCENE-9114: Improve ValueSourceScorer's Default Cost Implementation URL: https://github.com/apache/lucene-solr/pull/1303#issuecomment-593116806 Wouldn't this result in an infinite loop? This

[GitHub] [lucene-solr] danmuzi commented on a change in pull request #1296: LUCENE-9253: Support custom dictionaries in KoreanTokenizer

2020-03-01 Thread GitBox
danmuzi commented on a change in pull request #1296: LUCENE-9253: Support custom dictionaries in KoreanTokenizer URL: https://github.com/apache/lucene-solr/pull/1296#discussion_r386122678 ## File path: lucene/analysis/nori/src/java/org/apache/lucene/analysis/ko/KoreanTokenizer.java

[GitHub] [lucene-solr] danmuzi commented on a change in pull request #1296: LUCENE-9253: Support custom dictionaries in KoreanTokenizer

2020-03-01 Thread GitBox
danmuzi commented on a change in pull request #1296: LUCENE-9253: Support custom dictionaries in KoreanTokenizer URL: https://github.com/apache/lucene-solr/pull/1296#discussion_r386122724 ## File path: lucene/analysis/nori/src/java/org/apache/lucene/analysis/ko/dict/BinaryDictionar

[GitHub] [lucene-solr] danmuzi commented on issue #1296: LUCENE-9253: Support custom dictionaries in KoreanTokenizer

2020-03-01 Thread GitBox
danmuzi commented on issue #1296: LUCENE-9253: Support custom dictionaries in KoreanTokenizer URL: https://github.com/apache/lucene-solr/pull/1296#issuecomment-593120577 Thanks for your review! @msokolov I changed some upper cases in Javadoc. And I added a change log for this patc

[GitHub] [lucene-solr] atris commented on issue #1303: LUCENE-9114: Improve ValueSourceScorer's Default Cost Implementation

2020-03-01 Thread GitBox
atris commented on issue #1303: LUCENE-9114: Improve ValueSourceScorer's Default Cost Implementation URL: https://github.com/apache/lucene-solr/pull/1303#issuecomment-593126930 > Wouldn't this result in an infinite loop? The idea was that the underlying TwoPhaseIterator implementatio

[GitHub] [lucene-solr] atris commented on issue #1303: LUCENE-9114: Improve ValueSourceScorer's Default Cost Implementation

2020-03-01 Thread GitBox
atris commented on issue #1303: LUCENE-9114: Improve ValueSourceScorer's Default Cost Implementation URL: https://github.com/apache/lucene-solr/pull/1303#issuecomment-593133186 @dsmiley Thinking further, I see no obvious way of ValueSourceScorer being able to determine a reasonable cost wi

[GitHub] [lucene-solr] atris edited a comment on issue #1303: LUCENE-9114: Improve ValueSourceScorer's Default Cost Implementation

2020-03-01 Thread GitBox
atris edited a comment on issue #1303: LUCENE-9114: Improve ValueSourceScorer's Default Cost Implementation URL: https://github.com/apache/lucene-solr/pull/1303#issuecomment-593133186 @dsmiley Thinking further, I see no obvious way of ValueSourceScorer being able to determine a reasonable

[GitHub] [lucene-solr] atris edited a comment on issue #1303: LUCENE-9114: Improve ValueSourceScorer's Default Cost Implementation

2020-03-01 Thread GitBox
atris edited a comment on issue #1303: LUCENE-9114: Improve ValueSourceScorer's Default Cost Implementation URL: https://github.com/apache/lucene-solr/pull/1303#issuecomment-593133186 @dsmiley Thinking further, I see no obvious way of ValueSourceScorer being able to determine a reasonable

[GitHub] [lucene-solr] mocobeta opened a new pull request #1304: LUCENE-9242: generate javadocs by calling Ant javadoc task

2020-03-01 Thread GitBox
mocobeta opened a new pull request #1304: LUCENE-9242: generate javadocs by calling Ant javadoc task URL: https://github.com/apache/lucene-solr/pull/1304 ## Description Draft PR that adds a gradle task to generate javadocs by invoking Ant javadoc task. All generated javadocs are

[jira] [Commented] (LUCENE-9255) ValueSource Has Generic Typing Issues

2020-03-01 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17048670#comment-17048670 ] Alan Woodward commented on LUCENE-9255: --- Ideally we'd deprecate ValueSource and re

[GitHub] [lucene-solr] dsmiley commented on issue #1303: LUCENE-9114: Improve ValueSourceScorer's Default Cost Implementation

2020-03-01 Thread GitBox
dsmiley commented on issue #1303: LUCENE-9114: Improve ValueSourceScorer's Default Cost Implementation URL: https://github.com/apache/lucene-solr/pull/1303#issuecomment-593151099 Lets add the following test to TestFunctionRangeQuery: ``` @Test public void testTwoRangeQueries()

[jira] [Commented] (LUCENE-9242) Gradle Javadoc task should output the same documents as Ant

2020-03-01 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17048696#comment-17048696 ] Tomoko Uchida commented on LUCENE-9242: --- I opened a draft PR [https://github.com/a

[jira] [Comment Edited] (LUCENE-9242) Gradle Javadoc task should output the same documents as Ant

2020-03-01 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17048696#comment-17048696 ] Tomoko Uchida edited comment on LUCENE-9242 at 3/1/20 10:37 PM: --

[jira] [Comment Edited] (LUCENE-9242) Gradle Javadoc task should output the same documents as Ant

2020-03-01 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17048696#comment-17048696 ] Tomoko Uchida edited comment on LUCENE-9242 at 3/1/20 10:38 PM: --

[jira] [Commented] (LUCENE-9242) Gradle Javadoc task should output the same documents as Ant

2020-03-01 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17048702#comment-17048702 ] Tomoko Uchida commented on LUCENE-9242: --- [~dweiss] [~rcmuir] Could you take a look

[GitHub] [lucene-solr] mocobeta commented on issue #1304: LUCENE-9242: generate javadocs by calling Ant javadoc task

2020-03-01 Thread GitBox
mocobeta commented on issue #1304: LUCENE-9242: generate javadocs by calling Ant javadoc task URL: https://github.com/apache/lucene-solr/pull/1304#issuecomment-593160403 To confirm if the inter-module links are correctly generated, the "broken links check" task will be of help for us (it i

[jira] [Commented] (SOLR-13502) Investigate using something other than ZooKeeper's "4 letter words" for the admin UI status

2020-03-01 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17048789#comment-17048789 ] Erick Erickson commented on SOLR-13502: --- Hmmm, according to the ZK docs, the admin

[jira] [Commented] (LUCENE-9243) TestXYPointDistanceSort failure: point was within the distance , but the bbox doesn't contain it

2020-03-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17048805#comment-17048805 ] ASF subversion and git services commented on LUCENE-9243: - Commi

[GitHub] [lucene-solr] iverase merged pull request #1278: LUCENE-9243: Add fudge factor when creating a bounding box of a xycircle

2020-03-01 Thread GitBox
iverase merged pull request #1278: LUCENE-9243: Add fudge factor when creating a bounding box of a xycircle URL: https://github.com/apache/lucene-solr/pull/1278 This is an automated message from the Apache Git Service. To re

[jira] [Commented] (LUCENE-9243) TestXYPointDistanceSort failure: point was within the distance , but the bbox doesn't contain it

2020-03-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17048807#comment-17048807 ] ASF subversion and git services commented on LUCENE-9243: - Commi

[jira] [Resolved] (LUCENE-9243) TestXYPointDistanceSort failure: point was within the distance , but the bbox doesn't contain it

2020-03-01 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera resolved LUCENE-9243. -- Fix Version/s: 8.5 Assignee: Ignacio Vera Resolution: Fixed > TestXYPointDista

[jira] [Updated] (LUCENE-9136) Introduce IVFFlat to Lucene for ANN similarity search

2020-03-01 Thread Xin-Chun Zhang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xin-Chun Zhang updated LUCENE-9136: --- Description: Representation learning (RL) has been an established discipline in the machine

[jira] [Updated] (LUCENE-9136) Introduce IVFFlat to Lucene for ANN similarity search

2020-03-01 Thread Xin-Chun Zhang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xin-Chun Zhang updated LUCENE-9136: --- Description: Representation learning (RL) has been an established discipline in the machine

[jira] [Commented] (SOLR-13411) CompositeIdRouter calculates wrong route hash if atomic update is used for route.field

2020-03-01 Thread Niko Himanen (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17048825#comment-17048825 ] Niko Himanen commented on SOLR-13411: - Thank you for fixing thisĀ (y) > CompositeIdRo

[jira] [Commented] (SOLR-7796) Implement a "gather support info" button

2020-03-01 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17048841#comment-17048841 ] Andrzej Bialecki commented on SOLR-7796: Please take a look at {{SolrCLI.Autoscali

[jira] [Comment Edited] (SOLR-7796) Implement a "gather support info" button

2020-03-01 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17048841#comment-17048841 ] Andrzej Bialecki edited comment on SOLR-7796 at 3/2/20 7:28 AM: