[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-9201:
Attachment: LUCENE-9201.patch
> Port documentation-lint task to Gradle build
> ---
dweiss commented on issue #1267: LUCENE-9201: Add missing javadocs check task
URL: https://github.com/apache/lucene-solr/pull/1267#issuecomment-590050376
Hi Tomoko. I uploaded a cleaned up patch to jira - please take a look. I'll
also add some comments on this pull request so that you know
dweiss commented on a change in pull request #1267: LUCENE-9201: Add missing
javadocs check task
URL: https://github.com/apache/lucene-solr/pull/1267#discussion_r382988664
##
File path: gradle/validation/missing-docs-check.gradle
##
@@ -0,0 +1,118 @@
+/*
+ * Licensed to th
dweiss commented on a change in pull request #1267: LUCENE-9201: Add missing
javadocs check task
URL: https://github.com/apache/lucene-solr/pull/1267#discussion_r382988443
##
File path: gradle/validation/missing-docs-check.gradle
##
@@ -0,0 +1,118 @@
+/*
+ * Licensed to th
dweiss commented on a change in pull request #1267: LUCENE-9201: Add missing
javadocs check task
URL: https://github.com/apache/lucene-solr/pull/1267#discussion_r382988576
##
File path: gradle/validation/missing-docs-check.gradle
##
@@ -0,0 +1,118 @@
+/*
+ * Licensed to th
dweiss commented on a change in pull request #1267: LUCENE-9201: Add missing
javadocs check task
URL: https://github.com/apache/lucene-solr/pull/1267#discussion_r382988638
##
File path: gradle/validation/missing-docs-check.gradle
##
@@ -0,0 +1,118 @@
+/*
+ * Licensed to th
dweiss commented on a change in pull request #1267: LUCENE-9201: Add missing
javadocs check task
URL: https://github.com/apache/lucene-solr/pull/1267#discussion_r382988460
##
File path: gradle/validation/missing-docs-check.gradle
##
@@ -0,0 +1,118 @@
+/*
+ * Licensed to th
dweiss commented on a change in pull request #1267: LUCENE-9201: Add missing
javadocs check task
URL: https://github.com/apache/lucene-solr/pull/1267#discussion_r382988556
##
File path: gradle/validation/missing-docs-check.gradle
##
@@ -0,0 +1,118 @@
+/*
+ * Licensed to th
[
https://issues.apache.org/jira/browse/LUCENE-9240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042867#comment-17042867
]
Dawid Weiss commented on LUCENE-9240:
-
Perhaps I should also clarify that ideally we
[
https://issues.apache.org/jira/browse/LUCENE-9241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042871#comment-17042871
]
Dawid Weiss commented on LUCENE-9241:
-
Nightlies would still require a larger heap (
[
https://issues.apache.org/jira/browse/LUCENE-9241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042885#comment-17042885
]
Robert Muir commented on LUCENE-9241:
-
{quote}
the URL based version causes jar to b
[
https://issues.apache.org/jira/browse/LUCENE-9241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042888#comment-17042888
]
Dawid Weiss commented on LUCENE-9241:
-
Not true... anymore. Because I definitely str
[
https://issues.apache.org/jira/browse/LUCENE-9241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042892#comment-17042892
]
Dawid Weiss commented on LUCENE-9241:
-
It is actually (and sadly) still true. You're
[
https://issues.apache.org/jira/browse/LUCENE-9241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042893#comment-17042893
]
Dawid Weiss commented on LUCENE-9241:
-
I remember now. When you're using a dynamic c
[
https://issues.apache.org/jira/browse/LUCENE-9241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042896#comment-17042896
]
Robert Muir commented on LUCENE-9241:
-
This isn't a URLClassloader here. The standar
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042900#comment-17042900
]
Tomoko Uchida commented on LUCENE-9201:
---
[~dweiss] I did some tests with the patch
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042900#comment-17042900
]
Tomoko Uchida edited comment on LUCENE-9201 at 2/23/20 11:11 AM:
-
mocobeta commented on issue #1267: LUCENE-9201: Add missing javadocs check task
URL: https://github.com/apache/lucene-solr/pull/1267#issuecomment-590057882
@dweiss thanks for your comments and the refined patch. I did some tests
with the patch and added a comment to JIRA. Maybe we should cl
[
https://issues.apache.org/jira/browse/LUCENE-9240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042932#comment-17042932
]
Erick Erickson commented on LUCENE-9240:
WDYT about making "gw helpant" print ou
[
https://issues.apache.org/jira/browse/LUCENE-9240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042942#comment-17042942
]
ASF subversion and git services commented on LUCENE-9240:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042943#comment-17042943
]
Dawid Weiss commented on LUCENE-9201:
-
Sure, the filter is fine. Could be ".collect
[
https://issues.apache.org/jira/browse/LUCENE-9241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042949#comment-17042949
]
Dawid Weiss commented on LUCENE-9241:
-
I'm really indifferent about it - I was just
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida updated LUCENE-9201:
--
Attachment: LUCENE-9201-missing-docs.patch
> Port documentation-lint task to Gradle build
> --
[
https://issues.apache.org/jira/browse/LUCENE-9241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042960#comment-17042960
]
Robert Muir commented on LUCENE-9241:
-
Dawid, if you think Class.getResource has som
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042976#comment-17042976
]
Tomoko Uchida commented on LUCENE-9201:
---
I attachedĀ [^LUCENE-9201-missing-docs.pa
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17043068#comment-17043068
]
Dawid Weiss commented on LUCENE-9201:
-
Sorry, Tomoko - you are right about collect.
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17043128#comment-17043128
]
ASF subversion and git services commented on LUCENE-9201:
-
Commi
Tomoko Uchida created LUCENE-9242:
-
Summary: Gradle Javadoc task does not include package summaries
Key: LUCENE-9242
URL: https://issues.apache.org/jira/browse/LUCENE-9242
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-9201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17043140#comment-17043140
]
Tomoko Uchida commented on LUCENE-9201:
---
I just merged [^LUCENE-9201-missing-docs.
mocobeta closed pull request #1267: LUCENE-9201: Add missing javadocs check task
URL: https://github.com/apache/lucene-solr/pull/1267
This is an automated message from the Apache Git Service.
To respond to the message, please
mocobeta commented on issue #1267: LUCENE-9201: Add missing javadocs check task
URL: https://github.com/apache/lucene-solr/pull/1267#issuecomment-590154751
I will close this. Thank you @dweiss for your review comments here!
Th
Ignacio Vera created LUCENE-9243:
Summary: TestXYPointDistanceSort failure: point was within the
distance , but the bbox doesn't contain it
Key: LUCENE-9243
URL: https://issues.apache.org/jira/browse/LUCENE-9243
[
https://issues.apache.org/jira/browse/LUCENE-9243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17043175#comment-17043175
]
Ignacio Vera commented on LUCENE-9243:
--
Reproduce:
{code:java}
ant test -Dtestcase
iverase opened a new pull request #1278: LUCENE-9243: Add fudge factor when
creating a bounding box of a xycircle
URL: https://github.com/apache/lucene-solr/pull/1278
We need increase slightly the bounding box of a `XYCircle` to prevent
points at the provided distance to be outside of the
Ignacio Vera created LUCENE-9244:
Summary: TestLucene60PointsFormat#testEstimatePointCount2Dims
failure
Key: LUCENE-9244
URL: https://issues.apache.org/jira/browse/LUCENE-9244
Project: Lucene - Core
35 matches
Mail list logo