[ 
https://issues.apache.org/jira/browse/LUCENE-9241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042885#comment-17042885
 ] 

Robert Muir commented on LUCENE-9241:
-------------------------------------

{quote}
the URL based version causes jar to be locked on Windows (if I recall right). I 
don't see the benefit of switching to URL here?
{quote}

Not true.

the existing getResourceAsStream is simply getResource + openStream. this way 
the exc handling is simpler.

Look here: 
https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/ClassLoader.java#L1723-L1731

(Sorry, I have to call such things out, lest we have shitty code based on 
rumors or other wrong reasons)

> fix most memory-hungry tests
> ----------------------------
>
>                 Key: LUCENE-9241
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9241
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Robert Muir
>            Priority: Major
>         Attachments: LUCENE-9241.patch
>
>
> Currently each test jvm has Xmx of 512M. With a modern macbook pro this is 
> 4GB which is pretty crazy.
> On the other hand, if we fix a few edge cases, tests can work with lower 
> heaps such as 128M. This can save many gigabytes (also it finds interesting 
> memory waste/issues).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to