[jira] [Commented] (LUCENE-9224) (ant) RAT report complains about ... solr/webapp rat-report.xml (from gradle)

2020-02-14 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036777#comment-17036777 ] Dawid Weiss commented on LUCENE-9224: - Thanks for digging, Erick. Chris - maintainin

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

2020-02-14 Thread GitBox
jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379307116 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java #

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

2020-02-14 Thread GitBox
jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379306326 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesProducer.java #

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

2020-02-14 Thread GitBox
jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379297803 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java #

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

2020-02-14 Thread GitBox
jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379305128 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesProducer.java #

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

2020-02-14 Thread GitBox
jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379299380 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java #

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

2020-02-14 Thread GitBox
jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379306909 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java #

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

2020-02-14 Thread GitBox
jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379298761 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java #

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

2020-02-14 Thread GitBox
jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379298212 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java #

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

2020-02-14 Thread GitBox
jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379304369 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesProducer.java #

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

2020-02-14 Thread GitBox
jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379304074 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesProducer.java #

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

2020-02-14 Thread GitBox
jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379295432 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java #

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

2020-02-14 Thread GitBox
jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379294799 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java #

[jira] [Commented] (LUCENE-9211) Adding compression to BinaryDocValues storage

2020-02-14 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036806#comment-17036806 ] Adrien Grand commented on LUCENE-9211: -- I had a quick look at Juan's commit, there

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1252: LUCENE-9218: XYGeometries should expose values as floats

2020-02-14 Thread GitBox
jpountz commented on a change in pull request #1252: LUCENE-9218: XYGeometries should expose values as floats URL: https://github.com/apache/lucene-solr/pull/1252#discussion_r379314365 ## File path: lucene/core/src/java/org/apache/lucene/geo/XYEncodingUtils.java ## @@ -33,

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1252: LUCENE-9218: XYGeometries should expose values as floats

2020-02-14 Thread GitBox
jpountz commented on a change in pull request #1252: LUCENE-9218: XYGeometries should expose values as floats URL: https://github.com/apache/lucene-solr/pull/1252#discussion_r379314539 ## File path: lucene/core/src/java/org/apache/lucene/geo/XYEncodingUtils.java ## @@ -68,

[GitHub] [lucene-solr] jpountz commented on a change in pull request #587: LUCENE-8707: Add LatLonShape and XYShape distance query

2020-02-14 Thread GitBox
jpountz commented on a change in pull request #587: LUCENE-8707: Add LatLonShape and XYShape distance query URL: https://github.com/apache/lucene-solr/pull/587#discussion_r379317415 ## File path: lucene/core/src/java/org/apache/lucene/geo/Circle2D.java ## @@ -0,0 +1,463 @@

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-02-14 Thread GitBox
jpountz commented on a change in pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1214#discussion_r379320286 ## File path: lucene/core/src/java/org/apache/lucene/search/DefaultExecutionControlPla

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-02-14 Thread GitBox
jpountz commented on a change in pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1214#discussion_r379322585 ## File path: lucene/core/src/java/org/apache/lucene/search/SliceExecutionControlPlane

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-02-14 Thread GitBox
jpountz commented on a change in pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1214#discussion_r379320715 ## File path: lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java ###

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-02-14 Thread GitBox
jpountz commented on a change in pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1214#discussion_r379318977 ## File path: lucene/test-framework/src/java/org/apache/lucene/util/LuceneTestCase.jav

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches

2020-02-14 Thread GitBox
jpountz commented on a change in pull request #1214: LUCENE-9074: Slice Allocation Control Plane For Concurrent Searches URL: https://github.com/apache/lucene-solr/pull/1214#discussion_r379320355 ## File path: lucene/core/src/java/org/apache/lucene/search/DefaultExecutionControlPla

[jira] [Resolved] (LUCENE-8762) Lucene50PostingsReader should specialize reading docs+freqs with impacts

2020-02-14 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8762. -- Resolution: Won't Fix This has been implemented in the new Lucene84PostingsFormat. > Lucene50

[GitHub] [lucene-solr] jpountz merged pull request #1236: Add back assertions removed by LUCENE-9187.

2020-02-14 Thread GitBox
jpountz merged pull request #1236: Add back assertions removed by LUCENE-9187. URL: https://github.com/apache/lucene-solr/pull/1236 This is an automated message from the Apache Git Service. To respond to the message, please l

[jira] [Commented] (LUCENE-9187) remove too-expensive assert from LZ4 HighCompressionHashTable

2020-02-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036845#comment-17036845 ] ASF subversion and git services commented on LUCENE-9187: - Commi

[jira] [Commented] (LUCENE-9203) Make DocValuesIterator public

2020-02-14 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036878#comment-17036878 ] Adrien Grand commented on LUCENE-9203: -- Yes indeed, I remember another instance of

[jira] [Commented] (LUCENE-9218) XYGeometries should use floats instead of doubles

2020-02-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036893#comment-17036893 ] ASF subversion and git services commented on LUCENE-9218: - Commi

[GitHub] [lucene-solr] iverase merged pull request #1252: LUCENE-9218: XYGeometries should expose values as floats

2020-02-14 Thread GitBox
iverase merged pull request #1252: LUCENE-9218: XYGeometries should expose values as floats URL: https://github.com/apache/lucene-solr/pull/1252 This is an automated message from the Apache Git Service. To respond to the mes

[jira] [Commented] (LUCENE-9218) XYGeometries should use floats instead of doubles

2020-02-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036895#comment-17036895 ] ASF subversion and git services commented on LUCENE-9218: - Commi

[GitHub] [lucene-solr] iverase closed pull request #1249: LUCENE-9217: Add validation to XYGeometries

2020-02-14 Thread GitBox
iverase closed pull request #1249: LUCENE-9217: Add validation to XYGeometries URL: https://github.com/apache/lucene-solr/pull/1249 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [lucene-solr] iverase commented on issue #1249: LUCENE-9217: Add validation to XYGeometries

2020-02-14 Thread GitBox
iverase commented on issue #1249: LUCENE-9217: Add validation to XYGeometries URL: https://github.com/apache/lucene-solr/pull/1249#issuecomment-586204933 fixed in #1252 This is an automated message from the Apache Git Service

[jira] [Resolved] (LUCENE-9218) XYGeometries should use floats instead of doubles

2020-02-14 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera resolved LUCENE-9218. -- Fix Version/s: 8.5 Assignee: Ignacio Vera Resolution: Fixed > XYGeometries sho

[jira] [Resolved] (LUCENE-9217) Add validation for XYGeometries

2020-02-14 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera resolved LUCENE-9217. -- Assignee: Ignacio Vera Resolution: Won't Fix resolve in LUCENE-9218 > Add validation fo

[jira] [Comment Edited] (LUCENE-9217) Add validation for XYGeometries

2020-02-14 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036898#comment-17036898 ] Ignacio Vera edited comment on LUCENE-9217 at 2/14/20 10:44 AM: --

[jira] [Created] (LUCENE-9225) Rectangle should extend LatLonGeometry

2020-02-14 Thread Ignacio Vera (Jira)
Ignacio Vera created LUCENE-9225: Summary: Rectangle should extend LatLonGeometry Key: LUCENE-9225 URL: https://issues.apache.org/jira/browse/LUCENE-9225 Project: Lucene - Core Issue Type: Im

[GitHub] [lucene-solr] iverase opened a new pull request #1258: LUCENE-9225: Rectangle should extend LatLonGeometry

2020-02-14 Thread GitBox
iverase opened a new pull request #1258: LUCENE-9225: Rectangle should extend LatLonGeometry URL: https://github.com/apache/lucene-solr/pull/1258 Rectangle now extends LatLonGeometry so it can be used as part of a geometry collection. We need to be careful for Contains and we need to split

[GitHub] [lucene-solr] andywebb1975 commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE

2020-02-14 Thread GitBox
andywebb1975 commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE URL: https://github.com/apache/lucene-solr/pull/1247#discussion_r379397661 ## File path: solr/core/src/java/org/apache/solr/metrics/AggregateMetric.java ## @@ -9

[GitHub] [lucene-solr] andywebb1975 commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE

2020-02-14 Thread GitBox
andywebb1975 commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE URL: https://github.com/apache/lucene-solr/pull/1247#discussion_r379398056 ## File path: solr/core/src/java/org/apache/solr/metrics/AggregateMetric.java ## @@ -5

[GitHub] [lucene-solr] andywebb1975 commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE

2020-02-14 Thread GitBox
andywebb1975 commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE URL: https://github.com/apache/lucene-solr/pull/1247#discussion_r379399436 ## File path: solr/core/src/java/org/apache/solr/metrics/AggregateMetric.java ## @@ -5

[GitHub] [lucene-solr] andywebb1975 commented on issue #1247: SOLR-14252 use double rather than Double to avoid NPE

2020-02-14 Thread GitBox
andywebb1975 commented on issue #1247: SOLR-14252 use double rather than Double to avoid NPE URL: https://github.com/apache/lucene-solr/pull/1247#issuecomment-586263732 Note it's reporter config like the below that triggers the exceptions - the cache metrics include `LocalStatsCache` value

[jira] [Commented] (LUCENE-9187) remove too-expensive assert from LZ4 HighCompressionHashTable

2020-02-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036954#comment-17036954 ] ASF subversion and git services commented on LUCENE-9187: - Commi

[jira] [Commented] (LUCENE-9187) remove too-expensive assert from LZ4 HighCompressionHashTable

2020-02-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036955#comment-17036955 ] ASF subversion and git services commented on LUCENE-9187: - Commi

[GitHub] [lucene-solr] iverase commented on a change in pull request #587: LUCENE-8707: Add LatLonShape and XYShape distance query

2020-02-14 Thread GitBox
iverase commented on a change in pull request #587: LUCENE-8707: Add LatLonShape and XYShape distance query URL: https://github.com/apache/lucene-solr/pull/587#discussion_r379411676 ## File path: lucene/core/src/java/org/apache/lucene/geo/Circle2D.java ## @@ -0,0 +1,463 @@

[GitHub] [lucene-solr] alessandrobenedetti commented on issue #357: [SOLR-12238] Synonym Queries boost

2020-02-14 Thread GitBox
alessandrobenedetti commented on issue #357: [SOLR-12238] Synonym Queries boost URL: https://github.com/apache/lucene-solr/pull/357#issuecomment-586284506 As I was writing the blog I thought that the Lucene changes would automatically bring the same feature to Elasticsearch, but then I kind

[jira] [Updated] (SOLR-10306) Document vm.swappiness and swapoff in RefGuide

2020-02-14 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-10306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-10306: --- Summary: Document vm.swappiness and swapoff in RefGuide (was: Document vm.swappiness and mlockall in

[GitHub] [lucene-solr] janhoy commented on issue #1256: SOLR-10306: Document in Reference Guide how to disable or reduce swapping

2020-02-14 Thread GitBox
janhoy commented on issue #1256: SOLR-10306: Document in Reference Guide how to disable or reduce swapping URL: https://github.com/apache/lucene-solr/pull/1256#issuecomment-586303086 Done some changes. There is probably some sub-par language as well, don't be afraid to shoot me down :) -

[GitHub] [lucene-solr] markharwood commented on a change in pull request #1234: Add compression for Binary doc value fields

2020-02-14 Thread GitBox
markharwood commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379463440 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesProducer.java #

[GitHub] [lucene-solr] markharwood commented on a change in pull request #1234: Add compression for Binary doc value fields

2020-02-14 Thread GitBox
markharwood commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379463675 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesProducer.java #

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields

2020-02-14 Thread GitBox
jpountz commented on a change in pull request #1234: Add compression for Binary doc value fields URL: https://github.com/apache/lucene-solr/pull/1234#discussion_r379473860 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesProducer.java #

[jira] [Created] (LUCENE-9226) Point2D#relateTriangle bug

2020-02-14 Thread Ignacio Vera (Jira)
Ignacio Vera created LUCENE-9226: Summary: Point2D#relateTriangle bug Key: LUCENE-9226 URL: https://issues.apache.org/jira/browse/LUCENE-9226 Project: Lucene - Core Issue Type: Bug

[GitHub] [lucene-solr] iverase opened a new pull request #1259: LUCENE-9226: Return CELL_CROSSES_QUERY when point inside the triangle

2020-02-14 Thread GitBox
iverase opened a new pull request #1259: LUCENE-9226: Return CELL_CROSSES_QUERY when point inside the triangle URL: https://github.com/apache/lucene-solr/pull/1259 return the right relation when point side a triangle. This is

[jira] [Commented] (LUCENE-8321) Allow composite readers to have more than 2B documents

2020-02-14 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037035#comment-17037035 ] Erick Erickson commented on LUCENE-8321: Part of the rabbit hole would be the nu

[jira] [Commented] (LUCENE-9224) (ant) RAT report complains about ... solr/webapp rat-report.xml (from gradle)

2020-02-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037070#comment-17037070 ] ASF subversion and git services commented on LUCENE-9224: - Commi

[jira] [Resolved] (LUCENE-9224) (ant) RAT report complains about ... solr/webapp rat-report.xml (from gradle)

2020-02-14 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved LUCENE-9224. Fix Version/s: master (9.0) Resolution: Fixed Pushed a fix just to reduce friction.

[GitHub] [lucene-solr] iverase merged pull request #1259: LUCENE-9226: Return CELL_CROSSES_QUERY when point inside the triangle

2020-02-14 Thread GitBox
iverase merged pull request #1259: LUCENE-9226: Return CELL_CROSSES_QUERY when point inside the triangle URL: https://github.com/apache/lucene-solr/pull/1259 This is an automated message from the Apache Git Service. To respo

[GitHub] [lucene-solr] iverase commented on issue #1259: LUCENE-9226: Return CELL_CROSSES_QUERY when point inside the triangle

2020-02-14 Thread GitBox
iverase commented on issue #1259: LUCENE-9226: Return CELL_CROSSES_QUERY when point inside the triangle URL: https://github.com/apache/lucene-solr/pull/1259#issuecomment-586353925 I push it as it is trivial This is an automat

[jira] [Resolved] (LUCENE-9226) Point2D#relateTriangle bug

2020-02-14 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera resolved LUCENE-9226. -- Fix Version/s: 8.5 Assignee: Ignacio Vera Resolution: Fixed master: ebec456602

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE

2020-02-14 Thread GitBox
tflobbe commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE URL: https://github.com/apache/lucene-solr/pull/1247#discussion_r379542807 ## File path: solr/core/src/java/org/apache/solr/metrics/AggregateMetric.java ## @@ -51,6 +

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE

2020-02-14 Thread GitBox
tflobbe commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE URL: https://github.com/apache/lucene-solr/pull/1247#discussion_r379543081 ## File path: solr/core/src/java/org/apache/solr/metrics/AggregateMetric.java ## @@ -93,18

[jira] [Commented] (SOLR-13951) Avoid replica state updates to state.json

2020-02-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037122#comment-17037122 ] David Smiley commented on SOLR-13951: - I'm really happy to see that this will reduce

[GitHub] [lucene-solr] dsmiley commented on issue #1191: SOLR-14197 Reduce API of SolrResourceLoader

2020-02-14 Thread GitBox
dsmiley commented on issue #1191: SOLR-14197 Reduce API of SolrResourceLoader URL: https://github.com/apache/lucene-solr/pull/1191#issuecomment-586399204 FYI tomorrow I'll be on vacation for a week with minimal internet access, so I may not respond much for a bit. Again, I think the issue

[jira] [Commented] (SOLR-13794) Delete solr/core/src/test-files/solr/configsets/_default

2020-02-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037193#comment-17037193 ] ASF subversion and git services commented on SOLR-13794: Commit f

[GitHub] [lucene-solr] HoustonPutman opened a new pull request #1260: SOLR-13669: DIH: Add System property toggle for use of dataConfig param

2020-02-14 Thread GitBox
HoustonPutman opened a new pull request #1260: SOLR-13669: DIH: Add System property toggle for use of dataConfig param URL: https://github.com/apache/lucene-solr/pull/1260 (cherry picked from commit 325824cd391c8e71f36f17d687f52344e50e9715) Addresses [CVE-2019-0193](https://nvd.nist.

[jira] [Commented] (SOLR-13794) Delete solr/core/src/test-files/solr/configsets/_default

2020-02-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037209#comment-17037209 ] ASF subversion and git services commented on SOLR-13794: Commit e

[GitHub] [lucene-solr] HoustonPutman commented on issue #1260: SOLR-13669: DIH: Add System property toggle for use of dataConfig param

2020-02-14 Thread GitBox
HoustonPutman commented on issue #1260: SOLR-13669: DIH: Add System property toggle for use of dataConfig param URL: https://github.com/apache/lucene-solr/pull/1260#issuecomment-586434232 I can't `ant precommit`, do to an issue with a missing license in `solr/contrib/clustering/lib/simple-

[GitHub] [lucene-solr] dweiss commented on issue #1260: SOLR-13669: DIH: Add System property toggle for use of dataConfig param

2020-02-14 Thread GitBox
dweiss commented on issue #1260: SOLR-13669: DIH: Add System property toggle for use of dataConfig param URL: https://github.com/apache/lucene-solr/pull/1260#issuecomment-586438839 You need to copy this license (and checksum) from master or 8x? -

[jira] [Commented] (SOLR-13020) Additional Hooks in SolrEventListener

2020-02-14 Thread Kevin Jia (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037254#comment-17037254 ] Kevin Jia commented on SOLR-13020: -- Very well said Akshay. (y) > Additional Hooks in So

[jira] [Commented] (LUCENE-9222) Detect upgrades with non-default formats

2020-02-14 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037263#comment-17037263 ] Cassandra Targett commented on LUCENE-9222: --- I'm trying to wrap my head around

[jira] [Commented] (SOLR-13020) Additional Hooks in SolrEventListener

2020-02-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037294#comment-17037294 ] David Smiley commented on SOLR-13020: - SolrEventListener seems to be of little use fo

[GitHub] [lucene-solr] HoustonPutman commented on issue #1260: SOLR-13669: DIH: Add System property toggle for use of dataConfig param

2020-02-14 Thread GitBox
HoustonPutman commented on issue #1260: SOLR-13669: DIH: Add System property toggle for use of dataConfig param URL: https://github.com/apache/lucene-solr/pull/1260#issuecomment-586480503 The license file name wasn't updated when the library name was changed in the previous commit. --

[GitHub] [lucene-solr] HoustonPutman commented on issue #1260: SOLR-13669: DIH: Add System property toggle for use of dataConfig param

2020-02-14 Thread GitBox
HoustonPutman commented on issue #1260: SOLR-13669: DIH: Add System property toggle for use of dataConfig param URL: https://github.com/apache/lucene-solr/pull/1260#issuecomment-586484779 Ok, so the added tests work, and precommit passes. This should be good to go.

[jira] [Commented] (LUCENE-9136) Introduce IVFFlat to Lucene for ANN similarity search

2020-02-14 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037325#comment-17037325 ] Julie Tibshirani commented on LUCENE-9136: -- Hello [~irvingzhang], to me this lo

[jira] [Comment Edited] (LUCENE-9136) Introduce IVFFlat to Lucene for ANN similarity search

2020-02-14 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037325#comment-17037325 ] Julie Tibshirani edited comment on LUCENE-9136 at 2/14/20 10:03 PM: --

[jira] [Comment Edited] (LUCENE-9136) Introduce IVFFlat to Lucene for ANN similarity search

2020-02-14 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037325#comment-17037325 ] Julie Tibshirani edited comment on LUCENE-9136 at 2/14/20 10:04 PM: --

[jira] [Resolved] (SOLR-13794) Delete solr/core/src/test-files/solr/configsets/_default

2020-02-14 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter resolved SOLR-13794. --- Fix Version/s: 8.5 master (9.0) Resolution: Fixed > Delete

[GitHub] [lucene-solr] athrog opened a new pull request #1261: SOLR-14260: Make SchemaRegistryProvider pluggable in HttpClientUtil

2020-02-14 Thread GitBox
athrog opened a new pull request #1261: SOLR-14260: Make SchemaRegistryProvider pluggable in HttpClientUtil URL: https://github.com/apache/lucene-solr/pull/1261 # Description HttpClientUtil.java defines and uses an abstract SchemaRegistryProvider for mapping a protocol to an

[GitHub] [lucene-solr] athrog commented on issue #1261: SOLR-14260: Make SchemaRegistryProvider pluggable in HttpClientUtil

2020-02-14 Thread GitBox
athrog commented on issue #1261: SOLR-14260: Make SchemaRegistryProvider pluggable in HttpClientUtil URL: https://github.com/apache/lucene-solr/pull/1261#issuecomment-586520791 FYI @dsmiley This is an automated message from

[jira] [Created] (SOLR-14263) jvm-settings.adoc is way out of date

2020-02-14 Thread Erick Erickson (Jira)
Erick Erickson created SOLR-14263: - Summary: jvm-settings.adoc is way out of date Key: SOLR-14263 URL: https://issues.apache.org/jira/browse/SOLR-14263 Project: Solr Issue Type: Improvement

[jira] [Updated] (SOLR-14263) jvm-settings.adoc is way out of date

2020-02-14 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated SOLR-14263: -- Attachment: SOLR-14263.patch Status: Open (was: Open) Here's an initial whack at chang

[GitHub] [lucene-solr] ErickErickson closed pull request #1022: SOLR-13953: Update eviction behavior of cache in Solr Prometheus exporter to allow for larger clusters

2020-02-14 Thread GitBox
ErickErickson closed pull request #1022: SOLR-13953: Update eviction behavior of cache in Solr Prometheus exporter to allow for larger clusters URL: https://github.com/apache/lucene-solr/pull/1022 This is an automated messag

[GitHub] [lucene-solr] ErickErickson commented on issue #1022: SOLR-13953: Update eviction behavior of cache in Solr Prometheus exporter to allow for larger clusters

2020-02-14 Thread GitBox
ErickErickson commented on issue #1022: SOLR-13953: Update eviction behavior of cache in Solr Prometheus exporter to allow for larger clusters URL: https://github.com/apache/lucene-solr/pull/1022#issuecomment-586538447 Forgot to close this when I fixed the JIRA. ---

[jira] [Comment Edited] (LUCENE-9136) Introduce IVFFlat to Lucene for ANN similarity search

2020-02-14 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037325#comment-17037325 ] Julie Tibshirani edited comment on LUCENE-9136 at 2/15/20 1:44 AM: ---

[jira] [Commented] (LUCENE-9004) Approximate nearest vector search

2020-02-14 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037404#comment-17037404 ] Tomoko Uchida commented on LUCENE-9004: --- {quote}It can readily be shown that HNSW

[GitHub] [lucene-solr] dsmiley commented on issue #1257: SOLR-14258: DocList should not extend DocSet

2020-02-14 Thread GitBox
dsmiley commented on issue #1257: SOLR-14258: DocList should not extend DocSet URL: https://github.com/apache/lucene-solr/pull/1257#issuecomment-586556130 @mkhludnev Thanks for the approval on the first commit about SOLR-14258 (DocList shouldn't implement DocSet). I forged ahead with SOLR-

[GitHub] [lucene-solr] dsmiley commented on issue #1257: SOLR-14258: DocList should not extend DocSet

2020-02-14 Thread GitBox
dsmiley commented on issue #1257: SOLR-14258: DocList should not extend DocSet URL: https://github.com/apache/lucene-solr/pull/1257#issuecomment-586556227 BTW I'm about to step away on vacation for a week with spotty internet access and no computer.

[jira] [Commented] (LUCENE-9222) Detect upgrades with non-default formats

2020-02-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037429#comment-17037429 ] David Smiley commented on LUCENE-9222: -- > will always throw a IndexFormatTooOldExc

[jira] [Commented] (SOLR-14256) Remove HashDocSet

2020-02-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037430#comment-17037430 ] David Smiley commented on SOLR-14256: - For better or worse, the code is on this PR fo