Re: [PR] Use DenseConjunctionBulkScorer for single queries sometimes. [lucene]

2025-02-27 Thread via GitHub
jpountz merged PR #14293: URL: https://github.com/apache/lucene/pull/14293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Use DenseConjunctionBulkScorer for single queries sometimes. [lucene]

2025-02-27 Thread via GitHub
jpountz commented on PR #14293: URL: https://github.com/apache/lucene/pull/14293#issuecomment-2687300793 Yes, especially with queries that match long ranges of doc IDs by design, such as those that take advantage of sparse indexing. > For reminding, I think we also need a CHANGES entr

Re: [PR] Use DenseConjunctionBulkScorer for single queries sometimes. [lucene]

2025-02-27 Thread via GitHub
jpountz commented on code in PR #14293: URL: https://github.com/apache/lucene/pull/14293#discussion_r1973122492 ## lucene/core/src/java/org/apache/lucene/search/TermQuery.java: ## @@ -165,6 +165,17 @@ public Scorer get(long leadCost) throws IOException { } }

Re: [PR] Use DenseConjunctionBulkScorer for single queries sometimes. [lucene]

2025-02-27 Thread via GitHub
jpountz commented on code in PR #14293: URL: https://github.com/apache/lucene/pull/14293#discussion_r1973119540 ## lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java: ## @@ -341,11 +341,10 @@ public ScorerSupplier scorerSupplier(LeafReaderContext context) throws

Re: [PR] Use DenseConjunctionBulkScorer for single queries sometimes. [lucene]

2025-02-26 Thread via GitHub
gf2121 commented on code in PR #14293: URL: https://github.com/apache/lucene/pull/14293#discussion_r1972872831 ## lucene/core/src/java/org/apache/lucene/search/TermQuery.java: ## @@ -165,6 +165,17 @@ public Scorer get(long leadCost) throws IOException { } }

Re: [PR] Use DenseConjunctionBulkScorer for single queries sometimes. [lucene]

2025-02-26 Thread via GitHub
jpountz commented on code in PR #14293: URL: https://github.com/apache/lucene/pull/14293#discussion_r1971643383 ## lucene/core/src/java/org/apache/lucene/document/SortedSetDocValuesRangeQuery.java: ## @@ -158,16 +157,15 @@ public Scorer get(long leadCost) throws IOException {

Re: [PR] Use DenseConjunctionBulkScorer for single queries sometimes. [lucene]

2025-02-26 Thread via GitHub
jpountz commented on PR #14293: URL: https://github.com/apache/lucene/pull/14293#issuecomment-2685119226 > Maybe we can replace all ScorerSuppliers returning ConstantScoreScorer with ConstantScoreScorerSupplier in follow up? Yes, that would be great. I started looking into it, but the

Re: [PR] Use DenseConjunctionBulkScorer for single queries sometimes. [lucene]

2025-02-26 Thread via GitHub
jpountz commented on code in PR #14293: URL: https://github.com/apache/lucene/pull/14293#discussion_r1971632861 ## lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java: ## @@ -341,11 +341,10 @@ public ScorerSupplier scorerSupplier(LeafReaderContext context) throws

Re: [PR] Use DenseConjunctionBulkScorer for single queries sometimes. [lucene]

2025-02-26 Thread via GitHub
gf2121 commented on code in PR #14293: URL: https://github.com/apache/lucene/pull/14293#discussion_r1971065012 ## lucene/core/src/java/org/apache/lucene/document/SortedSetDocValuesRangeQuery.java: ## @@ -158,16 +157,15 @@ public Scorer get(long leadCost) throws IOException {

Re: [PR] Use DenseConjunctionBulkScorer for single queries sometimes. [lucene]

2025-02-25 Thread via GitHub
gf2121 commented on code in PR #14293: URL: https://github.com/apache/lucene/pull/14293#discussion_r1971065012 ## lucene/core/src/java/org/apache/lucene/document/SortedSetDocValuesRangeQuery.java: ## @@ -158,16 +157,15 @@ public Scorer get(long leadCost) throws IOException {

Re: [PR] Use DenseConjunctionBulkScorer for single queries sometimes. [lucene]

2025-02-25 Thread via GitHub
gf2121 commented on code in PR #14293: URL: https://github.com/apache/lucene/pull/14293#discussion_r1971065012 ## lucene/core/src/java/org/apache/lucene/document/SortedSetDocValuesRangeQuery.java: ## @@ -158,16 +157,15 @@ public Scorer get(long leadCost) throws IOException {

Re: [PR] Use DenseConjunctionBulkScorer for single queries sometimes. [lucene]

2025-02-25 Thread via GitHub
gf2121 commented on code in PR #14293: URL: https://github.com/apache/lucene/pull/14293#discussion_r1971058705 ## lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java: ## @@ -341,11 +341,10 @@ public ScorerSupplier scorerSupplier(LeafReaderContext context) throws

Re: [PR] Use DenseConjunctionBulkScorer for single queries sometimes. [lucene]

2025-02-25 Thread via GitHub
jpountz commented on PR #14293: URL: https://github.com/apache/lucene/pull/14293#issuecomment-2683464574 Same dataset but with 5% docs deleted this time and #14294 applied on both the baseline and the candidate: ``` TaskQPS baseline StdDevQPS my_mo

Re: [PR] Use DenseConjunctionBulkScorer for single queries sometimes. [lucene]

2025-02-25 Thread via GitHub
jpountz commented on PR #14293: URL: https://github.com/apache/lucene/pull/14293#issuecomment-2683288839 luceneutil on wikibigall: ``` TaskQPS baseline StdDevQPS my_modified_version StdDevPct diff p-value T