guojialiang92 commented on code in PR #14417:
URL: https://github.com/apache/lucene/pull/14417#discussion_r2032655178
##
lucene/core/src/java/org/apache/lucene/index/IndexWriter.java:
##
@@ -1427,6 +1427,25 @@ public synchronized void advanceSegmentInfosVersion(long
newVersion)
vigyasharma merged PR #14417:
URL: https://github.com/apache/lucene/pull/14417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene
guojialiang92 commented on PR #14417:
URL: https://github.com/apache/lucene/pull/14417#issuecomment-2788140261
Thanks, @vigyasharma
I have made the modifications as suggested, please reivew the code again.
--
This is an automated message from the Apache Git Service.
To respond to the m
vigyasharma commented on code in PR #14417:
URL: https://github.com/apache/lucene/pull/14417#discussion_r2032521908
##
lucene/core/src/java/org/apache/lucene/index/IndexWriter.java:
##
@@ -1427,6 +1427,25 @@ public synchronized void advanceSegmentInfosVersion(long
newVersion) {
guojialiang92 commented on code in PR #14417:
URL: https://github.com/apache/lucene/pull/14417#discussion_r2032735699
##
lucene/test-framework/src/java/org/apache/lucene/tests/index/ThreadedIndexingAndSearchingTestCase.java:
##
@@ -189,6 +190,19 @@ public void run() {
guojialiang92 commented on PR #14417:
URL: https://github.com/apache/lucene/pull/14417#issuecomment-2785132916
Hi, @vigyasharma
Could you please help me take a look again? Do you have any other
suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the
vigyasharma commented on PR #14417:
URL: https://github.com/apache/lucene/pull/14417#issuecomment-2764418906
I think we can add a couple more tests to make it robust.
1. Some tests around concurrency – index with multiple threads, then
advance the counter in one of the threads, and valid
guojialiang92 commented on PR #14417:
URL: https://github.com/apache/lucene/pull/14417#issuecomment-2766116736
Thanks, @vigyasharma
I also looked at Lucene's native segment replication, just sharing my
personal opinion.
> Also, IIUC `IndexWriter#advanceSegmentInfosVersion()` was a
guojialiang92 commented on PR #14417:
URL: https://github.com/apache/lucene/pull/14417#issuecomment-2766081605
Thanks, @vigyasharma
> I think we can add a couple more tests to make it robust.
>
> 1. Some tests around concurrency – index with multiple threads, then
advance the cou
vigyasharma commented on PR #14417:
URL: https://github.com/apache/lucene/pull/14417#issuecomment-2764422079
Also, IIUC `IndexWriter#advanceSegmentInfosVersion()` was added to handle
similar scenarios for NRT replication (Lucene's native segment replication
implementation). I'm curious why
guojialiang92 commented on PR #14417:
URL: https://github.com/apache/lucene/pull/14417#issuecomment-2757291661
Thanks for helping with the code review, I have made modifications according
to the suggestions
--
This is an automated message from the Apache Git Service.
To respond to the mes
guojialiang92 commented on code in PR #14417:
URL: https://github.com/apache/lucene/pull/14417#discussion_r2015957918
##
lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java:
##
@@ -5037,4 +5037,47 @@ public void testDocValuesSkippingIndexWithoutDocValues()
throws
guojialiang92 commented on code in PR #14417:
URL: https://github.com/apache/lucene/pull/14417#discussion_r2015958210
##
lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java:
##
@@ -5037,4 +5037,47 @@ public void testDocValuesSkippingIndexWithoutDocValues()
throws
guojialiang92 commented on code in PR #14417:
URL: https://github.com/apache/lucene/pull/14417#discussion_r2015954336
##
lucene/core/src/java/org/apache/lucene/index/IndexWriter.java:
##
@@ -1427,6 +1427,24 @@ public synchronized void advanceSegmentInfosVersion(long
newVersion)
guojialiang92 commented on code in PR #14417:
URL: https://github.com/apache/lucene/pull/14417#discussion_r2015951779
##
lucene/core/src/java/org/apache/lucene/index/IndexWriter.java:
##
@@ -1427,6 +1427,24 @@ public synchronized void advanceSegmentInfosVersion(long
newVersion)
guojialiang92 commented on code in PR #14417:
URL: https://github.com/apache/lucene/pull/14417#discussion_r2015872376
##
lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java:
##
@@ -5037,4 +5037,45 @@ public void testDocValuesSkippingIndexWithoutDocValues()
throws
vigyasharma commented on code in PR #14417:
URL: https://github.com/apache/lucene/pull/14417#discussion_r2015832195
##
lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java:
##
@@ -5037,4 +5037,47 @@ public void testDocValuesSkippingIndexWithoutDocValues()
throws Ex
vigyasharma commented on code in PR #14417:
URL: https://github.com/apache/lucene/pull/14417#discussion_r2015825615
##
lucene/core/src/java/org/apache/lucene/index/IndexWriter.java:
##
@@ -1427,6 +1427,24 @@ public synchronized void advanceSegmentInfosVersion(long
newVersion) {
vigyasharma commented on code in PR #14417:
URL: https://github.com/apache/lucene/pull/14417#discussion_r2015817265
##
lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java:
##
@@ -5037,4 +5037,45 @@ public void testDocValuesSkippingIndexWithoutDocValues()
throws Ex
19 matches
Mail list logo
