vigyasharma commented on code in PR #14417:
URL: https://github.com/apache/lucene/pull/14417#discussion_r2015825615
##########
lucene/core/src/java/org/apache/lucene/index/IndexWriter.java:
##########
@@ -1427,6 +1427,24 @@ public synchronized void advanceSegmentInfosVersion(long
newVersion) {
changed();
}
+ /**
+ * If {@link SegmentInfos#counter} is below {@code newCounter} then update
it to this value.
+ *
+ * @lucene.internal
+ */
+ public synchronized void advanceSegmentInfosCounter(long newCounter) {
Review Comment:
Do we need to call `changed()` or increment change count here?
##########
lucene/core/src/java/org/apache/lucene/index/IndexWriter.java:
##########
@@ -1427,6 +1427,24 @@ public synchronized void advanceSegmentInfosVersion(long
newVersion) {
changed();
}
+ /**
+ * If {@link SegmentInfos#counter} is below {@code newCounter} then update
it to this value.
+ *
+ * @lucene.internal
+ */
+ public synchronized void advanceSegmentInfosCounter(long newCounter) {
+ this.ensureOpen();
+ if (segmentInfos.counter < newCounter) {
+ segmentInfos.counter = newCounter;
+ }
+ }
+
+ /** Returns the {@link SegmentInfos#counter}. */
+ public synchronized long getSegmentInfosCounter() {
Review Comment:
Do we really need this synchronized?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
