Re: [PR] Speed up sorting on unique string fields. [lucene]

2023-11-02 Thread via GitHub
jpountz commented on PR #11903: URL: https://github.com/apache/lucene/pull/11903#issuecomment-1790706658 @mikemccand You will need to regold before the next nightly run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Speed up sorting on unique string fields. [lucene]

2023-11-02 Thread via GitHub
jpountz merged PR #11903: URL: https://github.com/apache/lucene/pull/11903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Speed up sorting on unique string fields. [lucene]

2023-11-02 Thread via GitHub
jpountz commented on PR #11903: URL: https://github.com/apache/lucene/pull/11903#issuecomment-1790680106 I confirmed that there is still a speedup: ``` TaskQPS baseline StdDevQPS my_modified_version StdDevPct diff p-value

Re: [PR] Speed up sorting on unique string fields. [lucene]

2023-11-02 Thread via GitHub
mikemccand commented on PR #11903: URL: https://github.com/apache/lucene/pull/11903#issuecomment-1790595404 > @mikemccand Merging this PR will require regolding nightly benchmarks. Does it help if you can control when the PR gets merged? Oh no, I failed to reply to this, until now! N