mikemccand commented on PR #11903: URL: https://github.com/apache/lucene/pull/11903#issuecomment-1790595404
> @mikemccand Merging this PR will require regolding nightly benchmarks. Does it help if you can control when the PR gets merged? Oh no, I failed to reply to this, until now! No, we should always merge regardless of nightly benchmarks status -- I'll regold when needed. This change LGTM -- do you want to refresh (I think `CHANGES.txt` entry must move to 9.9) and merge? Thanks @jpountz! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org