Re: [PR] Multireader Support in Searcher Manager [lucene]

2024-11-27 Thread via GitHub
github-actions[bot] commented on PR #13976: URL: https://github.com/apache/lucene/pull/13976#issuecomment-2505040108 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Multireader Support in Searcher Manager [lucene]

2024-11-13 Thread via GitHub
jpountz commented on PR #13976: URL: https://github.com/apache/lucene/pull/13976#issuecomment-2472800472 To add to @vigyasharma, I have been wondering if we should remove `SearcherManager` and encourage users to use `IndexReaderManager`. `IndexSearcher` is cheap to create and there are som

Re: [PR] Multireader Support in Searcher Manager [lucene]

2024-11-07 Thread via GitHub
vigyasharma commented on PR #13976: URL: https://github.com/apache/lucene/pull/13976#issuecomment-2463936596 > any `IndexReader` should work as long as it can `openIfChanged` on itself. Does `MultiReader` implement `openIfChanged()` ? I see a check in `SearcherManager#refreshIfNeeded(

Re: [PR] Multireader Support in Searcher Manager [lucene]

2024-11-04 Thread via GitHub
mikemccand commented on PR #13976: URL: https://github.com/apache/lucene/pull/13976#issuecomment-2455571526 Thanks @Shibi-bala -- I agree it's odd it was scoped to just `DirectoryReader` -- any `IndexReader` should work as long as it can `openIfChanged` on itself. I think `English.ja