mikemccand commented on PR #13976: URL: https://github.com/apache/lucene/pull/13976#issuecomment-2455571526
Thanks @Shibi-bala -- I agree it's odd it was scoped to just `DirectoryReader` -- any `IndexReader` should work as long as it can `openIfChanged` on itself. I think `English.java` (from Lucene's `test-framework`) was maybe deleted long ago? Maybe simplify the test to not bother with English words... just `Integer.toString(i)` or `"" + i` should be fine? Also, please revert the wildcard import (`import org.apache.lucene.index.*`) -- I think our style checker (jtidy/spotless) will be unhappy with that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
