Re: [PR] Introduce DocIdStream#intoBitset to speed up cache [lucene]

2025-02-24 Thread via GitHub
gf2121 commented on PR #14277: URL: https://github.com/apache/lucene/pull/14277#issuecomment-2680655769 > (Longer-term, I'm thinking of removing the query cache https://github.com/apache/lucene/pull/14187) Thanks for explanation, I understand the motivation that we are focusing on sk

Re: [PR] Introduce DocIdStream#intoBitset to speed up cache [lucene]

2025-02-24 Thread via GitHub
gf2121 closed pull request #14277: Introduce DocIdStream#intoBitset to speed up cache URL: https://github.com/apache/lucene/pull/14277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Introduce DocIdStream#intoBitset to speed up cache [lucene]

2025-02-24 Thread via GitHub
jpountz commented on PR #14277: URL: https://github.com/apache/lucene/pull/14277#issuecomment-2679834513 To be honest, I'm a bit on the fence about introducing specialization for caching. This is why I was wondering if faceting could benefit from it too, though I'm not a fan of the fact tha

Re: [PR] Introduce DocIdStream#intoBitset to speed up cache [lucene]

2025-02-24 Thread via GitHub
jpountz commented on PR #14277: URL: https://github.com/apache/lucene/pull/14277#issuecomment-2679821035 I had thought of something in-between your previous PR and this one. E.g. adding `BulkScorer#intoBitSet` with a similar signature and contract as `DocIdSetIterator#intoBitSet`. -- Thi

Re: [PR] Introduce DocIdStream#intoBitset to speed up cache [lucene]

2025-02-23 Thread via GitHub
gf2121 commented on PR #14277: URL: https://github.com/apache/lucene/pull/14277#issuecomment-2677007819 > an API like DocIdSet scoreAsDocIdSet(Bits acceptDocs) I roughly implemented the idea and use it the range query. I'll add tests if it makes sense to you. -- This is an automate

Re: [PR] Introduce DocIdStream#intoBitset to speed up cache [lucene]

2025-02-23 Thread via GitHub
gf2121 commented on PR #14277: URL: https://github.com/apache/lucene/pull/14277#issuecomment-2676760047 Thanks for feedback! > I had thought of BulkScorer as a better place for this API that would more easily help the queries that you mentioned. Can you describe the challenges that

Re: [PR] Introduce DocIdStream#intoBitset to speed up cache [lucene]

2025-02-22 Thread via GitHub
jpountz commented on PR #14277: URL: https://github.com/apache/lucene/pull/14277#issuecomment-2676680926 I believe that this could help `FacetCollector` as well. Intuitively, I had thought of `BulkScorer` as a better place for this API that would more easily help the queries that you