gf2121 commented on PR #14277: URL: https://github.com/apache/lucene/pull/14277#issuecomment-2676760047
Thanks for feedback! > I had thought of BulkScorer as a better place for this API that would more easily help the queries that you mentioned. Can you describe the challenges that you identified? I meant it would be a challenge if no new API was added :) Adding the API to either `DocIdStream` or `BulkScorer` should work. I agree that adding it to `BulkScorer` would make things much simpler, I like it! > I believe that this could help FacetCollector as well. +1. I notice that `FacetCollector` use a `DocIdSetBuilder` instead of `FixedBitSet`. `LRUQueryCache` also tries to reduce memory usage by `RoaringDocIdSet`. I'm thinking about an API like `DocIdSet scoreAsDocIdSet(Bits acceptDocs, int min, int max)`, WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
