rmuir merged PR #13277:
URL: https://github.com/apache/lucene/pull/13277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
mikemccand commented on PR #13277:
URL: https://github.com/apache/lucene/pull/13277#issuecomment-2049542084
> AssertionError is ok too I think, if a user wants to run with -ea, let's
make it worth their while.
Cool!
--
This is an automated message from the Apache Git Service.
To re
uschindler commented on PR #13277:
URL: https://github.com/apache/lucene/pull/13277#issuecomment-2049057023
> * all subclasses of LinkageError read like "code is broken" to me.
Yes, this is why the code around MMapDir and MethodHandles in general is
correct and needs no change. errorp
rmuir commented on PR #13277:
URL: https://github.com/apache/lucene/pull/13277#issuecomment-2048667001
I've been mulling over this PR for a while, not the type of one you want to
rush in. But the more I think about it, the more I like it.
* javadocs for Error describe them as `abnorma
rmuir commented on PR #13277:
URL: https://github.com/apache/lucene/pull/13277#issuecomment-2043294016
Yes, there is real work to do there. I dug into it, I think we will need
multiple issues for that one...
--
This is an automated message from the Apache Git Service.
To respond to the me
uschindler commented on PR #13277:
URL: https://github.com/apache/lucene/pull/13277#issuecomment-2042666045
All fine, maybe I was not clear! I just wanted to mention the "catch
Throwable" issue and that we should additionally deal with it.
--
This is an automated message from the Apache G
rmuir commented on PR #13277:
URL: https://github.com/apache/lucene/pull/13277#issuecomment-2041270352
> We should also check that we always rethrow `Error` and `RuntimeException`
in those catch-all `catch (Throwable)` blocks. Otherwise they are silently
converted to something different and
uschindler commented on PR #13277:
URL: https://github.com/apache/lucene/pull/13277#issuecomment-2041021031
We should also check that we always rethrow `Error` and `RuntimeException`
in those catch-all `catch (Throwable)` blocks. Otherwise they are silently
converted to
I would like
