gsmiller commented on PR #13201:
URL: https://github.com/apache/lucene/pull/13201#issuecomment-2284078553
Thanks @msfroh. Yeah, I think it's worth exploring as long as there isn't
something expensive-ish hiding in the weight creation of `BooleanQuery`. Thanks
again!
--
This is an automat
msfroh commented on PR #13201:
URL: https://github.com/apache/lucene/pull/13201#issuecomment-2278441860
Thanks, Greg! I can create a follow-up PR with your suggestion on delegating
to the rewritten `BooleanQuery` for the cost estimate.
I think if we go down that path (basically doing
gsmiller commented on PR #13201:
URL: https://github.com/apache/lucene/pull/13201#issuecomment-2278379745
@msfroh hope you don't mind, but since my PR feedback was pretty minor, I
went ahead and made those small changes on your branch and merged. I'll work on
getting this backported shortly
gsmiller merged PR #13201:
URL: https://github.com/apache/lucene/pull/13201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.ap
gsmiller commented on code in PR #13201:
URL: https://github.com/apache/lucene/pull/13201#discussion_r1704183629
##
lucene/core/src/java/org/apache/lucene/search/AbstractMultiTermQueryConstantScoreWrapper.java:
##
@@ -240,9 +219,38 @@ public ScorerSupplier scorerSupplier(LeafRea
github-actions[bot] commented on PR #13201:
URL: https://github.com/apache/lucene/pull/13201#issuecomment-2204763543
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
msfroh commented on PR #13201:
URL: https://github.com/apache/lucene/pull/13201#issuecomment-2176943173
@gsmiller, @mayya-sharipova -- What do you both think of this approach?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
msfroh commented on code in PR #13201:
URL: https://github.com/apache/lucene/pull/13201#discussion_r1645031925
##
lucene/core/src/java/org/apache/lucene/search/AbstractMultiTermQueryConstantScoreWrapper.java:
##
@@ -154,21 +154,24 @@ protected abstract WeightOrDocIdSetIterator r
msfroh commented on PR #13201:
URL: https://github.com/apache/lucene/pull/13201#issuecomment-2176805195
There we go -- I reworked the PR to reuse the terms collected during the
call to `rewrite` in https://github.com/apache/lucene/pull/13454.
Rather than modifying `estimateCost`, we c
msfroh commented on PR #13201:
URL: https://github.com/apache/lucene/pull/13201#issuecomment-2173738398
I should check if maybe this has been superseded by
https://github.com/apache/lucene/pull/13454
That change seems to look at some of the term states for the first 16 terms
during r
github-actions[bot] commented on PR #13201:
URL: https://github.com/apache/lucene/pull/13201#issuecomment-2048636803
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
rquesada-tibco commented on code in PR #13201:
URL: https://github.com/apache/lucene/pull/13201#discussion_r1540777517
##
lucene/core/src/java/org/apache/lucene/search/AbstractMultiTermQueryConstantScoreWrapper.java:
##
@@ -292,7 +292,21 @@ public long cost() {
};
}
msfroh commented on code in PR #13201:
URL: https://github.com/apache/lucene/pull/13201#discussion_r1540109959
##
lucene/core/src/java/org/apache/lucene/search/AbstractMultiTermQueryConstantScoreWrapper.java:
##
@@ -292,7 +292,21 @@ public long cost() {
};
}
-p
msfroh commented on code in PR #13201:
URL: https://github.com/apache/lucene/pull/13201#discussion_r1540080444
##
lucene/core/src/java/org/apache/lucene/search/AbstractMultiTermQueryConstantScoreWrapper.java:
##
@@ -292,7 +292,21 @@ public long cost() {
};
}
-p
rquesada-tibco commented on code in PR #13201:
URL: https://github.com/apache/lucene/pull/13201#discussion_r1539468242
##
lucene/core/src/java/org/apache/lucene/search/AbstractMultiTermQueryConstantScoreWrapper.java:
##
@@ -292,7 +292,21 @@ public long cost() {
};
}
rquesada-tibco commented on code in PR #13201:
URL: https://github.com/apache/lucene/pull/13201#discussion_r1539388204
##
lucene/core/src/java/org/apache/lucene/search/AbstractMultiTermQueryConstantScoreWrapper.java:
##
@@ -292,7 +292,21 @@ public long cost() {
};
}
rquesada-tibco commented on code in PR #13201:
URL: https://github.com/apache/lucene/pull/13201#discussion_r1539388204
##
lucene/core/src/java/org/apache/lucene/search/AbstractMultiTermQueryConstantScoreWrapper.java:
##
@@ -292,7 +292,21 @@ public long cost() {
};
}
17 matches
Mail list logo
