msfroh commented on code in PR #13201:
URL: https://github.com/apache/lucene/pull/13201#discussion_r1645031925
##########
lucene/core/src/java/org/apache/lucene/search/AbstractMultiTermQueryConstantScoreWrapper.java:
##########
@@ -154,21 +154,24 @@ protected abstract WeightOrDocIdSetIterator rewriteInner(
List<TermAndState> collectedTerms)
throws IOException;
- private IOSupplier<WeightOrDocIdSetIterator> rewrite(LeafReaderContext
context, Terms terms)
+ private IOSupplier<WeightOrDocIdSetIterator> rewrite(
+ LeafReaderContext context,
+ Terms terms,
+ List<TermAndState> collectedTerms,
+ boolean[] collectResult)
Review Comment:
Turning `collectResult` into an out-param (along with `collectedTerms`)
feels hacky.
I might try inlining `rewrite` (folding it into `scorerSupplier`) to see how
that looks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
