zhaih merged PR #12767:
URL: https://github.com/apache/lucene/pull/12767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
zhaih commented on code in PR #12767:
URL: https://github.com/apache/lucene/pull/12767#discussion_r1387529653
##
lucene/core/src/test/org/apache/lucene/search/TestRegexpQuery.java:
##
@@ -80,7 +80,10 @@ private long caseInsensitiveRegexQueryNrHits(String regex)
throws IOExcepti
rmuir commented on code in PR #12767:
URL: https://github.com/apache/lucene/pull/12767#discussion_r1384795478
##
lucene/core/src/test/org/apache/lucene/search/TestRegexpQuery.java:
##
@@ -80,7 +80,10 @@ private long caseInsensitiveRegexQueryNrHits(String regex)
throws IOExcepti
zhaih commented on code in PR #12767:
URL: https://github.com/apache/lucene/pull/12767#discussion_r1384459245
##
lucene/core/src/test/org/apache/lucene/search/TestRegexpQuery.java:
##
@@ -80,7 +80,10 @@ private long caseInsensitiveRegexQueryNrHits(String regex)
throws IOExcepti
rmuir commented on PR #12767:
URL: https://github.com/apache/lucene/pull/12767#issuecomment-1794787497
I was thinking just to exercise it in TestRegexpRandom2 or similar test.
Maybe add TestRegexpRandom3.java?
Test is conceptually very simple but powerful. It has a lot of lines of cod
rmuir commented on PR #12767:
URL: https://github.com/apache/lucene/pull/12767#issuecomment-1794689085
There should be tests exercising this new boolean option. How do we know it
gives correct results to do this?
--
This is an automated message from the Apache Git Service.
To respond to t
