Re: [PR] Completion FSTs to be loaded off-heap at all times [lucene]

jpountz commented on PR #14364: URL: https://github.com/apache/lucene/pull/14364#issuecomment-2738217161 Agreed! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] Completion FSTs to be loaded off-heap at all times [lucene]

javanna commented on PR #14364: URL: https://github.com/apache/lucene/pull/14364#issuecomment-2738284353 Thanks @jpountz for all the help! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Completion FSTs to be loaded off-heap at all times [lucene]

javanna merged PR #14364: URL: https://github.com/apache/lucene/pull/14364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Completion FSTs to be loaded off-heap at all times [lucene]

javanna commented on PR #14364: URL: https://github.com/apache/lucene/pull/14364#issuecomment-2737720139 I merged main in after merging #14372 and added a changelog entry. I believe this is ready to go, and can now be backported to branch_10x as-is. -- This is an automated message from th

Re: [PR] Completion FSTs to be loaded off-heap at all times [lucene]

javanna commented on PR #14364: URL: https://github.com/apache/lucene/pull/14364#issuecomment-2736648444 I opened #14372 to address the visibility issue of `load`, that should simplify this PR and backporting it once merged. -- This is an automated message from the Apache Git Service. To

Re: [PR] Completion FSTs to be loaded off-heap at all times [lucene]

jpountz commented on PR #14364: URL: https://github.com/apache/lucene/pull/14364#issuecomment-2736470811 Good question. The class is public and looked like a user-facing API hence my comment, but you can't serialize a NRTSuggester yourself since `NRTSuggesterBuilder` is pkg-private. So it l

Re: [PR] Completion FSTs to be loaded off-heap at all times [lucene]

javanna commented on PR #14364: URL: https://github.com/apache/lucene/pull/14364#issuecomment-2736271001 Cool then I will target this PR at main only, and open a separate PR for `branch_10x`. Out of curiosity, what are the usecases where you'd expect users to call `NRTSuggester#load` direct

Re: [PR] Completion FSTs to be loaded off-heap at all times [lucene]

jpountz commented on PR #14364: URL: https://github.com/apache/lucene/pull/14364#issuecomment-2735857094 I was thinking of keeping the `load(IndexInput, FSTLoadMode)` static method, documenting that the load mode is ignored and deprecating it. Indeed that would require keeping the `FSTLoadM

Re: [PR] Completion FSTs to be loaded off-heap at all times [lucene]

javanna commented on PR #14364: URL: https://github.com/apache/lucene/pull/14364#issuecomment-2735835683 Thanks @jpountz what's your suggestion around back-compat? Sounds like you are suggesting not backporting the removal of the fst load mode enum but only the switch to off-heap by default

Re: [PR] Completion FSTs to be loaded off-heap at all times [lucene]

javanna commented on code in PR #14364: URL: https://github.com/apache/lucene/pull/14364#discussion_r2000898675 ## lucene/suggest/src/test/org/apache/lucene/search/suggest/document/TestSuggestField.java: ## @@ -951,7 +951,16 @@ static IndexWriterConfig iwcWithSuggestField(Analyz