javanna commented on code in PR #14364:
URL: https://github.com/apache/lucene/pull/14364#discussion_r2000898675


##########
lucene/suggest/src/test/org/apache/lucene/search/suggest/document/TestSuggestField.java:
##########
@@ -951,7 +951,16 @@ static IndexWriterConfig iwcWithSuggestField(Analyzer 
analyzer, final Set<String
         new FilterCodec(TestUtil.getDefaultCodec().getName(), 
TestUtil.getDefaultCodec()) {
           final CompletionPostingsFormat.FSTLoadMode fstLoadMode =
               RandomPicks.randomFrom(random(), 
CompletionPostingsFormat.FSTLoadMode.values());
-          final PostingsFormat postingsFormat = new 
Completion101PostingsFormat(fstLoadMode);
+          // FST load mode can only be overridden via a custom completion 
postings format
+          final PostingsFormat postingsFormat =
+              new CompletionPostingsFormat("Completion101", fstLoadMode) {
+                final CompletionPostingsFormat delegate = new 
Completion101PostingsFormat();
+
+                @Override
+                protected PostingsFormat delegatePostingsFormat() {
+                  return delegate.delegatePostingsFormat();
+                }
+              };

Review Comment:
   I updated this PR to remove the option to configure the load mode entirely. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to