reta commented on code in PR #14302:
URL: https://github.com/apache/lucene/pull/14302#discussion_r1974531053
##
lucene/core/src/java/org/apache/lucene/index/StandardDirectoryReader.java:
##
@@ -476,7 +476,7 @@ protected void doClose() throws IOException {
}
reta commented on code in PR #14302:
URL: https://github.com/apache/lucene/pull/14302#discussion_r1974531053
##
lucene/core/src/java/org/apache/lucene/index/StandardDirectoryReader.java:
##
@@ -476,7 +476,7 @@ protected void doClose() throws IOException {
}
madrob commented on code in PR #14302:
URL: https://github.com/apache/lucene/pull/14302#discussion_r1974374898
##
lucene/CHANGES.txt:
##
@@ -45,7 +45,8 @@ Bug Fixes
Other
-
-(No changes)
+
+* GITHUB#9: Bump minimum required Java version to 23
Review
uschindler commented on PR #14302:
URL: https://github.com/apache/lucene/pull/14302#issuecomment-2689174826
We may now also remove SecurityManager and AccessController everywhere in
main branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
uschindler commented on PR #14302:
URL: https://github.com/apache/lucene/pull/14302#issuecomment-2689172018
I will look into moving the MMapDirectory parts to the main code and only
leave the vector stuff in the APIJAR special case.
--
This is an automated message from the Apache Git Serv
uschindler commented on PR #14302:
URL: https://github.com/apache/lucene/pull/14302#issuecomment-2689162858
I stopped the Jenkins builds on Policeman Jenkins and will check to update
the config for Java 23.
--
This is an automated message from the Apache Git Service.
To respond to the mes
ChrisHegarty merged PR #14302:
URL: https://github.com/apache/lucene/pull/14302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucen
ChrisHegarty commented on PR #14302:
URL: https://github.com/apache/lucene/pull/14302#issuecomment-2687487855
> The same test failed again, this time on windows.
>
> To me at a glance, this looks to be unrelated issue caused by #14294
ha! I had to merge main, since I didn't have
rmuir commented on PR #14302:
URL: https://github.com/apache/lucene/pull/14302#issuecomment-2687466537
The same test failed again, this time on windows.
To me at a glance, this looks to be unrelated issue caused by #14294
cc @jpountz
--
This is an automated message from th
rmuir commented on PR #14302:
URL: https://github.com/apache/lucene/pull/14302#issuecomment-2687423920
test failure on mac looked like a good ole flaky test to me, I re-reran.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
ChrisHegarty commented on code in PR #14302:
URL: https://github.com/apache/lucene/pull/14302#discussion_r1973227461
##
lucene/core/src/java/org/apache/lucene/index/IndexReader.java:
##
@@ -253,8 +253,10 @@ public final void decRef() throws IOException {
final int rc = refC
rmuir commented on code in PR #14302:
URL: https://github.com/apache/lucene/pull/14302#discussion_r1973219365
##
lucene/core/src/java/org/apache/lucene/index/IndexReader.java:
##
@@ -253,8 +253,10 @@ public final void decRef() throws IOException {
final int rc = refCount.de
rmuir commented on code in PR #14302:
URL: https://github.com/apache/lucene/pull/14302#discussion_r1973206235
##
lucene/core/src/java/org/apache/lucene/index/IndexReader.java:
##
@@ -253,8 +253,10 @@ public final void decRef() throws IOException {
final int rc = refCount.de
ChrisHegarty commented on code in PR #14302:
URL: https://github.com/apache/lucene/pull/14302#discussion_r1973205040
##
lucene/core/src/java/org/apache/lucene/index/IndexReader.java:
##
@@ -253,8 +253,10 @@ public final void decRef() throws IOException {
final int rc = refC
rmuir commented on code in PR #14302:
URL: https://github.com/apache/lucene/pull/14302#discussion_r1973201491
##
lucene/core/src/java/org/apache/lucene/index/IndexReader.java:
##
@@ -253,8 +253,10 @@ public final void decRef() throws IOException {
final int rc = refCount.de
dweiss commented on code in PR #14302:
URL: https://github.com/apache/lucene/pull/14302#discussion_r1973191532
##
lucene/core/src/java/org/apache/lucene/index/IndexReader.java:
##
@@ -253,8 +253,10 @@ public final void decRef() throws IOException {
final int rc = refCount.d
dweiss commented on code in PR #14302:
URL: https://github.com/apache/lucene/pull/14302#discussion_r1973185969
##
lucene/core/src/java/org/apache/lucene/index/IndexReader.java:
##
@@ -253,8 +253,10 @@ public final void decRef() throws IOException {
final int rc = refCount.d
dweiss commented on PR #14302:
URL: https://github.com/apache/lucene/pull/14302#issuecomment-2687333543
All the way up to 3.40.0 in versions.toml:
```
ecj = "3.36.0"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
ChrisHegarty commented on PR #14302:
URL: https://github.com/apache/lucene/pull/14302#issuecomment-2687333833
> ```
> > Task :lucene:core.tests:ecjLintMain FAILED
> source level should be in '1.1'...'1.8','9'...'21' (or '5.0'..'21.0'): 23
> ```
>
> ECJ is failing, perhaps it n
dweiss commented on PR #14302:
URL: https://github.com/apache/lucene/pull/14302#issuecomment-2687329916
```
> Task :lucene:core.tests:ecjLintMain FAILED
source level should be in '1.1'...'1.8','9'...'21' (or '5.0'..'21.0'): 23
```
ECJ is failing, perhaps it needs to be updated
20 matches
Mail list logo
