bjacobowitz closed pull request #13109: Add WrappedCandidateMatcher for
composing matchers
URL: https://github.com/apache/lucene/pull/13109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
bjacobowitz commented on PR #13109:
URL: https://github.com/apache/lucene/pull/13109#issuecomment-2269027662
Closing, see PR #13632 with new approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
bjacobowitz commented on PR #13109:
URL: https://github.com/apache/lucene/pull/13109#issuecomment-2261381762
Great, I'll open another PR shortly with those changes (`matchQuery()`,
`reportError()` and `finish()` public), and will reference this one for
context. Thanks!
--
This is an auto
romseygeek commented on PR #13109:
URL: https://github.com/apache/lucene/pull/13109#issuecomment-2255366931
Thanks, that's very helpful. Given that composite matchers need to call
those methods for CandidateMatcher to be useful, I think the simplest way
forward here is to make `matchQuery(
bjacobowitz commented on PR #13109:
URL: https://github.com/apache/lucene/pull/13109#issuecomment-2250901342
Sure. It's roughly the same approach as ParallelMatcher, but with a reactive
setup instead of an ExecutorService.
`monitor.match(Document, MatcherFactory)` runs a bunch of quer
romseygeek commented on PR #13109:
URL: https://github.com/apache/lucene/pull/13109#issuecomment-2248744950
Hi @bjacobowitz, thanks for the detailed update! I think this would be
easier to reason about if we had some concrete examples. Do you think you
could post some code of composite ma
bjacobowitz commented on PR #13109:
URL: https://github.com/apache/lucene/pull/13109#issuecomment-2248546608
@romseygeek I'm wondering if maybe we should make those functions `protected
final` as you suggest, but also make some of the `CandidateMatcher`
implementations public.
Right
github-actions[bot] commented on PR #13109:
URL: https://github.com/apache/lucene/pull/13109#issuecomment-2076083082
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
cpoerschke commented on PR #13109:
URL: https://github.com/apache/lucene/pull/13109#issuecomment-2047245790
> ... Of course another solution would be to simply make these functions
public, but I understand the desire to avoid that if possible.
Again, I'm not really familiar with this
github-actions[bot] commented on PR #13109:
URL: https://github.com/apache/lucene/pull/13109#issuecomment-2043922410
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
bjacobowitz commented on PR #13109:
URL: https://github.com/apache/lucene/pull/13109#issuecomment-2017958689
> The `protected` visibility on `matchQuery()` should already be fine here -
you can override or call protected methods from within subclasses. I think
making `reportError()` and `fi
github-actions[bot] commented on PR #13109:
URL: https://github.com/apache/lucene/pull/13109#issuecomment-2000746815
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
romseygeek commented on PR #13109:
URL: https://github.com/apache/lucene/pull/13109#issuecomment-1973412491
The `protected` visibility on `matchQuery()` should already be fine here -
you can override or call protected methods from within subclasses. I think
making `reportError()` and `fini
cpoerschke commented on PR #13109:
URL: https://github.com/apache/lucene/pull/13109#issuecomment-1972848845
Thanks @bjacobowitz for a very detailed pull request here!
I'm not really familiar with this area of the code but intuitively would be
curious what the alternative (you mentione
github-actions[bot] commented on PR #13109:
URL: https://github.com/apache/lucene/pull/13109#issuecomment-1972198347
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
15 matches
Mail list logo
