jpountz commented on PR #14154:
URL: https://github.com/apache/lucene/pull/14154#issuecomment-2652082591
I suspect that `ReuseStrategy` hasn't been built with the idea that it could
be use to invalidate components, but only as a way to describe an efficient
caching strategy for analysis com
mayya-sharipova commented on PR #14154:
URL: https://github.com/apache/lucene/pull/14154#issuecomment-2651354310
@jpountz Thank you for your feedback. I am happy to discuss alternatives.
Isn't the whole idea of ReuseStrategy to decide if an analyzer's components
can be reused or shou
jpountz commented on PR #14154:
URL: https://github.com/apache/lucene/pull/14154#issuecomment-2649385716
I don't feel good about this change (at least not yet). It looks like there
is an analyzer that changes its components over time somewhere, and this change
aims at making sure that an an
mayya-sharipova merged PR #14154:
URL: https://github.com/apache/lucene/pull/14154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lu
benwtrent commented on code in PR #14154:
URL: https://github.com/apache/lucene/pull/14154#discussion_r1943127032
##
lucene/core/src/java/org/apache/lucene/analysis/AnalyzerWrapper.java:
##
@@ -151,4 +156,62 @@ protected final Reader initReaderForNormalization(String
fieldName,
benwtrent commented on code in PR #14154:
URL: https://github.com/apache/lucene/pull/14154#discussion_r1939910069
##
lucene/core/src/java/org/apache/lucene/analysis/AnalyzerWrapper.java:
##
@@ -151,4 +157,78 @@ protected final Reader initReaderForNormalization(String
fieldName,
benwtrent commented on PR #14154:
URL: https://github.com/apache/lucene/pull/14154#issuecomment-2627867537
I will have to review later, but first glance is way cleaner than before!
Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
mayya-sharipova commented on PR #14154:
URL: https://github.com/apache/lucene/pull/14154#issuecomment-2627822654
I syncrhonized with @benwtrent offline, and we decided to use to extend
TokenStreamComponents, so that it has access to wrapped components.
@benwtrent please review the la
mayya-sharipova commented on code in PR #14154:
URL: https://github.com/apache/lucene/pull/14154#discussion_r1937606710
##
lucene/core/src/java/org/apache/lucene/analysis/AnalyzerWrapper.java:
##
@@ -151,4 +160,46 @@ protected final Reader initReaderForNormalization(String
fiel
benwtrent commented on code in PR #14154:
URL: https://github.com/apache/lucene/pull/14154#discussion_r1929163572
##
lucene/analysis/common/src/java/org/apache/lucene/analysis/query/QueryAutoStopWordAnalyzer.java:
##
@@ -126,7 +126,7 @@ public QueryAutoStopWordAnalyzer(
publi
mayya-sharipova commented on PR #14154:
URL: https://github.com/apache/lucene/pull/14154#issuecomment-2610406769
@jpountz @benwtrent I've addressed your comments in the last commit, please
continue to review
--
This is an automated message from the Apache Git Service.
To respond to the me
11 matches
Mail list logo
