Re: [PR] simple cleanups to vector code [lucene]

2023-10-15 Thread via GitHub
uschindler commented on PR #12680: URL: https://github.com/apache/lucene/pull/12680#issuecomment-1763463280 I backported this one to 9.x. As I cleaned up commits, this one was committed in 9.x as part of #12681 -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] simple cleanups to vector code [lucene]

2023-10-15 Thread via GitHub
rmuir merged PR #12680: URL: https://github.com/apache/lucene/pull/12680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

Re: [PR] simple cleanups to vector code [lucene]

2023-10-14 Thread via GitHub
rmuir commented on PR #12680: URL: https://github.com/apache/lucene/pull/12680#issuecomment-1763090784 cosine() ones cleaned up now too. I don't see perf issue with the array: guess this whole shebang relies on escape analysis anyway. -- This is an automated message from the Apache Git Se

[PR] simple cleanups to vector code [lucene]

2023-10-14 Thread via GitHub
rmuir opened a new pull request, #12680: URL: https://github.com/apache/lucene/pull/12680 Now that we have integrated benchmarks, it is easier to take care of this code. This is pretty straightforward change: * split out vectorized loops to avoid huge methods (especially integer