rmuir opened a new pull request, #12680: URL: https://github.com/apache/lucene/pull/12680
Now that we have integrated benchmarks, it is easier to take care of this code. This is pretty straightforward change: * split out vectorized loops to avoid huge methods (especially integer methods with multiple implementations) * a couple variable renames and "import static" so that formatter stops butchering the file and making it unreadable * correct comments where possible while i'm here, i know, still not perfect I see the same performance (no logic was changed) Note: not much can be done with cosine method, for obvious reasons that it is a slow complex nightmare, IMO we shouldn't support it anyway. But we can't let that get in the way of trying to improve the other ones. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
