Re: [PR] deduplicate standard BKDConfig records [lucene]

2025-03-13 Thread via GitHub
iverase merged PR #14338: URL: https://github.com/apache/lucene/pull/14338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[PR] deduplicate standard BKDConfig records [lucene]

2025-03-11 Thread via GitHub
iverase opened a new pull request, #14338: URL: https://github.com/apache/lucene/pull/14338 In the case you have many BKD readers on the same heap, it feels wasteful to have individual instances of BKDConfig records as most of the time those instances correspond to standard lucene fields. T

Re: [PR] deduplicate standard BKDConfig records [lucene]

2025-03-11 Thread via GitHub
jpountz commented on code in PR #14338: URL: https://github.com/apache/lucene/pull/14338#discussion_r1989674584 ## lucene/core/src/java/org/apache/lucene/util/bkd/BKDConfig.java: ## @@ -38,6 +39,18 @@ public record BKDConfig(int numDims, int numIndexDims, int bytesPerDim, int m

Re: [PR] deduplicate standard BKDConfig records [lucene]

2025-03-11 Thread via GitHub
iverase commented on code in PR #14338: URL: https://github.com/apache/lucene/pull/14338#discussion_r1989664702 ## lucene/core/src/java/org/apache/lucene/util/bkd/BKDConfig.java: ## @@ -38,6 +39,19 @@ public record BKDConfig(int numDims, int numIndexDims, int bytesPerDim, int m

Re: [PR] deduplicate standard BKDConfig records [lucene]

2025-03-11 Thread via GitHub
iverase commented on code in PR #14338: URL: https://github.com/apache/lucene/pull/14338#discussion_r1989663618 ## lucene/core/src/java/org/apache/lucene/util/bkd/BKDConfig.java: ## @@ -38,6 +39,19 @@ public record BKDConfig(int numDims, int numIndexDims, int bytesPerDim, int m

Re: [PR] deduplicate standard BKDConfig records [lucene]

2025-03-11 Thread via GitHub
jpountz commented on code in PR #14338: URL: https://github.com/apache/lucene/pull/14338#discussion_r1989627096 ## lucene/core/src/java/org/apache/lucene/util/bkd/BKDConfig.java: ## @@ -68,6 +82,16 @@ public record BKDConfig(int numDims, int numIndexDims, int bytesPerDim, int m