jpountz commented on code in PR #14338: URL: https://github.com/apache/lucene/pull/14338#discussion_r1989674584
########## lucene/core/src/java/org/apache/lucene/util/bkd/BKDConfig.java: ########## @@ -38,6 +39,18 @@ public record BKDConfig(int numDims, int numIndexDims, int bytesPerDim, int maxP /** Maximum number of index dimensions */ public static final int MAX_INDEX_DIMS = 8; + private static final List<BKDConfig> DEFAULT_CONFIGS = + List.of( + new BKDConfig(1, 1, 2, DEFAULT_MAX_POINTS_IN_LEAF_NODE), Review Comment: nit: add a comment about the reasoning wrt how this list has been compiled? ########## lucene/core/src/java/org/apache/lucene/util/bkd/BKDConfig.java: ########## @@ -38,6 +39,18 @@ public record BKDConfig(int numDims, int numIndexDims, int bytesPerDim, int maxP /** Maximum number of index dimensions */ public static final int MAX_INDEX_DIMS = 8; + private static final List<BKDConfig> DEFAULT_CONFIGS = + List.of( + new BKDConfig(1, 1, 2, DEFAULT_MAX_POINTS_IN_LEAF_NODE), + new BKDConfig(1, 1, 4, DEFAULT_MAX_POINTS_IN_LEAF_NODE), + new BKDConfig(1, 1, 8, DEFAULT_MAX_POINTS_IN_LEAF_NODE), + new BKDConfig(1, 1, 16, DEFAULT_MAX_POINTS_IN_LEAF_NODE), + new BKDConfig(2, 2, 2, DEFAULT_MAX_POINTS_IN_LEAF_NODE), + new BKDConfig(2, 2, 4, DEFAULT_MAX_POINTS_IN_LEAF_NODE), + new BKDConfig(2, 2, 8, DEFAULT_MAX_POINTS_IN_LEAF_NODE), + new BKDConfig(2, 2, 16, DEFAULT_MAX_POINTS_IN_LEAF_NODE), + new BKDConfig(7, 4, 4, DEFAULT_MAX_POINTS_IN_LEAF_NODE)); Review Comment: nit: add a comment that says that this is the config of shapes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
