Re: [PR] assertDocValuesEquals should support sparse sorted doc_values [lucene]

2025-06-25 Thread via GitHub
parkertimmins commented on PR #14839: URL: https://github.com/apache/lucene/pull/14839#issuecomment-3006024827 @jpountz Whoops, I missed that it needed a change log entry. Thanks for the heads up. Add an entry to the 10.3 section. Thanks! -- This is an automated message from the Apache Gi

Re: [PR] assertDocValuesEquals should support sparse sorted doc_values [lucene]

2025-06-25 Thread via GitHub
jpountz commented on PR #14839: URL: https://github.com/apache/lucene/pull/14839#issuecomment-3005908737 Can you add a CHANGES entry under 10.3 before I merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] assertDocValuesEquals should support sparse sorted doc_values [lucene]

2025-06-25 Thread via GitHub
parkertimmins commented on code in PR #14839: URL: https://github.com/apache/lucene/pull/14839#discussion_r2167457390 ## lucene/core/src/test/org/apache/lucene/index/TestDuelingCodecs.java: ## @@ -113,6 +114,11 @@ public static void createRandomIndex(int numdocs, RandomIndexWri

Re: [PR] assertDocValuesEquals should support sparse sorted doc_values [lucene]

2025-06-23 Thread via GitHub
github-actions[bot] commented on PR #14839: URL: https://github.com/apache/lucene/pull/14839#issuecomment-2998141485 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop

[PR] assertDocValuesEquals should support sparse sorted doc_values [lucene]

2025-06-23 Thread via GitHub
parkertimmins opened a new pull request, #14839: URL: https://github.com/apache/lucene/pull/14839 In LuceneTestCase, assertDocValuesEquals compares the doc_values in two indices. For SortedSetDocValues, as well as other doc value types, it does not assume that every document has a value. Bu