parkertimmins commented on code in PR #14839:
URL: https://github.com/apache/lucene/pull/14839#discussion_r2167457390
##########
lucene/core/src/test/org/apache/lucene/index/TestDuelingCodecs.java:
##########
@@ -113,6 +114,11 @@ public static void createRandomIndex(int numdocs,
RandomIndexWriter writer, long
for (String trash : split) {
document.add(new SortedSetDocValuesField("sortedset", new
BytesRef(trash)));
}
+ // add a sorted dv field sometimes
+ document.removeFields("sparseset");
+ if (random.nextBoolean()) {
+ document.add(new SortedDocValuesField("sparseset", new
BytesRef(title)));
+ }
Review Comment:
This function is also used in `TestDuelingCodecsAtNight`. This comment:
https://github.com/apache/lucene/blob/a94fbb79ac6e60c1ebfa76b24cab23fabcb60bbf/lucene/core/src/test/org/apache/lucene/index/TestDuelingCodecsAtNight.java#L24
made me a bit concerned that adding an additional field will slow down the
nightlies. But I ran several tests with the same seed both with and without the
above block, and saw no appreciable difference. (In fact, the tests ran
slightly faster on average with new field, though this must be noise.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
