github-actions[bot] commented on PR #13914:
URL: https://github.com/apache/lucene/pull/13914#issuecomment-2702387083
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
houserjohn commented on PR #13914:
URL: https://github.com/apache/lucene/pull/13914#issuecomment-2667735504
Here are the promised modified randomized unit tests. These should work with
your API change, but you might need to modify them to suit the caveat you
mentioned. Of course, add the co
houserjohn commented on PR #13914:
URL: https://github.com/apache/lucene/pull/13914#issuecomment-2666762847
@HoustonPutman I can confirm that the latest commits fixed the exception in
`testComputeDynamicNumericRangesWithLargeTopN` and the issue in
`testComputeDynamicNumericRangesWithSameWei
HoustonPutman commented on PR #13914:
URL: https://github.com/apache/lucene/pull/13914#issuecomment-2663827155
> I know you mentioned there is a change in behavior in the caveat, but I do
believe that this example should probably return ranges with equal counts.
This one was a `<=` th
HoustonPutman commented on code in PR #13914:
URL: https://github.com/apache/lucene/pull/13914#discussion_r1958610123
##
lucene/facet/src/java/org/apache/lucene/facet/range/DynamicRangeUtil.java:
##
@@ -202,66 +208,83 @@ public SegmentOutput(int hitsLength) {
* is used t
houserjohn commented on code in PR #13914:
URL: https://github.com/apache/lucene/pull/13914#discussion_r1956877159
##
lucene/facet/src/java/org/apache/lucene/facet/range/DynamicRangeUtil.java:
##
@@ -202,66 +208,83 @@ public SegmentOutput(int hitsLength) {
* is used to c
houserjohn commented on PR #13914:
URL: https://github.com/apache/lucene/pull/13914#issuecomment-2658101119
Hey @HoustonPutman, I just published
[GH#14238](https://github.com/apache/lucene/pull/14238) which contains all of
the unit tests that I've created so far. Note that there was a sligh
HoustonPutman commented on code in PR #13914:
URL: https://github.com/apache/lucene/pull/13914#discussion_r1953282099
##
lucene/facet/src/java/org/apache/lucene/facet/range/DynamicRangeUtil.java:
##
@@ -202,66 +208,83 @@ public SegmentOutput(int hitsLength) {
* is used t
HoustonPutman commented on code in PR #13914:
URL: https://github.com/apache/lucene/pull/13914#discussion_r1953286478
##
lucene/facet/src/java/org/apache/lucene/facet/range/DynamicRangeUtil.java:
##
@@ -202,66 +208,83 @@ public SegmentOutput(int hitsLength) {
* is used t
HoustonPutman commented on code in PR #13914:
URL: https://github.com/apache/lucene/pull/13914#discussion_r1953123437
##
lucene/facet/src/java/org/apache/lucene/facet/range/DynamicRangeUtil.java:
##
@@ -202,66 +208,83 @@ public SegmentOutput(int hitsLength) {
* is used t
stefanvodita commented on code in PR #13914:
URL: https://github.com/apache/lucene/pull/13914#discussion_r1944983208
##
lucene/facet/src/java/org/apache/lucene/facet/range/DynamicRangeUtil.java:
##
@@ -202,66 +208,83 @@ public SegmentOutput(int hitsLength) {
* is used to
houserjohn commented on code in PR #13914:
URL: https://github.com/apache/lucene/pull/13914#discussion_r1944050856
##
lucene/facet/src/java/org/apache/lucene/facet/range/DynamicRangeUtil.java:
##
@@ -202,66 +208,83 @@ public SegmentOutput(int hitsLength) {
* is used to c
houserjohn commented on PR #13914:
URL: https://github.com/apache/lucene/pull/13914#issuecomment-2638750375
This is a great improvement for Dynamic Ranges @HoustonPutman! After looking
into some more test cases, I believe there may be a bug for *some* unsorted
value lists. Consider this uni
github-actions[bot] commented on PR #13914:
URL: https://github.com/apache/lucene/pull/13914#issuecomment-2466522248
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
stefanvodita commented on code in PR #13914:
URL: https://github.com/apache/lucene/pull/13914#discussion_r1817832373
##
lucene/facet/src/java/org/apache/lucene/facet/range/DynamicRangeUtil.java:
##
@@ -202,66 +208,83 @@ public SegmentOutput(int hitsLength) {
* is used to
stefanvodita commented on code in PR #13914:
URL: https://github.com/apache/lucene/pull/13914#discussion_r1817835241
##
lucene/core/src/java/org/apache/lucene/util/WeightedSelector.java:
##
@@ -0,0 +1,407 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
HoustonPutman commented on code in PR #13914:
URL: https://github.com/apache/lucene/pull/13914#discussion_r1810967900
##
lucene/facet/src/java/org/apache/lucene/facet/range/DynamicRangeUtil.java:
##
@@ -202,66 +208,83 @@ public SegmentOutput(int hitsLength) {
* is used t
stefanvodita commented on code in PR #13914:
URL: https://github.com/apache/lucene/pull/13914#discussion_r1802116373
##
lucene/facet/src/test/org/apache/lucene/facet/range/TestDynamicRangeUtil.java:
##
@@ -80,24 +84,25 @@ public void
testComputeDynamicNumericRangesWithOneLargeW
mikemccand commented on PR #13914:
URL: https://github.com/apache/lucene/pull/13914#issuecomment-2414026528
I have not looked closely but this sounds very cool!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
HoustonPutman opened a new pull request, #13914:
URL: https://github.com/apache/lucene/pull/13914
Resolves #13760
### Description
This is using a similar approach to how Solr used to compute multiple
percentiles at a single time. Basically utilize the quick select metho
20 matches
Mail list logo
