github-actions[bot] commented on PR #13401:
URL: https://github.com/apache/lucene/pull/13401#issuecomment-2204763316
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
benwtrent commented on PR #13401:
URL: https://github.com/apache/lucene/pull/13401#issuecomment-2176636564
Wanted to touch base on this PR as it seems to have been stalled, mainly by
me.
The only format that would support pluggable similarities would be
`Lucene99HnswVectorsFormat`.
github-actions[bot] commented on PR #13401:
URL: https://github.com/apache/lucene/pull/13401#issuecomment-2161833420
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
Pulkitg64 commented on code in PR #13401:
URL: https://github.com/apache/lucene/pull/13401#discussion_r1617506291
##
lucene/test-framework/src/java/org/apache/lucene/tests/util/LuceneTestCase.java:
##
@@ -3216,10 +3215,11 @@ public static BytesRef newBytesRef(byte[] bytesIn, int
uschindler commented on code in PR #13401:
URL: https://github.com/apache/lucene/pull/13401#discussion_r1616292043
##
lucene/core/src/java/org/apache/lucene/index/VectorSimilarityFunction.java:
##
@@ -16,104 +16,88 @@
*/
package org.apache.lucene.index;
-import static org.a
uschindler commented on code in PR #13401:
URL: https://github.com/apache/lucene/pull/13401#discussion_r1616291449
##
lucene/core/src/java/org/apache/lucene/index/VectorSimilarityFunction.java:
##
@@ -16,104 +16,88 @@
*/
package org.apache.lucene.index;
-import static org.a
uschindler commented on code in PR #13401:
URL: https://github.com/apache/lucene/pull/13401#discussion_r1616290305
##
lucene/test-framework/src/java/org/apache/lucene/tests/util/LuceneTestCase.java:
##
@@ -3216,10 +3215,11 @@ public static BytesRef newBytesRef(byte[] bytesIn, in
ChrisHegarty commented on PR #13401:
URL: https://github.com/apache/lucene/pull/13401#issuecomment-2132962554
> The main motivation behind this change was to get rid of ENUM
implementation which is tightly coupled to field-info. This has caused
inconvenience in deprecating the COSINE functi
Pulkitg64 commented on code in PR #13401:
URL: https://github.com/apache/lucene/pull/13401#discussion_r1613034634
##
lucene/test-framework/src/java/module-info.java:
##
@@ -19,6 +19,7 @@
@SuppressWarnings({"module", "requires-automatic",
"requires-transitive-automatic"})
modu
Pulkitg64 commented on code in PR #13401:
URL: https://github.com/apache/lucene/pull/13401#discussion_r1613033562
##
lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseFieldInfoFormatTestCase.java:
##
@@ -328,6 +332,17 @@ private int getVectorsMaxDimensions(String
Pulkitg64 commented on code in PR #13401:
URL: https://github.com/apache/lucene/pull/13401#discussion_r1613033827
##
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene90/Lucene90FieldInfosFormat.java:
##
@@ -257,11 +269,12 @@ private static DocValuesType ge
Pulkitg64 commented on PR #13401:
URL: https://github.com/apache/lucene/pull/13401#issuecomment-2128847145
> I did kind of change before, and the added complexity and backwards
compatibility concerns just didn't seem warranted. This is why the decision to
do the scorer pluggability was adde
Pulkitg64 commented on PR #13401:
URL: https://github.com/apache/lucene/pull/13401#issuecomment-2128840022
> I have some comments, but this is not a final review. Just things that I
stumbled upon on first walkthrough.
>
> I will have no time to do a closer review soon, so please give
Pulkitg64 commented on code in PR #13401:
URL: https://github.com/apache/lucene/pull/13401#discussion_r1613025309
##
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene90/Lucene90FieldInfosFormat.java:
##
@@ -257,11 +269,12 @@ private static DocValuesType ge
Pulkitg64 commented on code in PR #13401:
URL: https://github.com/apache/lucene/pull/13401#discussion_r1613024700
##
lucene/core/src/java/org/apache/lucene/index/VectorSimilarityFunction.java:
##
@@ -16,104 +16,73 @@
*/
package org.apache.lucene.index;
-import static org.ap
benwtrent commented on PR #13401:
URL: https://github.com/apache/lucene/pull/13401#issuecomment-2128344039
My old PR: https://github.com/apache/lucene/pull/13200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
benwtrent commented on PR #13401:
URL: https://github.com/apache/lucene/pull/13401#issuecomment-2128342633
I did kind of change before, and the added complexity and backwards
compatibility concerns just didn't seem warranted. This is why the decision to
do the scorer pluggability was added
uschindler commented on code in PR #13401:
URL: https://github.com/apache/lucene/pull/13401#discussion_r1611268935
##
lucene/test-framework/src/java/module-info.java:
##
@@ -19,6 +19,7 @@
@SuppressWarnings({"module", "requires-automatic",
"requires-transitive-automatic"})
mod
uschindler commented on code in PR #13401:
URL: https://github.com/apache/lucene/pull/13401#discussion_r1611267014
##
lucene/test-framework/src/java/module-info.java:
##
@@ -19,6 +19,7 @@
@SuppressWarnings({"module", "requires-automatic",
"requires-transitive-automatic"})
mod
uschindler commented on code in PR #13401:
URL: https://github.com/apache/lucene/pull/13401#discussion_r1611267014
##
lucene/test-framework/src/java/module-info.java:
##
@@ -19,6 +19,7 @@
@SuppressWarnings({"module", "requires-automatic",
"requires-transitive-automatic"})
mod
uschindler commented on code in PR #13401:
URL: https://github.com/apache/lucene/pull/13401#discussion_r1611261932
##
lucene/test-framework/src/java/module-info.java:
##
@@ -19,6 +19,7 @@
@SuppressWarnings({"module", "requires-automatic",
"requires-transitive-automatic"})
mod
uschindler commented on code in PR #13401:
URL: https://github.com/apache/lucene/pull/13401#discussion_r1611253555
##
lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseFieldInfoFormatTestCase.java:
##
@@ -328,6 +332,17 @@ private int getVectorsMaxDimensions(String
uschindler commented on code in PR #13401:
URL: https://github.com/apache/lucene/pull/13401#discussion_r1611226882
##
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene90/Lucene90FieldInfosFormat.java:
##
@@ -103,16 +104,27 @@
* VectorSimilarityFunction
Pulkitg64 commented on PR #13401:
URL: https://github.com/apache/lucene/pull/13401#issuecomment-2126303810
Makes sense. Thanks @navneet1v for the suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
navneet1v commented on PR #13401:
URL: https://github.com/apache/lucene/pull/13401#issuecomment-2125994144
+1 on the feature and functionality. I would like to recommend one thing
here:
Can we add the reloading the SPIs functionality for
VectorSimilarityFunctions just like we have fo
Pulkitg64 commented on PR #13401:
URL: https://github.com/apache/lucene/pull/13401#issuecomment-2123880947
@benwtrent @uschindler @ChrisHegarty
Could you please take a look, if you get a chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
Pulkitg64 opened a new pull request, #13401:
URL: https://github.com/apache/lucene/pull/13401
### Description
This PR is to get feedback on the idea and any major changes required in the
commit.
In this commit we are using Java SPI instead of ENUM to define
VectorSimilarityFun
27 matches
Mail list logo
