benwtrent commented on PR #13401: URL: https://github.com/apache/lucene/pull/13401#issuecomment-2128342633
I did kind of change before, and the added complexity and backwards compatibility concerns just didn't seem warranted. This is why the decision to do the scorer pluggability was added to the codecs. How do you communicate to codecs the similarity kind? For example, Vector quantization needs to know if the similarity is cosine. Do we do a "cosine".equals(similarity.name())? That is very fragile. What if some one does an "optimized cosine"? Name conflict or they just cant use vector quantization. What if someone adds an SPI similarity that should be normalized before being quantized? I don't see a way of doing this without leaking this internal dependency (normalization being required) into the similarity SPI, which is weird to me. I just don't think this is feasible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
