Re: [PR] These attributes are better for the final state(#13628) [lucene]

2024-08-12 Thread via GitHub
gsmiller closed pull request #13630: These attributes are better for the final state(#13628) URL: https://github.com/apache/lucene/pull/13630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] These attributes are better for the final state(#13628) [lucene]

2024-08-12 Thread via GitHub
gsmiller commented on PR #13630: URL: https://github.com/apache/lucene/pull/13630#issuecomment-2284113028 Closing in favor of #13639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] These attributes are better for the final state(#13628) [lucene]

2024-08-12 Thread via GitHub
mrhbj commented on code in PR #13630: URL: https://github.com/apache/lucene/pull/13630#discussion_r1713395891 ## lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene99/Lucene99SkipWriter.java: ## @@ -46,8 +46,8 @@ * uptos(position, payload). 4. start offset

Re: [PR] These attributes are better for the final state(#13628) [lucene]

2024-08-09 Thread via GitHub
mrhbj commented on PR #13630: URL: https://github.com/apache/lucene/pull/13630#issuecomment-2278184332 ok i will do this ---Original--- From: "Greg ***@***.***> Date: Fri, Aug 9, 2024 23:12 PM To: ***@***.***>; Cc: ***@***.**@***.***>; Subject: Re: [apache/lu

Re: [PR] These attributes are better for the final state(#13628) [lucene]

2024-08-09 Thread via GitHub
gsmiller commented on code in PR #13630: URL: https://github.com/apache/lucene/pull/13630#discussion_r1711652689 ## lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene99/Lucene99SkipWriter.java: ## @@ -46,8 +46,8 @@ * uptos(position, payload). 4. start off

Re: [PR] These attributes are better for the final state(#13628) [lucene]

2024-08-02 Thread via GitHub
gsmiller commented on code in PR #13630: URL: https://github.com/apache/lucene/pull/13630#discussion_r1701964276 ## lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene99/Lucene99SkipWriter.java: ## @@ -46,8 +46,8 @@ * uptos(position, payload). 4. start off

[PR] These attributes are better for the final state(#13628) [lucene]

2024-08-02 Thread via GitHub
mrhbj opened a new pull request, #13630: URL: https://github.com/apache/lucene/pull/13630 These attributes are better for the final state(#13628) ### Description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH