gsmiller commented on code in PR #13630:
URL: https://github.com/apache/lucene/pull/13630#discussion_r1701964276
##########
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene99/Lucene99SkipWriter.java:
##########
@@ -46,8 +46,8 @@
* uptos(position, payload). 4. start offset.
*/
public final class Lucene99SkipWriter extends MultiLevelSkipListWriter {
- private int[] lastSkipDoc;
- private long[] lastSkipDocPointer;
+ private final int[] lastSkipDoc;
+ private final long[] lastSkipDocPointer;
private long[] lastSkipPosPointer;
private long[] lastSkipPayPointer;
Review Comment:
We can make these final too if we tidy the ctor a little bit. Let's go ahead
and do this if we're doing a pass on marking fields `final`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
