Re: [PR] TaskExecutor to cancel all tasks on exception [lucene]

javanna commented on PR #12689: URL: https://github.com/apache/lucene/pull/12689#issuecomment-1777505662 Thanks for the review @jpountz ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] TaskExecutor to cancel all tasks on exception [lucene]

javanna merged PR #12689: URL: https://github.com/apache/lucene/pull/12689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] TaskExecutor to cancel all tasks on exception [lucene]

javanna commented on code in PR #12689: URL: https://github.com/apache/lucene/pull/12689#discussion_r1369190050 ## lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java: ## @@ -64,64 +67,124 @@ public final class TaskExecutor { * @param the return type of the task

Re: [PR] TaskExecutor to cancel all tasks on exception [lucene]

jpountz commented on code in PR #12689: URL: https://github.com/apache/lucene/pull/12689#discussion_r1365756941 ## lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java: ## @@ -64,64 +67,124 @@ public final class TaskExecutor { * @param the return type of the task

Re: [PR] TaskExecutor to cancel all tasks on exception [lucene]

javanna commented on code in PR #12689: URL: https://github.com/apache/lucene/pull/12689#discussion_r1365648915 ## lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java: ## @@ -64,64 +67,124 @@ public final class TaskExecutor { * @param the return type of the task

Re: [PR] TaskExecutor to cancel all tasks on exception [lucene]

jpountz commented on code in PR #12689: URL: https://github.com/apache/lucene/pull/12689#discussion_r1365380977 ## lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java: ## @@ -64,64 +67,124 @@ public final class TaskExecutor { * @param the return type of the task

Re: [PR] TaskExecutor to cancel all tasks on exception [lucene]

javanna commented on code in PR #12689: URL: https://github.com/apache/lucene/pull/12689#discussion_r1363627307 ## lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java: ## @@ -64,64 +67,124 @@ public final class TaskExecutor { * @param the return type of the task

Re: [PR] TaskExecutor to cancel all tasks on exception [lucene]

javanna commented on code in PR #12689: URL: https://github.com/apache/lucene/pull/12689#discussion_r1363626228 ## lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java: ## @@ -64,64 +67,124 @@ public final class TaskExecutor { * @param the return type of the task

Re: [PR] TaskExecutor to cancel all tasks on exception [lucene]

jpountz commented on code in PR #12689: URL: https://github.com/apache/lucene/pull/12689#discussion_r1363513095 ## lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java: ## @@ -64,64 +67,124 @@ public final class TaskExecutor { * @param the return type of the task

Re: [PR] TaskExecutor to cancel all tasks on exception [lucene]

javanna commented on code in PR #12689: URL: https://github.com/apache/lucene/pull/12689#discussion_r1362621950 ## lucene/core/src/test/org/apache/lucene/search/TestTaskExecutor.java: ## @@ -43,7 +47,8 @@ public class TestTaskExecutor extends LuceneTestCase { public static vo

Re: [PR] TaskExecutor to cancel all tasks on exception [lucene]

javanna commented on code in PR #12689: URL: https://github.com/apache/lucene/pull/12689#discussion_r1362621950 ## lucene/core/src/test/org/apache/lucene/search/TestTaskExecutor.java: ## @@ -43,7 +47,8 @@ public class TestTaskExecutor extends LuceneTestCase { public static vo

Re: [PR] TaskExecutor to cancel all tasks on exception [lucene]

javanna commented on code in PR #12689: URL: https://github.com/apache/lucene/pull/12689#discussion_r1362621063 ## lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java: ## @@ -64,64 +67,124 @@ public final class TaskExecutor { * @param the return type of the task

Re: [PR] TaskExecutor to cancel all tasks on exception [lucene]

javanna commented on code in PR #12689: URL: https://github.com/apache/lucene/pull/12689#discussion_r1362620375 ## lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java: ## @@ -64,64 +67,124 @@ public final class TaskExecutor { * @param the return type of the task

[PR] TaskExecutor to cancel all tasks on exception [lucene]

javanna opened a new pull request, #12689: URL: https://github.com/apache/lucene/pull/12689 When operations are parallelized, like query rewrite, or search, or createWeight, one of the tasks may throw an exception. In that case we wait for all tasks to be completed before re-throwing th