javanna commented on code in PR #12689:
URL: https://github.com/apache/lucene/pull/12689#discussion_r1362621950
##########
lucene/core/src/test/org/apache/lucene/search/TestTaskExecutor.java:
##########
@@ -43,7 +47,8 @@ public class TestTaskExecutor extends LuceneTestCase {
public static void createExecutor() {
executorService =
Executors.newFixedThreadPool(
- 1, new NamedThreadFactory(TestTaskExecutor.class.getSimpleName()));
+ random().nextBoolean() ? 1 : 2,
+ new NamedThreadFactory(TestTaskExecutor.class.getSimpleName()));
Review Comment:
we have a test that verifies the case for multiple exceptions, which becomes
impossible to reproduce with a single threaded pool, because the first
exception makes us cancel all other tasks, hence you can't have another
exception thrown. That's why I randomized the pool size between 1 and 2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
